Re: [ovirt-devel] New design for the Gerrit UI
by Phillip Bailey
It looks great to me, except for one issue. The contrast between the box
around the active item on the second row and the header background color is
too low to make the active item easily identifiable. The same goes for the
box on the first row, but the underline makes it a non-issue. I recommend
either adding an underline to the second row active item or selecting a
better background color for it.
-Phillip Bailey
On Mon, May 8, 2017 at 2:40 AM, Eldan Hildesheim <info(a)eldanet.com> wrote:
> Hi,
> Can we insert a new css package easily? Perhaps I can merge Patternfly
> inside which will be very suitable for this case.
> E.
>
> On May 7, 2017, at 11:41 PM, Roy Golan <rgolan(a)redhat.com> wrote:
>
>
> The footer links are useful but the footer itself has no presence. Most
> dashboards will fill a page and with such a thin footer nobody is going to
> look at what is has to offer. So we can make the footer in a different
> color and noticeable etc or move the links to the header.
>
> On Sun, May 7, 2017 at 10:35 AM Barak Korren <bkorren(a)redhat.com> wrote:
>
>> The current scheme seems a little buggy on FF. See how the top green bar
>> is not stretched to cover the top of the oVirt logo.
>>
>>
>>
>> On 6 May 2017 at 12:49, Yaniv Kaul <ykaul(a)redhat.com> wrote:
>>
>>>
>>>
>>> On Fri, May 5, 2017 at 5:33 PM, Greg Sheremeta <gshereme(a)redhat.com>
>>> wrote:
>>>
>>>> Here's my take.
>>>>
>>>> The line on the top is a little thicker than I like, but we have the
>>>> same thickness in oVirt (I checked). I'm ok with shrinking it in both
>>>> places.
>>>>
>>>> I put in the logo from the oVirt login page. I added patternfly and
>>>> bootstrap. Changed the font to OpenSans. Positioned things and fixed
>>>> paddings. Changed the button and form field to patternfly type (blue button)
>>>>
>>>
>>> Looks very good now. I wonder how far are we from being ADA compliant
>>> (also a general question to our UI - I know Patternfly should help us there
>>> as well).
>>> Y.
>>>
>>>
>>>
>>>>
>>>> Best wishes,
>>>> Greg
>>>>
>>>>
>>>> On Fri, May 5, 2017 at 2:15 AM, Roy Golan <rgolan(a)redhat.com> wrote:
>>>>
>>>>>
>>>>> Adding UX people +Eldan Hildesheim <info(a)eldanet.com> +Alexander Wels
>>>>> <awels(a)redhat.com> +Greg Sheremeta <gshereme(a)redhat.com>
>>>>>
>>>>> On Fri, May 5, 2017 at 2:32 AM Martin Perina <mperina(a)redhat.com>
>>>>> wrote:
>>>>>
>>>>>> On Thu, May 4, 2017 at 1:13 PM, Nir Soffer <nsoffer(a)redhat.com> wr
>>>>>> ote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Thu, May 4, 2017 at 4:26 PM Evgheni Dereveanchin <
>>>>>>> ederevea(a)redhat.com> wrote:
>>>>>>>
>>>>>>>> Thanks everyone for the great feedback!
>>>>>>>>
>>>>>>>> So there's two options I see now:
>>>>>>>> 1) keep the default header scheme with white background, just add
>>>>>>>> the project logo into the corner
>>>>>>>> 2) try to adapt to the Patternfly scheme as used in oVirt's Admin
>>>>>>>> UI currently.
>>>>>>>>
>>>>>>>> I've swapped the header background color to #393f45 as used in
>>>>>>>> oVirt for a quick test:
>>>>>>>> https://gerrit-staging.phx.ovirt.org/
>>>>>>>>
>>>>>>>
>>>>>>> Looks good!
>>>>>>>
>>>>>>
>>>>>> Much better for my eyes now, thanks a lot!
>>>>>>
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> The oVirt logo needs little more space around it, and it also should
>>>>>>> be centered vertically.
>>>>>>> Modifying the logo margin to 8px and width to 108px works for me
>>>>>>> using chrome,
>>>>>>> see attached screenshot.
>>>>>>>
>>>>>>> <Screenshot from 2017-05-04 20-11-39.png>
>>>>>>>
>>>>>>> Nir
>>>>>>>
>>>>>>> Is this more readable? If yes - I can continue working in this
>>>>>>>> direction to add gradients
>>>>>>>> and other patternfly style elements.
>>>>>>>>
>>>>>>> Otherwise I'll just go with option 1 and stick to the default style
>>>>>>>> we have now.
>>>>>>>>
>>>>>>>> On Thu, May 4, 2017 at 2:45 PM, Martin Sivak <msivak(a)redhat.com>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> > It will help if someone can suggest an alternate CSS which we
>>>>>>>>> can use or specific color codes,
>>>>>>>>>
>>>>>>>>> Well.. keep it as it is or make it really dark (like the
>>>>>>>>> patternfly menu). I do not care about logos but big area filled with
>>>>>>>>> non-neutral color is always going to be an issue.
>>>>>>>>>
>>>>>>>>> Martin
>>>>>>>>>
>>>>>>>>> On Thu, May 4, 2017 at 2:15 PM, Eyal Edri <eedri(a)redhat.com>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Thu, May 4, 2017 at 3:05 PM, Martin Perina <mperina(a)redhat.com
>>>>>>>>>> > wrote:
>>>>>>>>>>
>>>>>>>>>>> I agree with Milan and Martin, even after few minutes looking at
>>>>>>>>>>> it, the green
>>>>>>>>>>> with combination of white background just made my eyes burning
>>>>>>>>>>> :-(
>>>>>>>>>>>
>>>>>>>>>>> Would it be possible to use more darker colors (at least for top
>>>>>>>>>>> banner/menu)?
>>>>>>>>>>> For example darker colors we use in oVirt engine welcome page ...
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Thanks for the feedback,
>>>>>>>>>> It will help if someone can suggest an alternate CSS which we can
>>>>>>>>>> use or specific color codes,
>>>>>>>>>> otherwise it will be long trial and error process until we'll
>>>>>>>>>> find something that will suite everyone.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Martin
>>>>>>>>>>>
>>>>>>>>>>> On Thu, May 4, 2017 at 5:53 AM, Martin Sivak <msivak(a)redhat.com>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> I agree with Milan here. The light green background makes the
>>>>>>>>>>>> menu
>>>>>>>>>>>> items to be almost unreadable, the search button (slightly
>>>>>>>>>>>> different
>>>>>>>>>>>> green color) blends with the background and generally the color
>>>>>>>>>>>> pulls
>>>>>>>>>>>> my eyes away from the content. I wouldn't feel comfortable
>>>>>>>>>>>> looking at
>>>>>>>>>>>> the screen for a whole day.
>>>>>>>>>>>>
>>>>>>>>>>>> Martin
>>>>>>>>>>>>
>>>>>>>>>>>> On Thu, May 4, 2017 at 9:57 AM, Milan Zamazal <
>>>>>>>>>>>> mzamazal(a)redhat.com> wrote:
>>>>>>>>>>>> > Evgheni Dereveanchin <ederevea(a)redhat.com> writes:
>>>>>>>>>>>> >
>>>>>>>>>>>> >> The Infra team is working on customizing the look of Gerrit
>>>>>>>>>>>> to make it fit
>>>>>>>>>>>> >> better with other oVirt services. I want to share the result
>>>>>>>>>>>> of this
>>>>>>>>>>>> >> effort. Hopefully we can gather some feedback before
>>>>>>>>>>>> applying the design to
>>>>>>>>>>>> >> oVirt's instance of Gerrit.
>>>>>>>>>>>> >>
>>>>>>>>>>>> >> Please visit the Staging instance to check it out:
>>>>>>>>>>>> >>
>>>>>>>>>>>> >> https://gerrit-staging.phx.ovirt.org/
>>>>>>>>>>>> >
>>>>>>>>>>>> > Thank you for the preview. While it fits better with oVirt
>>>>>>>>>>>> services,
>>>>>>>>>>>> > there is one thing that makes me uncomfortable with it: low
>>>>>>>>>>>> contrast.
>>>>>>>>>>>> > The top green bar is probably directly violating Web
>>>>>>>>>>>> Accessibility
>>>>>>>>>>>> > Guidelines (AA level; see
>>>>>>>>>>>> > https://www.w3.org/TR/WCAG20/#visual-audio-contrast-contrast),
>>>>>>>>>>>> but I
>>>>>>>>>>>> > find all the green parts harder to read than in the current
>>>>>>>>>>>> version.
>>>>>>>>>>>> > So it would be nice if the contrast could be improved.
>>>>>>>>>>>> >
>>>>>>>>>>>> > Thanks,
>>>>>>>>>>>> > Milan
>>>>>>>>>>>> > _______________________________________________
>>>>>>>>>>>> > Devel mailing list
>>>>>>>>>>>> > Devel(a)ovirt.org
>>>>>>>>>>>> > http://lists.ovirt.org/mailman/listinfo/devel
>>>>>>>>>>>> _______________________________________________
>>>>>>>>>>>> Devel mailing list
>>>>>>>>>>>> Devel(a)ovirt.org
>>>>>>>>>>>> http://lists.ovirt.org/mailman/listinfo/devel
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> _______________________________________________
>>>>>>>>>>> Infra mailing list
>>>>>>>>>>> Infra(a)ovirt.org
>>>>>>>>>>> http://lists.ovirt.org/mailman/listinfo/infra
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> EYAL EDRI
>>>>>>>>>>
>>>>>>>>>> ASSOCIATE MANAGER
>>>>>>>>>>
>>>>>>>>>> RHV DEVOPS
>>>>>>>>>>
>>>>>>>>>> EMEA VIRTUALIZATION R&D
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Red Hat EMEA <https://www.redhat.com/>
>>>>>>>>>> <https://red.ht/sig> TRIED. TESTED. TRUSTED.
>>>>>>>>>> <https://redhat.com/trusted>
>>>>>>>>>> phone: +972-9-7692018 <+972%209-769-2018>
>>>>>>>>>> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> Devel mailing list
>>>>>>>>> Devel(a)ovirt.org
>>>>>>>>> http://lists.ovirt.org/mailman/listinfo/devel
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Regards,
>>>>>>>> Evgheni Dereveanchin
>>>>>>>> _______________________________________________
>>>>>>>> Devel mailing list
>>>>>>>> Devel(a)ovirt.org
>>>>>>>> http://lists.ovirt.org/mailman/listinfo/devel
>>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Devel mailing list
>>>>>>> Devel(a)ovirt.org
>>>>>>> http://lists.ovirt.org/mailman/listinfo/devel
>>>>>>>
>>>>>> _______________________________________________
>>>>>> Infra mailing list
>>>>>> Infra(a)ovirt.org
>>>>>> http://lists.ovirt.org/mailman/listinfo/infra
>>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Greg Sheremeta, MBA
>>>> Sr. Software Engineer
>>>> Red Hat, Inc.
>>>> gshereme(a)redhat.com
>>>>
>>>> _______________________________________________
>>>> Devel mailing list
>>>> Devel(a)ovirt.org
>>>> http://lists.ovirt.org/mailman/listinfo/devel
>>>>
>>>
>>>
>>> _______________________________________________
>>> Infra mailing list
>>> Infra(a)ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/infra
>>>
>>>
>>
>>
>> --
>> Barak Korren
>> RHV DevOps team , RHCE, RHCi
>> Red Hat EMEA
>> redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted
>> _______________________________________________
>> Infra mailing list
>> Infra(a)ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/infra
>>
>
>
> _______________________________________________
> Devel mailing list
> Devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
7 years, 2 months
New design for the Gerrit UI
by Evgheni Dereveanchin
Hi everyone,
The Infra team is working on customizing the look of Gerrit to make it fit
better with other oVirt services. I want to share the result of this
effort. Hopefully we can gather some feedback before applying the design to
oVirt's instance of Gerrit.
Please visit the Staging instance to check it out:
https://gerrit-staging.phx.ovirt.org/
The new design is inspired by oVirt's main website. There is a known glitch
that the "Loading Gerrit Code Review" message is overlapped by the logo
when the UI is loading. If you spot any other issues or have ideas for
improvement feel free to respond to this thread or share your feedback in
the following JIRA ticket:
https://ovirt-jira.atlassian.net/browse/OVIRT-912
--
Regards,
Evgheni Dereveanchin
7 years, 2 months
[oVirt Jenkins] ovirt_4.1_hc-system-tests - Build # 121 - Failure!
by jenkins＠jenkins.phx.ovirt.org
------=_Part_37_1406022858.1498793848501
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Project: http://jenkins.ovirt.org/job/ovirt_4.1_hc-system-tests/
Build: http://jenkins.ovirt.org/job/ovirt_4.1_hc-system-tests/121/
Build Number: 121
Build Status: Failure
Triggered By: Started by timer
-------------------------------------
Changes Since Last Success:
-------------------------------------
Changes for Build #121
[Shlomi Ben-David] Added host details to sso alternate engine fqdns
-----------------
Failed Tests:
-----------------
1 tests failed.
FAILED: 002_bootstrap.add_hosts
Error Message:
Host lago-hc-basic-suite-4-1-host1 failed to install
-------------------- >> begin captured logging << --------------------
ovirtlago.testlib: ERROR: * Unhandled exception in <function _host_is_up at 0x4a30c08>
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 217, in assert_equals_within
res = func()
File "/home/jenkins/workspace/ovirt_4.1_hc-system-tests/ovirt-system-tests/hc-basic-suite-4.1/test-scenarios/002_bootstrap.py", line 150, in _host_is_up
raise RuntimeError('Host %s failed to install' % host.name())
RuntimeError: Host lago-hc-basic-suite-4-1-host1 failed to install
--------------------- >> end captured logging << ---------------------
Stack Trace:
File "/usr/lib64/python2.7/unittest/case.py", line 369, in run
testMethod()
File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 129, in wrapped_test
test()
File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 59, in wrapper
return func(get_test_prefix(), *args, **kwargs)
File "/home/jenkins/workspace/ovirt_4.1_hc-system-tests/ovirt-system-tests/hc-basic-suite-4.1/test-scenarios/002_bootstrap.py", line 163, in add_hosts
testlib.assert_true_within(_host_is_up, timeout=15 * 60)
File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 256, in assert_true_within
assert_equals_within(func, True, timeout, allowed_exceptions)
File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 217, in assert_equals_within
res = func()
File "/home/jenkins/workspace/ovirt_4.1_hc-system-tests/ovirt-system-tests/hc-basic-suite-4.1/test-scenarios/002_bootstrap.py", line 150, in _host_is_up
raise RuntimeError('Host %s failed to install' % host.name())
Host lago-hc-basic-suite-4-1-host1 failed to install
-------------------- >> begin captured logging << --------------------
ovirtlago.testlib: ERROR: * Unhandled exception in <function _host_is_up at 0x4a30c08>
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/ovirtlago/testlib.py", line 217, in assert_equals_within
res = func()
File "/home/jenkins/workspace/ovirt_4.1_hc-system-tests/ovirt-system-tests/hc-basic-suite-4.1/test-scenarios/002_bootstrap.py", line 150, in _host_is_up
raise RuntimeError('Host %s failed to install' % host.name())
RuntimeError: Host lago-hc-basic-suite-4-1-host1 failed to install
--------------------- >> end captured logging << ---------------------
------=_Part_37_1406022858.1498793848501--
7 years, 4 months
oVirt infra daily report - unstable production jobs - 369
by jenkins＠jenkins.phx.ovirt.org
------=_Part_56_304817550.1498863602574
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Good morning!
Attached is the HTML page with the jenkins status report. You can see it also here:
- http://jenkins.ovirt.org/job/system_jenkins-report/369//artifact/exported...
Cheers,
Jenkins
------=_Part_56_304817550.1498863602574
Content-Type: text/html; charset=us-ascii; name=upstream_report.html
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=upstream_report.html
Content-ID: <upstream_report.html>
<!DOCTYPE html><head><style type="text/css">
table.gridtable {
border-collapse: collapse;
table-layout:fixed;
width:1600px;
font-family: monospace;
font-size:13px;
}
.head {
font-size:20px;
font-family: arial;
}
.sub {
font-size:18px;
background-color:#e5e5e5;
font-family: arial;
}
pre {
font-family: monospace;
display: inline;
white-space: pre-wrap;
white-space: -moz-pre-wrap !important;
white-space: -pre-wrap;
white-space: -o-pre-wrap;
word-wrap: break-word;
}
</style>
</head>
<body>
<table class="gridtable" border=2>
<tr><th colspan=2 class=head>
RHEVM CI Jenkins Daily Report - 30/06/2017
</th></tr><tr><th colspan=2 class=sub>
<font color="blue"><a href="http://jenkins.ovirt.org/">00 Unstable Critical</a></font>
</th></tr>
<tr><td>
<a href="http://jenkins.ovirt.org/job/ovirt_4.1_hc-system-tests/">ovirt_4.1_hc-system-tests</a>
</td><td>
This job is automatically updated by jenkins job builder, any manual
change will be lost in the next update. If you want to make permanent
changes, check out the <a href="http://gerrit.ovirt.org/gitweb?p=jenkins.git;a=tree;h=refs/heads/master;h...">
jenkins</a> repo.
<!-- Managed by Jenkins Job Builder -->
</td></tr>
<tr><td>
<a href="http://jenkins.ovirt.org/job/ovirt_master_he-system-tests/">ovirt_master_he-system-tests</a>
</td><td>
This job is automatically updated by jenkins job builder, any manual
change will be lost in the next update. If you want to make permanent
changes, check out the <a href="http://gerrit.ovirt.org/gitweb?p=jenkins.git;a=tree;h=refs/heads/master;h...">
jenkins</a> repo.
<!-- Managed by Jenkins Job Builder -->
</td></tr>
------=_Part_56_304817550.1498863602574--
7 years, 4 months
