December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: cpu host feature
by dfediuck＠redhat.com 20 Dec '12

20 Dec '12

Doron Fediuck has submitted this change and it was merged. Change subject: engine: cpu host feature ...................................................................... engine: cpu host feature Adds the engine-side support for cpu-host feature http://www.ovirt.org/Features/Cpu-host_Support Bug-Url: https://bugzilla.redhat.com/838469 Change-Id: I84bfce49a3b74595e68dfc1e7494dd20008ac9bc Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_02_0090_cpuhost_support.sql M backend/manager/dbscripts/vms_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/CpuMode.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 27 files changed, 158 insertions(+), 18 deletions(-) Approvals: Laszlo Hornyak: Verified Greg Padgett: Looks good to me, but someone else must approve Doron Fediuck: Looks good to me, approved Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84bfce49a3b74595e68dfc1e7494dd20008ac9bc Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: windows 8/2012 default user portal console shoul...
by tjelinek＠redhat.com 19 Dec '12

19 Dec '12

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: windows 8/2012 default user portal console should be RDP ...................................................................... userportal: windows 8/2012 default user portal console should be RDP Since windows 8/2012 don't have spice drivers yet, default in user portal should be rdp. Default in admin will stay spice. This default is recalculated if the OS type or the default console changes Change-Id: I019f3f80e020a85fb6b2ae8a855a0c3fe89ba1d6 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleSelectionContext.java 4 files changed, 88 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I019f3f80e020a85fb6b2ae8a855a0c3fe89ba1d6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Audit log messages file EOLs set to Unix
by yzaslavs＠redhat.com 19 Dec '12

19 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: webadmin: Audit log messages file EOLs set to Unix ...................................................................... webadmin: Audit log messages file EOLs set to Unix Change-Id: If119bb5fd0119ea8c8fad54feedd729a43b23cff Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 560 insertions(+), 560 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If119bb5fd0119ea8c8fad54feedd729a43b23cff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: added single vm uptime br46 (#862019)
by ydary＠redhat.com 19 Dec '12

19 Dec '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: added single vm uptime br46 (#862019) ...................................................................... reports: added single vm uptime br46 (#862019) This report contains one gauge displaying the weighted average uptime of a single selected VM for a requested period. Bug-Url: https://bugzilla.redhat.com/862019 Change-Id: I50951e7380be136162bb2beb86ec0ed4bbe46d1e Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/Reports/Service_level/VMs/.folder.xml A reports/repository_files/resources/Reports/Service_level/VMs/single_vm_uptime_br46.xml A reports/repository_files/resources/Reports/Service_level/VMs/single_vm_uptime_br46_files/full details.jrxml.data A reports/repository_files/resources/Reports/Service_level/VMs/single_vm_uptime_br46_files/single_vm_uptime_br46_jrxml.data M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_en_US.properties.data 5 files changed, 746 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10234 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50951e7380be136162bb2beb86ec0ed4bbe46d1e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Adding force option to remove host
by gchaplik＠redhat.com 19 Dec '12

19 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Adding force option to remove host ...................................................................... webadmin: Adding force option to remove host 'Force Remove' checkbox will be shown while removing a host from a gluster only cluster. This is supported for mutiple hosts removals as well, but all the selected hosts should belong to a single gluster cluster. If the user selects force, it internally passes 'force' option to 'gluster peer detach' command. Change-Id: I9fe3814815acff8a5f230c1a3d6ebcb6e3bbc633 Bug-Url: https://bugzilla.redhat.com/882807 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConfirmationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 5 files changed, 51 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fe3814815acff8a5f230c1a3d6ebcb6e3bbc633 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix cluster dialog hang during import
by gchaplik＠redhat.com 19 Dec '12

19 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix cluster dialog hang during import ...................................................................... webadmin: Fix cluster dialog hang during import 1. Cluster dialog was hanging when wrong password is given for the host. This is fixed now. An error message will be shown in case of wrong credentials. 2. If the servers which the user is trying to import is already part of another cluster, an error message will be shown. Change-Id: I717a9aa953f2c8bc41676c2cf91267e38328245f Bug-Url: https://bugzilla.redhat.com/883147 Bug-Url: https://bugzilla.redhat.com/884292 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 4 files changed, 16 insertions(+), 10 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I717a9aa953f2c8bc41676c2cf91267e38328245f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: changes tabs to spaces.
by ydary＠redhat.com 19 Dec '12

19 Dec '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: changes tabs to spaces. ...................................................................... reports: changes tabs to spaces. Change-Id: I0283eeb0a3d1277230ffd5b7021f37c96f00ebdf Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_entities_counts_list_dr3.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_ha_vm_uptime_status_dr13.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_host_resources_status_dr12.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_host_uptime_status_dr6.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_summary_of_hosts_resources_usage_dr28.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_top_five_busiest_hosts_dr23.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/cluster_vm_over_commit_status_dr14.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/no_used/cluster_capacity_vs_usage_cores_dr29.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/no_used/cluster_capacity_vs_usage_mem_dr30.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/no_used/top_five_ha_virtual_servers_uptime_dr19.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/no_used/top_five_hosts_uptime_dr17.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/top_five_ha_virtual_servers_downtime_dr20.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/top_five_hosts_downtime_dr18.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/datacenter_top_five_busiest_clusters_dr21.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/dc_entities_counts_list_dr2.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/dc_host_resources_status_dr11.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/dc_host_uptime_status_dr5.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/dc_storage_space_status_dr8.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/dc_summary_of_cluster_hosts_resources_usage_dr27.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/dc_top_five_used_storage_domain_dr26.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/not_used/datacenter_top_five_least_busy_clusters_dr22.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/not_used/dc_vm_over_commit_dr25.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/not_used/top_five_clusters_host_uptime_dr15.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/top_five_clusters_host_downtime_dr16.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/system_dashboard/system_entities_counts_list_dr1.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/system_dashboard/system_host_resources_status_dr10.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/system_dashboard/system_host_uptime_status_dr4.xml M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/system_dashboard/system_storage_space_status_dr7.xml M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard.xml M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard.xml M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/system_dashboard.xml 31 files changed, 280 insertions(+), 280 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0283eeb0a3d1277230ffd5b7021f37c96f00ebdf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: added storage count to webadmin dashboards (#854949...
by ydary＠redhat.com 19 Dec '12

19 Dec '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: added storage count to webadmin dashboards (#854949) ...................................................................... reports: added storage count to webadmin dashboards (#854949) Webadmin dashboards now display storage domains count in entities counts list in datacenter and system. Bug-Url: https://bugzilla.redhat.com/854949 Change-Id: Ibdfd2a6a215380253fcf7f7db3fd61016bea5c93 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/dc_entities_counts_list_dr2_files/dc_entities_counts_list_dr2_jrxml.data M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/system_dashboard/system_entities_counts_list_dr1_files/system_entities_counts_list_dr1_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard_files/dc_entities_counts_list_dr2_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/system_dashboard_files/system_entities_counts_list_dr1_jrxml.data 4 files changed, 166 insertions(+), 30 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10226 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdfd2a6a215380253fcf7f7db3fd61016bea5c93 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fixing refresh issues in Cluster Services
by gchaplik＠redhat.com 19 Dec '12

19 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fixing refresh issues in Cluster Services ...................................................................... webadmin: Fixing refresh issues in Cluster Services Empty services tab will be shown if the selected cluster does not have any online hosts. Host list in the Cluster services tab will be refreshed only when selecting a different cluster. Change-Id: I4247e6a0814ea73a7b86910fed8a24b9bccea02c Bug-Url: https://bugzilla.redhat.com/885624 Bug-Url: https://bugzilla.redhat.com/885679 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterServiceModel.java 1 file changed, 38 insertions(+), 22 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4247e6a0814ea73a7b86910fed8a24b9bccea02c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Cluster Dialog - using RadioButton for services
by gchaplik＠redhat.com 19 Dec '12

19 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Cluster Dialog - using RadioButton for services ...................................................................... webadmin: Cluster Dialog - using RadioButton for services Cluster with Virt and Gluster will be allowed only if the configuration property AllowGlusterWithVirtGlusterEnabled=true. There is a validation already present to check the above condition in the engine backend. In the Cluster Dialog, the oVirt and Gluster check boxes will be replaced by Radio Buttons if AllowGlusterWithVirtGlusterEnabled=false. Change-Id: I94ae82c605c6fa47e846efc17a7870b6b3a8c9c6 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/cluster/ClusterPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 6 files changed, 180 insertions(+), 58 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9836 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94ae82c605c6fa47e846efc17a7870b6b3a8c9c6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0