December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: Fix NPE in VM list models
by vszocs＠redhat.com 19 Dec '12

19 Dec '12

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal: Fix NPE in VM list models ...................................................................... userportal: Fix NPE in VM list models Change-Id: Ib9968567971141bf3e0b95c2220ec403555fafbd Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10172 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9968567971141bf3e0b95c2220ec403555fafbd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Wrong error level for USER_FAILED_ATTACH_DISK_TO_VM ...
by asaf＠redhat.com 19 Dec '12

19 Dec '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: engine: Wrong error level for USER_FAILED_ATTACH_DISK_TO_VM msg ...................................................................... engine: Wrong error level for USER_FAILED_ATTACH_DISK_TO_VM msg Specified error level for USER_FAILED_ATTACH_DISK_TO_VM message. The error level for instance affects the visual representation of the message in the webadmin interface. Change-Id: Id0202766ecae08a0bfa78a149f089d3e4bf96f52 Bug-Url: https://bugzilla.redhat.com/848367 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0202766ecae08a0bfa78a149f089d3e4bf96f52 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Quota Monitors - userportal
by gchaplik＠redhat.com 19 Dec '12

19 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal: Quota Monitors - userportal ...................................................................... userportal: Quota Monitors - userportal This patch is the 3rd out of 3. SideTabExtendedResourcesView was changed to include Quota Monitors (see full details on feature page - wiki.ovirt.org/Features/Design/Quota-3.2) ResourcesModel was changed to support the UI change A new Widget QuotaProgressBar was designed for the monitors. Change-Id: Idbecbf9233704c2cd5e485f3c4158c9a78559218 Bug-Url: https://bugzilla.redhat.com/876903 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/AdvancedParametersExpander.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/resources/ResourcesModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedResourceView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedResourceView.ui.xml A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/DoublePercentageProgressBar.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/DoublePercentageProgressBar.ui.xml A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaProgressBar.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/resources/VmTable.java 11 files changed, 833 insertions(+), 152 deletions(-) Approvals: ofri masad: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbecbf9233704c2cd5e485f3c4158c9a78559218 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Quota Monitors - webadmin
by gchaplik＠redhat.com 19 Dec '12

19 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Quota Monitors - webadmin ...................................................................... webadmin: Quota Monitors - webadmin This patch is the 2nd out of 3. Quota monitoring is added to the webadmin as columns in the MainTabQuotaView. Change-Id: I39aaf87f084a31b6ff31412030517a2f19bbe1af Bug-Url: https://bugzilla.redhat.com/876903 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/QuotaPercentColumn.java 3 files changed, 228 insertions(+), 32 deletions(-) Approvals: ofri masad: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39aaf87f084a31b6ff31412030517a2f19bbe1af Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Quota Monitors - backend
by gchaplik＠redhat.com 19 Dec '12

19 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: Quota Monitors - backend ...................................................................... engine: Quota Monitors - backend This patch is the 1st out of 3. It sets the backend support for adding Quota Monitoring to the UI. a new entity is defined "QuotaPerUserUsageEntity" - to allow passing usage data to the UI. Two new methods are added to the QuotaManager API in order to allow using the QuotaManager cache for the monitoring in the UI. Two Querier are also changed to support the new data and API Change-Id: I67770aefec191832d0c5bb69fbaba82cd0e6febb Bug-Url: https://bugzilla.redhat.com/876903 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetQuotasConsumptionForCurrentUserQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaUsagePerUser.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetQuotasConsumptionForCurrentUserQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 8 files changed, 467 insertions(+), 8 deletions(-) Approvals: ofri masad: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67770aefec191832d0c5bb69fbaba82cd0e6febb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-dwh[master]: history: removed unused columns.
by ydary＠redhat.com 18 Dec '12

18 Dec '12

Yaniv Dary has submitted this change and it was merged. Change subject: history: removed unused columns. ...................................................................... history: removed unused columns. Change-Id: I95f6906702e561bbcddd9d334d2760b875651b9f Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/historydbscripts_postgres/create_views_3_2.sql M data-warehouse/historydbscripts_postgres/upgrade/03_02_0010_add_vm_users_usage_tables.sql 2 files changed, 0 insertions(+), 8 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95f6906702e561bbcddd9d334d2760b875651b9f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: Added CCP VM Inventory BR44 (#883137)
by ydary＠redhat.com 18 Dec '12

18 Dec '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: Added CCP VM Inventory BR44 (#883137) ...................................................................... reports: Added CCP VM Inventory BR44 (#883137) This report displays a list of virtual machines by OS of the selected data center and cluster and their respected uptime and existence time. This is required for billing cloud providers. Change-Id: I6fbdba60270472bdfd94094de270132fae52dd7d Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/Reports/Inventory/.folder.xml A reports/repository_files/resources/Reports/Inventory/ccp_vm_inventory_br44.xml A reports/repository_files/resources/Reports/Inventory/ccp_vm_inventory_br44_files/ccp_vm_inventory_br44_jrxml.data A reports/repository_files/resources/Reports/Inventory/ccp_vm_inventory_br44_files/full details.jrxml.data M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_en_US.properties.data 5 files changed, 934 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fbdba60270472bdfd94094de270132fae52dd7d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fixing a possible bug at SPM election
by mkublin＠redhat.com 18 Dec '12

18 Dec '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Fixing a possible bug at SPM election ...................................................................... engine: Fixing a possible bug at SPM election The mCurrentVdsId should be set to null after GetPrioritizedVdsInPool(), because it used there Change-Id: I44dfbb3a59c22e1b4ce39c996e159e1fd5047475 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44dfbb3a59c22e1b4ce39c996e159e1fd5047475 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ValidationResult private default constructor
by amureini＠redhat.com 18 Dec '12

18 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: ValidationResult private default constructor ...................................................................... core: ValidationResult private default constructor ValidationResult's default constructor should be private (according to its javadoc), and valid results should be referenced via the constant ValidationResult.VALID. Most occurrences in the code adhere to this rule, except for a single occurrence in AddDiskToVmCommandTest. This patch returns the default constructor to its intended private state and fixes the faulty usage in AddDiskToVmCommandTest. Change-Id: I7afa82aa1ec489b52da78b97b91c2a48eefb8b5f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7afa82aa1ec489b52da78b97b91c2a48eefb8b5f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImportVm: disk alias with copyCollapse=false
by amureini＠redhat.com 18 Dec '12

18 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVm: disk alias with copyCollapse=false ...................................................................... core: ImportVm: disk alias with copyCollapse=false Added disk aliases in ImportVmCommand when copyCollapse=false. This patch contains the following: 1. The bug fix. 2. A test for the bug. 3. Some minor refactoring to extract blocks of ImportVmCommand DAO handling to methods, so they can be mocked out for the test mentioned in (2). Change-Id: I4f03699ece4d20f2d20beb791c3cb1518e39c4d1 Bug-Url: https://bugzilla.redhat.com/872506 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java 2 files changed, 69 insertions(+), 22 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/9631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f03699ece4d20f2d20beb791c3cb1518e39c4d1 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0