May 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix hierarchy of Bond Parameters classes
by masayag＠redhat.com 30 May '12

30 May '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Fix hierarchy of Bond Parameters classes ...................................................................... core: Fix hierarchy of Bond Parameters classes The patch extracts a base class for Bond Parameters classes. It also contains adjustment of naming to Java standards and organizes classes accordingly. In addition, the vlanTag attribute was deleted from AddBondParameters since it isn't being in used and it is a duplication of the vlanId attribute. Change-Id: I04fdfa603cd6710f7966b9df69858b5db727547f Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsBondCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddBondParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/BondParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveBondParameters.java 4 files changed, 115 insertions(+), 111 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04fdfa603cd6710f7966b9df69858b5db727547f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use ping verb to check connectivity with host
by masayag＠redhat.com 30 May '12

30 May '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Use ping verb to check connectivity with host ...................................................................... core: Use ping verb to check connectivity with host The previous check connectivity used the getCapabilities verb to verify ovirt-engine is capable of connecting to the host. However, it was used only to assure the host is responsive and accessible, regardless the returned data from the getCapabilities. The patch replaces the use of 'getCapabilities' with 'ping' verb, which is lighter and should response quicker, with less processing done on the host. Change-Id: Ic528aad6a3489d133da4b8c56c07cb6363e0de2f Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PollVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 4 files changed, 11 insertions(+), 7 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic528aad6a3489d133da4b8c56c07cb6363e0de2f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Make dependency on commons-collections explicit
by dfediuck＠redhat.com 30 May '12

30 May '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: Make dependency on commons-collections explicit ...................................................................... core: Make dependency on commons-collections explicit The VmOldInfoBuilder class uses classes from commons-collections, but the POM doesn't include an explicit dependency for the corresponding artifact. This may work because of transitive dependencies, but it is an error and with some versions of maven the build can fail, in particular it fails in Fedora 17 with mvn-rpmbuild. Change-Id: I706ad219c604871fa47924941448d429fe2a188d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/vdsbroker/pom.xml 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I706ad219c604871fa47924941448d429fe2a188d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Used host name instead of vds name in gluster peer d...
by ofrenkel＠redhat.com 30 May '12

30 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Used host name instead of vds name in gluster peer detach ...................................................................... engine: Used host name instead of vds name in gluster peer detach - Added missing error message in the AppErrors class Change-Id: I914149491fc1f0d85368470da22f09ce59c2d28a Signed-off-by: Dhandapani <dgopal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Looks good to me, approved Dhandapani Gopal: Verified -- To view, visit http://gerrit.ovirt.org/4827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I914149491fc1f0d85368470da22f09ce59c2d28a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: move resource utils to appropriate package
by oliel＠redhat.com 30 May '12

30 May '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: move resource utils to appropriate package ...................................................................... restapi: move resource utils to appropriate package Previous commit created a utils package in org.ovirt.engine.api.resource.utils. Moving it to the appropriate package, which is org.ovirt.engine.api.restapi.resource.utils. Change-Id: I3ecafa45e759b59c0404587fc1bc8710d726f62f Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/UsbResourceUtils.java R backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/utils/test/UsbResourceUtilsTest.java 6 files changed, 7 insertions(+), 6 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ecafa45e759b59c0404587fc1bc8710d726f62f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Update the brick status during add brick
by ofrenkel＠redhat.com 30 May '12

30 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Update the brick status during add brick ...................................................................... engine: Update the brick status during add brick - Updated the brick status up/down depends on the volume status - Update the brick server name Change-Id: I9cecab74d19cf1aa925173320b6fb27612c88a9e Signed-off-by: Dhandapani <dgopal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommandTest.java 2 files changed, 44 insertions(+), 7 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Dhandapani Gopal: Verified -- To view, visit http://gerrit.ovirt.org/4825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cecab74d19cf1aa925173320b6fb27612c88a9e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Refactor LdapProviderType and LdapVendorNameEnum
by rgolan＠redhat.com 30 May '12

30 May '12

Roy Golan has submitted this change and it was merged. Change subject: engine: Refactor LdapProviderType and LdapVendorNameEnum ...................................................................... engine: Refactor LdapProviderType and LdapVendorNameEnum This patch is still a work in progress. Its not complete and there are holes in it. Like when merging LdapProviderType and LdapVendorNameEnum I did not see a Vendor Name with AD. Need to know what goes there. Also need to know what to do with 'general'. I am emailing it out early to get feedback. There will be more versions of it out based on feedback. Roy and Yair, Is this what you were thinking? Change-Id: I9d9e8ba5f7ada715c9016450d231177b2c69e2fb Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/Domain.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GSSAPILdapTemplateWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSE.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GetRootDSETask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LDAPTemplateWrapper.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapProviderType.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryExecutionBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryExecutionBuilderImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryMetadataFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryMetadataFactoryImpl.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapVendorNameEnum.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/RootDSEFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/SimpleLdapTemplateWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/UsersDomainsCacheManagerService.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/ldap/LdapTester.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/LdapProviderType.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/LdapVendorNameEnum.java 18 files changed, 35 insertions(+), 49 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d9e8ba5f7ada715c9016450d231177b2c69e2fb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix jobProperties for delete vm and template from expo...
by ofrenkel＠redhat.com 29 May '12

29 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix jobProperties for delete vm and template from export (#818111) ...................................................................... core: fix jobProperties for delete vm and template from export (#818111) https://bugzilla.redhat.com/show_bug.cgi?id=818111 when removing vm/template from export domain, the job properties tried to use entities from db, which are not always available, and not correct to use. this fix implement override for getVm() and getVmTemplate() to get from export domain, and use it. most of the code was just moved from canDoAction also set the domain name which was not set, and fixed in ExecutionMessages.properties to the right var name Change-Id: I936501874e9a29b18bdddf1b65e7150e88cfe475 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 3 files changed, 102 insertions(+), 39 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I936501874e9a29b18bdddf1b65e7150e88cfe475 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adding support for VDSM version 4.10 (#822158)
by yzaslavs＠redhat.com 29 May '12

29 May '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Adding support for VDSM version 4.10 (#822158) ...................................................................... core: Adding support for VDSM version 4.10 (#822158) https://bugzilla.redhat.com/822158 Until we move to 3 part VDSM version at engine code, we will modify VDSM software version to be 4.10. This change is the required engine part for it Change-Id: I3b9e303b212ee961c68bbfb3c09f5a8d3a829a8c Acked-By: Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b9e303b212ee961c68bbfb3c09f5a8d3a829a8c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Fixed test failure in BackendGlusterBrickResourceTe...
by mpastern＠redhat.com 29 May '12

29 May '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Fixed test failure in BackendGlusterBrickResourceTest ...................................................................... restapi: Fixed test failure in BackendGlusterBrickResourceTest The name of the action parameter for replace brick was changed from newBrick to just brick, but some related changes were missing in the resource class and test case. Fixed the same. Change-Id: Ie08c8c4518ef4617c7cd8f9fa16dfae6a2f02944 Signed-off-by: Selvasundaram <sesubram(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResourceTest.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4870 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie08c8c4518ef4617c7cd8f9fa16dfae6a2f02944 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0