January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Config mocking in StoragePoolValidatorTest
by amureini＠redhat.com 24 Jan '13

24 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Config mocking in StoragePoolValidatorTest ...................................................................... core: Config mocking in StoragePoolValidatorTest Used the standard was of mocking Config - MockConfigRule. This refactoring enables removing the useless getConfigValue method from the StoragePoolValidator class, and just call Config.GetValue directly instead. Change-Id: I03c0f2a1c013cd12010be7f84d896c1d1e600c29 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StoragePoolValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StoragePoolValidatorTest.java 2 files changed, 13 insertions(+), 15 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11319 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03c0f2a1c013cd12010be7f84d896c1d1e600c29 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: persist LUN with correct volume_group_id
by amureini＠redhat.com 24 Jan '13

24 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: persist LUN with correct volume_group_id ...................................................................... core: persist LUN with correct volume_group_id When saving a LUN object to the db, we specify what is the needed volume group. In case of an existing LUN - its volume group id would be updated to the new given value. In case that the given LUN isn't in the DB, it'll be saved. This patch ensures that the saved LUN would be saved with the given volume_group_id. NOTES: The motivation for this change is that in cases in which we get the LUN info from VDSM and the LUN is part of an existing VG, saving it with unknown VG to the system will prevent removal of the LUN when it won't be used anymore by the system and might cause confusion and inconsistency. Change-Id: Ia4404b0d17b107208e5ec00c688db305ba0e65fe Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4404b0d17b107208e5ec00c688db305ba0e65fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: correct storage type for FCP luns
by amureini＠redhat.com 24 Jan '13

24 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: correct storage type for FCP luns ...................................................................... core: correct storage type for FCP luns When LUN has no connections, it's storage type is FCP. Change-Id: Ic6ce68f3451aee0ca540cb6289d38782abf94ae7 related to Bug-Url: https://bugzilla.redhat.com/875909 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetLunsByVgIdQuery.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6ce68f3451aee0ca540cb6289d38782abf94ae7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: minor refactoring in InternalMigrateVmParameters
by ofrenkel＠redhat.com 24 Jan '13

24 Jan '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: minor refactoring in InternalMigrateVmParameters ...................................................................... core: minor refactoring in InternalMigrateVmParameters Reduce code duplication in the constructors of InternalMigrateVmParameters by replacing the duplicate code, with delegation Change-Id: Ie1b484517a5c82555617bfabc81aab6d687ed005 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmParameters.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1b484517a5c82555617bfabc81aab6d687ed005 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: [RFE] Display Address Override
by mpastern＠redhat.com 24 Jan '13

24 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: [RFE] Display Address Override ...................................................................... restapi: [RFE] Display Address Override Detailed description: http://wiki.ovirt.org/wiki/Features/Display_Address_Override Added display_address optional string field to Host. Change-Id: I105881365d2c23638a1a9ad4db3b82a352f039e3 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java 4 files changed, 17 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I105881365d2c23638a1a9ad4db3b82a352f039e3 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-reports[master]: build: sync with ovirt-engine build
by ydary＠redhat.com 24 Jan '13

24 Jan '13

Yaniv Dary has submitted this change and it was merged. Change subject: build: sync with ovirt-engine build ...................................................................... build: sync with ovirt-engine build Change-Id: Id57e1f74d30eaeda31bd7652f4647c8ae92dadd2 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M Makefile 1 file changed, 11 insertions(+), 12 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id57e1f74d30eaeda31bd7652f4647c8ae92dadd2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: reverted double quotes in some strings (#892940)
by ydary＠redhat.com 24 Jan '13

24 Jan '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: reverted double quotes in some strings (#892940) ...................................................................... reports: reverted double quotes in some strings (#892940) Bug-Url: https://bugzilla.redhat.com/892940 Change-Id: I5c437d80a4e42339b2aa35867eeeedfa93a780a9 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_en_US.properties.data 1 file changed, 17 insertions(+), 17 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c437d80a4e42339b2aa35867eeeedfa93a780a9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Additional clean up of OvfParser
by mkublin＠redhat.com 24 Jan '13

24 Jan '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Additional clean up of OvfParser ...................................................................... engine: Additional clean up of OvfParser The following patch is perfroming additional clean up of OvfParser, OvfVmWriter and OvfWriter Change-Id: I1c2e2d0a455694a4f9aa39e82f370d2085062019 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfParser.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 3 files changed, 22 insertions(+), 31 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11240 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c2e2d0a455694a4f9aa39e82f370d2085062019 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : remove image - if clause order
by derez＠redhat.com 24 Jan '13

24 Jan '13

Daniel Erez has submitted this change and it was merged. Change subject: core : remove image - if clause order ...................................................................... core : remove image - if clause order change if clause order to avoid funcionality change, will be revisited in a further patch. Change-Id: I643b2ab944adb21f05328e8081d3b0b3f9e2c2cc Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java 1 file changed, 8 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I643b2ab944adb21f05328e8081d3b0b3f9e2c2cc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: updated user prompts for stopping ovirt-engine se...
by juan.hernandez＠redhat.com 24 Jan '13

24 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: updated user prompts for stopping ovirt-engine service during setup ...................................................................... packaging: updated user prompts for stopping ovirt-engine service during setup * If the engine service is in state not running, and only in this state, avoid to ask for stopping the service. The script doesn't check for service up and running, avoiding a regression on RHBZ #837812. * Avoid to stop the engine service if already stopped and not configured. Change-Id: I01da6e908a9f396bf4211afe863475d9fc2093be Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=896694 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py 1 file changed, 12 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01da6e908a9f396bf4211afe863475d9fc2093be Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0