January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-image-uploader[master]: build: build rewrite using autotools
by kroberts＠redhat.com 23 Jan '13

23 Jan '13

Keith Robertson has submitted this change and it was merged. Change subject: build: build rewrite using autotools ...................................................................... build: build rewrite using autotools autotools provide simple method to integrate with standard tools such as rpm spec. It also provides easy gettext integration. git version magic was not added to ease maintenance. Package is now install at pythonlib with symbolic link to bindir. Change-Id: If2dabcd40a50e9ec19e796832d83fb9e89d5db24 Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- A .gitignore M AUTHORS A COPYING D Makefile A Makefile.am A README.localization A autogen.sh A build/python.inc A configure.ac A m4/.gitignore A m4/ax_python_module.m4 M ovirt-image-uploader.spec.in A po/.gitignore A po/LINGUAS A po/Makevars A po/POTFILES.in A src/Makefile.am A src/__init__.py R src/__main__.py A src/ovf/Makefile.am 20 files changed, 753 insertions(+), 100 deletions(-) Approvals: Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2dabcd40a50e9ec19e796832d83fb9e89d5db24 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: build: sync with other python packages
by kroberts＠redhat.com 23 Jan '13

23 Jan '13

Keith Robertson has submitted this change and it was merged. Change subject: build: sync with other python packages ...................................................................... build: sync with other python packages Change-Id: I7e0c407cbbe7e1e5afed23bd6448b86b9df9885c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile.am M ovirt-iso-uploader.spec.in M src/Makefile.am 3 files changed, 30 insertions(+), 16 deletions(-) Approvals: Kiril Nesenko: Looks good to me, but someone else must approve Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e0c407cbbe7e1e5afed23bd6448b86b9df9885c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: build: build rewrite using autotools
by kroberts＠redhat.com 23 Jan '13

23 Jan '13

Keith Robertson has submitted this change and it was merged. Change subject: build: build rewrite using autotools ...................................................................... build: build rewrite using autotools autotools provide simple method to integrate with standard tools such as rpm spec. It also provides easy gettext integration. git version magic was not added to ease maintenance. Package is now install at pythonlib with symbolic link to bindir. Change-Id: Ic69b7e9957fb650365f7c36333b90a9e22beadde Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> --- A .gitignore A COPYING D Makefile A Makefile.am A README.localization A autogen.sh A build/python.inc A configure.ac A m4/.gitignore A m4/ax_python_module.m4 M ovirt-log-collector.spec.in A po/.gitignore R po/LINGUAS A po/Makevars A po/POTFILES.in A src/Makefile.am A src/__init__.py R src/__main__.py R src/engine-log-collector.8 A src/helper/Makefile.am R src/helper/__init__.py R src/helper/hypervisors.py R src/logcollector.conf D src/rhev/Makefile A src/sos/Makefile.am D src/sos/plugins/Makefile A src/sos/plugins/Makefile.am R src/tests.py 28 files changed, 819 insertions(+), 156 deletions(-) Approvals: Kiril Nesenko: Verified; Looks good to me, but someone else must approve Keith Robertson: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic69b7e9957fb650365f7c36333b90a9e22beadde Gerrit-PatchSet: 3 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Don't require path tweak in Eclipse
by juan.hernandez＠redhat.com 23 Jan '13

23 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: webadmin, userportal: Don't require path tweak in Eclipse ...................................................................... webadmin, userportal: Don't require path tweak in Eclipse Currently we need to do some adjustments to the source paths after importing the projects in Eclipse in order to add the directories contained generated source. This patch uses the build helper maven plugin to add those directories, so that Eclipse will import the projects without the need to manually tweak the paths. We also need to avoid copying and filtering all the resources to the generated resources directory, as this generates a validate-build loop in eclipse. We can copy and filter only the .gwt.xml files, as this is what we really need. Change-Id: Ic48b86f266e287d95872c4048e1d0f6e4f58dd8f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml 4 files changed, 50 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic48b86f266e287d95872c4048e1d0f6e4f58dd8f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Don't require path tweak in Eclipse
by juan.hernandez＠redhat.com 23 Jan '13

23 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Don't require path tweak in Eclipse ...................................................................... restapi: Don't require path tweak in Eclipse Currently we need to do some adjustments to the source paths after importing the projects in Eclipse in order to add the directories contained generated source. This patch uses the build helper maven plugin to add those directories, so that Eclipse will import the projects without the need to manually tweak the paths. Change-Id: Ia55175c60cbef554165e3bae5ffff47d36eb3a18 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/pom.xml 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia55175c60cbef554165e3bae5ffff47d36eb3a18 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: avoid pk violation during import vm
by mlipchuk＠redhat.com 23 Jan '13

23 Jan '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: avoid pk violation during import vm ...................................................................... core: avoid pk violation during import vm When importing a vm (not as a new entity) while having a disk with the same id, pk violation occurs - this patch adds a validation to prevent it from happening. Bug-Url: https://bugzilla.redhat.com/902040 related to Bug-Url: https://bugzilla.redhat.com/890922 Change-Id: I84afa8167357b96ce47bc1340a64561a6d232b2d Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 70 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/11332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84afa8167357b96ce47bc1340a64561a6d232b2d Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: MoveOrCopyImageGroup - fixes and changes to revertTask...
by mlipchuk＠redhat.com 23 Jan '13

23 Jan '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: MoveOrCopyImageGroup - fixes and changes to revertTasks ...................................................................... core: MoveOrCopyImageGroup - fixes and changes to revertTasks currently the revertTasks method in MoveOrCopyImageGroupCommand issues a RemoveImage command in order to attempt to revert to operation. The issued RemoveImage command parameters are set with MoveOrCopyImageGroupCommand as the parent command. *Removes unneeded further execution of revertTasks method upon the completion of each RemoveImage. *In case of import vm failure, the disks will be removed during RemoveImage endSuccesfully method. *added execution of revert tasks in case of import vm. Change-Id: I0f767fcfa05d48ba085910dac7a1b746601381a9 Bug-Url: https://bugzilla.redhat.com/890922 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java 2 files changed, 17 insertions(+), 13 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/11329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f767fcfa05d48ba085910dac7a1b746601381a9 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RemoveImageParameters - added removeDuringExecution fl...
by mlipchuk＠redhat.com 23 Jan '13

23 Jan '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: RemoveImageParameters - added removeDuringExecution flag ...................................................................... core: RemoveImageParameters - added removeDuringExecution flag Added a flag indicating whether an image should be removed during the execute phase of the RemoveImage command or during the endSuccesfully method. Change-Id: I0ba734a97db220f913bdee88dbfeeba76981f5a3 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveImageParameters.java 3 files changed, 22 insertions(+), 10 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/11330 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ba734a97db220f913bdee88dbfeeba76981f5a3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: MoveOrCopyImageGroup - perform unlock when neccessary to avo...
by mlipchuk＠redhat.com 23 Jan '13

23 Jan '13

Maor Lipchuk has submitted this change and it was merged. Change subject: MoveOrCopyImageGroup - perform unlock when neccessary to avoid deadlock ...................................................................... MoveOrCopyImageGroup - perform unlock when neccessary to avoid deadlock When attempting to revert by executing RemoveImage, there's no need to unlock the image. Reasons: 1. It's going to be removed by RemoveImage. 2. The transaction isn't ended when calling RemoveImage, which attempts to update the same db record, causing to a deadlock. Change-Id: I3ea9bccb7e1a055613bb9a86d77e784e29f94bc5 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/11328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ea9bccb7e1a055613bb9a86d77e784e29f94bc5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: import vm -persist disks with correct storage domain
by mlipchuk＠redhat.com 23 Jan '13

23 Jan '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: import vm -persist disks with correct storage domain ...................................................................... core: import vm -persist disks with correct storage domain When importing vm, the added disks were persisted with the export domain as their storage domain rather then the target storage domain. note: the correct storage domain is set only for the saved disks and not to all of it's snapshots - if the operation is successful then the storage domain will be set to all snapshots from end method of MoveOrCopyImageGroup, otherwise the disk will be removed. Change-Id: I43280c97f2e444720044966eead7276999bdce1a Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43280c97f2e444720044966eead7276999bdce1a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0