January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Add index to network on storage_pool_id
by masayag＠redhat.com 24 Jan '13

24 Jan '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add index to network on storage_pool_id ...................................................................... engine: Add index to network on storage_pool_id The patch creates an index for network table for queries by storage-pool-id columns. Change-Id: I6b49d7fc1da196e192e0830a9197126bfd8431af Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_02_0360_add_secondary_index_to_network.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b49d7fc1da196e192e0830a9197126bfd8431af Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Do not log removal of option group
by ofrenkel＠redhat.com 24 Jan '13

24 Jan '13

Omer Frenkel has submitted this change and it was merged. Change subject: gluster: Do not log removal of option group ...................................................................... gluster: Do not log removal of option group The option "group" is a special case, where glusterfs internally replaces it with the options defined in corresponding group file. Hence, every time you set the option group, it eventually gets replaced with a set of options. For this reason, it is not appropriate to create an audit log when GlusterManager detects that the option "group" has been removed. Hence added a check to avoid the same. Change-Id: Ic1fc981563239ca2209c7172805d802a9691cce4 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java 2 files changed, 10 insertions(+), 4 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1fc981563239ca2209c7172805d802a9691cce4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Application Mode option in installer
by juan.hernandez＠redhat.com 24 Jan '13

24 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Application Mode option in installer ...................................................................... packaging: Application Mode option in installer Application Mode option added to engine-setup, Engine can be configured as gluster only, virtualization only or both. This new prompt can be disabled by setting USE_DEFAULT_APPLICATION_MODE_WITHOUT_PROMPT to True in basedef.py Also introduced a Constant(CONST_DEFAULT_APPLICATION_MODE) in basedef.py to set the default application mode. Now USE_DEFAULT option can be dynamic, so function name can be specified instead of value. Initially USE_DEFAULT contains True or False, now function name can be given instead of Boolean which helps to decide usage depending on the other questions answered. Modified NFS options override in plugins/all_in_one_100.py since those options can be managed by setting USE_DEFAULT dynamically. Change-Id: Ieba515d2baf3559bf27185c7c6432160551ef172 Signed-off-by: Aravinda VK <avishwan(a)redhat.com> --- M backend/manager/dbscripts/inst_sp.sql M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/output_messages.py M packaging/fedora/setup/plugins/all_in_one_100.py 6 files changed, 117 insertions(+), 13 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieba515d2baf3559bf27185c7c6432160551ef172 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Aravinda VK <avishwan(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com> Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Ronen Angluster <ranglust(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Duplicated keys removed from AppErrors.properties fi...
by sanjal＠redhat.com 24 Jan '13

24 Jan '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Duplicated keys removed from AppErrors.properties file. ...................................................................... engine: Duplicated keys removed from AppErrors.properties file. Change-Id: I4e5d86c5110ecbfb64f98b1ad70cb5d479139ec3 Signed-off-by: Selvasundaram <sesubram(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Shireesh Anjal: Looks good to me, approved Selvasundaram: Verified -- To view, visit http://gerrit.ovirt.org/11352 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e5d86c5110ecbfb64f98b1ad70cb5d479139ec3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: taskcleaner.sh utility outputs extra lines
by emesika＠redhat.com 23 Jan '13

23 Jan '13

Eli Mesika has submitted this change and it was merged. Change subject: core: taskcleaner.sh utility outputs extra lines ...................................................................... core: taskcleaner.sh utility outputs extra lines When using taskcleaner.sh utility to list task or zombie tasks, the utility outputs extra lines. The directories in the output are the result of pushd and popd using in the script to make it runnable from any place by its full name. When the utility returns no data, it is important that no redundant output is generated in order to track this correctly. Change-Id: I5bf28cfe2311449a0bdd68e132622ced57d4a868 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url:https://bugzilla.redhat.com/show_bug.cgi?id=903156 --- M backend/manager/dbscripts/taskcleaner.sh 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bf28cfe2311449a0bdd68e132622ced57d4a868 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: cleanup EngineMonitorService
by lhornyak＠redhat.com 23 Jan '13

23 Jan '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: cleanup EngineMonitorService ...................................................................... engine: cleanup EngineMonitorService A minor cleanup to simplify the logic in reportServerStatus Change-Id: I8632ab98590c4535efb89194020b5323b02756b5 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java 1 file changed, 27 insertions(+), 30 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8632ab98590c4535efb89194020b5323b02756b5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in otopi[master]: dialog: getpass: do not ignore signals
by Alon Bar-Lev 23 Jan '13

23 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: dialog: getpass: do not ignore signals ...................................................................... dialog: getpass: do not ignore signals Change-Id: I6965d3edfab1bb3a3658f6431f2145d68daeae99 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/dialog.py 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6965d3edfab1bb3a3658f6431f2145d68daeae99 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: dialog: do not log strings if hidden
by Alon Bar-Lev 23 Jan '13

23 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: dialog: do not log strings if hidden ...................................................................... dialog: do not log strings if hidden Change-Id: Ib62096fe045d82adb828ba6573af4156bd81375f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/dialog.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib62096fe045d82adb828ba6573af4156bd81375f Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: dialog: human: print missing new line in hidden mode
by Alon Bar-Lev 23 Jan '13

23 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: dialog: human: print missing new line in hidden mode ...................................................................... dialog: human: print missing new line in hidden mode Change-Id: I6c3230ac17c2a531ed1a2a5d71904f1a6fed200c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/dialog.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c3230ac17c2a531ed1a2a5d71904f1a6fed200c Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: core: dialog: queryString: replace mandatory with default
by Alon Bar-Lev 23 Jan '13

23 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: dialog: queryString: replace mandatory with default ...................................................................... core: dialog: queryString: replace mandatory with default Change-Id: I57219123dc33dafedd982b0c7edf2e3123752391 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/dialog.py M src/plugins/otopi/dialog/human.py M src/plugins/otopi/dialog/machine.py 3 files changed, 15 insertions(+), 8 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11346 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57219123dc33dafedd982b0c7edf2e3123752391 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0