February 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: Updated taskcleaner use in remote DB flows
by juan.hernandez＠redhat.com 25 Feb '13

25 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated taskcleaner use in remote DB flows ...................................................................... packaging: Updated taskcleaner use in remote DB flows Currently taskcleaner is executed as if it was running only on a locally installed DB. Added the correct parameters with values of host/port of the DB, so that in case of remote DB all the values will be sent correctly and the script will execute on a remote DB server. Additional items required to handle remote DB connections: * Added missing common.sh file to the taskcleaner packaging. * Updated deployment of the async tasks sql for the remote DB * Updated dbfunctions to use ${USERNAME} instead of 'postgres' user to allow remote connections work. Change-Id: Ie3c205962521bafe56ff67f3f46dd83202f48b7e Bug-Url: https://bugzilla.redhat.com/915028 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M Makefile M backend/manager/dbscripts/dbfunctions.sh M packaging/fedora/setup/engine-upgrade.py 3 files changed, 8 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3c205962521bafe56ff67f3f46dd83202f48b7e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: cleaning up dal's pom.xml
by amureini＠redhat.com 25 Feb '13

25 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: packaging: cleaning up dal's pom.xml ...................................................................... packaging: cleaning up dal's pom.xml Moved the test resource from 'resources' to 'testResources' section and removed the resource section. And this will also make sure log4j.xml not gets into dal.jar. If the log4j.xml included in the dal.jar, after the installation the log output is not going to engine.log and it always remains empty. Change-Id: Ibce1ba5034ef9d9043a7919c53d711f087105dc2 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/dal/pom.xml 1 file changed, 7 insertions(+), 17 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibce1ba5034ef9d9043a7919c53d711f087105dc2 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: removed the unused GenericResources.properties from da...
by amureini＠redhat.com 25 Feb '13

25 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: removed the unused GenericResources.properties from dal ...................................................................... core: removed the unused GenericResources.properties from dal Removed the GenericResources.properties file from the dal module. Change-Id: I8063075ae8b146b031654263d9cf696a37817568 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/GenericResources.properties 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8063075ae8b146b031654263d9cf696a37817568 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: add missing file
by gchaplik＠redhat.com 25 Feb '13

25 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: add missing file ...................................................................... engine: add missing file fix build break Change-Id: I0993dd074a3803721daa85dcc3d00e63dfd45f72 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MaintenanceNumberOfVdssParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MaintenanceVdsParameters.java 4 files changed, 634 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified Einav Cohen: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0993dd074a3803721daa85dcc3d00e63dfd45f72 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: fix typo
by gchaplik＠redhat.com 25 Feb '13

25 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: fix typo ...................................................................... engine: fix typo /s/Maintanance/Maintenance Change-Id: I91783d76663c1d423d1ab5ed51466c82894ca556 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintananceNumberOfVdssCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintananceVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MaintananceNumberOfVdssParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MaintananceVdsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetNonOperationalVdsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePoolStatus.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolDAOTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DataCenterMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DataCenterMapperTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/DcStatusColumn.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 40 files changed, 67 insertions(+), 703 deletions(-) Approvals: Gilad Chaplik: Verified Einav Cohen: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91783d76663c1d423d1ab5ed51466c82894ca556 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Limit selection of datacenters in new quota
by gchaplik＠redhat.com 25 Feb '13

25 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Limit selection of datacenters in new quota ...................................................................... webadmin: Limit selection of datacenters in new quota when creating new quota from the datacenter_quota subtab only the selected datacenter should be an option for the created quota and fixed a possible null pionter exception in a certain race conditions Change-Id: I81c6d13e6ddb704c85593d8ffec317e40a3d3a86 Bug-Url: https://bugzilla.redhat.com/911241 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterQuotaListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java 2 files changed, 48 insertions(+), 25 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81c6d13e6ddb704c85593d8ffec317e40a3d3a86 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix quota calculation for floating disks
by dfediuck＠redhat.com 25 Feb '13

25 Feb '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: Fix quota calculation for floating disks ...................................................................... core: Fix quota calculation for floating disks Disk which are not connected to a VM are not counted when calculating storage quota. The DB script was updated to include also disks which are not connected to a VM. Change-Id: I0da0a2535897076c4512384e65c0aea5ce28a0df Bug-Url: https://bugzilla.redhat.com/913408 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/dbscripts/create_functions.sql 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0da0a2535897076c4512384e65c0aea5ce28a0df Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix sql syntax for quota
by dfediuck＠redhat.com 25 Feb '13

25 Feb '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: Fix sql syntax for quota ...................................................................... core: Fix sql syntax for quota calculateAllVdsGroupUsage function was fixed to be compatible with lower postgres versions (verified on version 8.4.13) Change-Id: I9eed6757ac4a9ed891792929be902aa628d62f59 Bug-Url: https://bugzilla.redhat.com/905891 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/dbscripts/create_functions.sql 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9eed6757ac4a9ed891792929be902aa628d62f59 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Use context classloader from YAML
by mpastern＠redhat.com 25 Feb '13

25 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Use context classloader from YAML ...................................................................... restapi: Use context classloader from YAML The YAML library that we use to build load the RSDL metadata assumes that it can load classes using from its own class loader, and this is incorrect, specially now the the library is loaded from a JBoss module. The correct way to load classes is to use the context class loader, so it will work regardless of where in the application the classes are located. Change-Id: Ie86d591a0ce71b9984fa9c76ee42de67dce2ae4e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java M backend/manager/modules/restapi/webapp/pom.xml A backend/manager/modules/restapi/webapp/src/main/resources/META-INF/MANIFEST.MF 3 files changed, 13 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie86d591a0ce71b9984fa9c76ee42de67dce2ae4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fixing HibernateVm when one of the storage domain is...
by ofrenkel＠redhat.com 25 Feb '13

25 Feb '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Fixing HibernateVm when one of the storage domain is not active ...................................................................... engine: Fixing HibernateVm when one of the storage domain is not active The bug is simple we can choose storage domain which is not Active at getStorageDomainId. After that a wrong storgae domain id will be send during hibernate vm and operation will fail Change-Id: I3c381c54eaa3cc874c3c918b4a9da7bf6ef241f5 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c381c54eaa3cc874c3c918b4a9da7bf6ef241f5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0