February 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: storage tab - remove redundant name column
by derez＠redhat.com 24 Feb '13

24 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: storage tab - remove redundant name column ...................................................................... webadmin: storage tab - remove redundant name column Remove redundant Domain Name column from Storage main-tab. Change-Id: I09bdc4192877f4484feb0a21ac8e87a022469b1e Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12376 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09bdc4192877f4484feb0a21ac8e87a022469b1e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: fixed time missing in br45 (#910778)
by ydary＠redhat.com 24 Feb '13

24 Feb '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed time missing in br45 (#910778) ...................................................................... reports: fixed time missing in br45 (#910778) Bug-Url: https://bugzilla.redhat.com/910778 Change-Id: I653956a70b4d27997b543c8dff2fe98384ba0a06 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/Reports/users_usage/users_spice_sessions_activity_br45_files/users_spice_sessions_activity_br45_jrxml.data 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I653956a70b4d27997b543c8dff2fe98384ba0a06 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: fixed input controls entities selection (#910778)
by ydary＠redhat.com 24 Feb '13

24 Feb '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed input controls entities selection (#910778) ...................................................................... reports: fixed input controls entities selection (#910778) Bug-Url: https://bugzilla.redhat.com/910778 Change-Id: Id58c2286f2ca26ccf5cfdf72c033b73935cbe20b Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/cluster_ic/all_cluster_with_vms/P_Cluster_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/cluster_ic/all_clusters_with_hosts/P_Cluster_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/datacenter_ic/all_dcs_with_entities/P_DataCenter_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/datacenter_ic/all_dcs_with_hosts/P_DataCenter_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/datacenter_ic/all_dcs_with_storage/P_DataCenter_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/datacenter_ic/all_dcs_with_vms/P_DataCenter_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/host_ic/Hosts_List.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/host_ic/P_Host_Type.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/storage_ic/P_StorageDomain_ID.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/storage_ic/P_Storage_Type.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/vm_ic/P_VM_Type.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/single_select/vm_ic/VM_List.xml 12 files changed, 40 insertions(+), 240 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id58c2286f2ca26ccf5cfdf72c033b73935cbe20b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Move lock RunVmCommand -> RunVmCommandBase
by amureini＠redhat.com 24 Feb '13

24 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Move lock RunVmCommand -> RunVmCommandBase ...................................................................... core: Move lock RunVmCommand -> RunVmCommandBase Move RunVmCommand's exclusive lock up to its ancestor, RunVmCommandBase. RunVmCommand and all it's extending classes' locking will remain unchanged (as they inherit the lock from RunVmCommandBase), and the migration flows will also benefit from the lock. This is done in order to solve a race in virt/storage migration flows, like the bug mentioned below, and makes sense regardless - you can't start running a VM, e.g., if it's in the middle of migrating to another host. Change-Id: I8cbea4ae3a8bc47b4bbc451d8ecd3080287a3df0 Bug-Url: https://bugzilla.redhat.com/878131 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 2 files changed, 12 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cbea4ae3a8bc47b4bbc451d8ecd3080287a3df0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: prepare for the next development iteration
by mpastern＠redhat.com 24 Feb '13

24 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: prepare for the next development iteration ...................................................................... sdk: prepare for the next development iteration Change-Id: Ibe4419bb5b34d9654d4e0f1c5a7db2f04adeafd4 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe4419bb5b34d9654d4e0f1c5a7db2f04adeafd4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Clean "only in db" async tasks
by yzaslavs＠redhat.com 24 Feb '13

24 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Clean "only in db" async tasks ...................................................................... core: Clean "only in db" async tasks When system restarts, storagePoolUp event is sent per each SPM that becomes up. We query the SPM and get its tasks. If we had tasks in DB, that did not exist in SPM, we will remove them from DB. This is an alternative to previous versions of this patch, in which I introduced zombie treatment for these tasks. Change-Id: Ie13ae21eaadb1bb621a7fc8ad471e60387a3699b Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java 1 file changed, 35 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie13ae21eaadb1bb621a7fc8ad471e60387a3699b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: Add detailed note to user when password validation fails by ...
by yzaslavs＠redhat.com 24 Feb '13

24 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: Add detailed note to user when password validation fails by using engine-config ...................................................................... Add detailed note to user when password validation fails by using engine-config Change-Id: I7ae53d9b19f1b09990cf540d56e648698a00233d Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=893682 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java M backend/manager/tools/src/main/shell/engine-config.sh 2 files changed, 14 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ae53d9b19f1b09990cf540d56e648698a00233d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Stephen Gordon <sgordon(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: release 1.0.0.4-1
by mpastern＠redhat.com 24 Feb '13

24 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: release 1.0.0.4-1 ...................................................................... sdk: release 1.0.0.4-1 - implement SSL support (without host verification) - implement shutdown() to deallocate system resources - to cluster added tunnel_migration property - to DataCenter added Clusters sub-collection - to root collection resource Disk added Permissions sub-collectio - to root collection resource Disk added Statistic sub-collection - host can be attached to cluster now either by id or name - to StorageDomainTemplate added Disks sub-collection - to StorageDomainVM added Disks sub-collection - to template.display added keyboard_layout property - to template added tunnel_migration property - to vm.display added keyboard_layout property - to vm added tunnel_migration property - to VMSnapshot added preview method - to VMSnapshot added undo method - to VMSnapshot added commit method Change-Id: Id12cc90a93922d55bc28c627a65c87898e66bbc1 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12371 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id12cc90a93922d55bc28c627a65c87898e66bbc1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add details to general Cluster sub-tab
by alkaplan＠redhat.com 24 Feb '13

24 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Add details to general Cluster sub-tab ...................................................................... webadmin: Add details to general Cluster sub-tab Added some information about the selected Cluster to sub-tab 'General' under the main-tab Cluster. Change-Id: I9933cd4ec03a3df35dc4ff8fa157854b776a632c Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormItemWithDefaultValue.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/GeneralFormPanel.ui.xml A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/ClusterTypeLabel.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/ResiliencePolicyLabel.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/ClusterTypeRenderer.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.ui.xml 11 files changed, 434 insertions(+), 91 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9933cd4ec03a3df35dc4ff8fa157854b776a632c Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: GetDiskByDiskId query support for user-level API
by oourfali＠redhat.com 24 Feb '13

24 Feb '13

Oved Ourfali has submitted this change and it was merged. Change subject: GetDiskByDiskId query support for user-level API ...................................................................... GetDiskByDiskId query support for user-level API This patch adds support for the GetDiskByDiskId query for the user-level API. Change-Id: I83c873f3f427c10d8d9b56279c7b0a46299db287 Bug-Url: https://bugzilla.redhat.com/910092 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/dbscripts/all_disks_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskByDiskIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java 6 files changed, 72 insertions(+), 22 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83c873f3f427c10d8d9b56279c7b0a46299db287 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0