February 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: tools: Added SpiceProxyDefault property to vdc_options
by tjelinek＠redhat.com 25 Feb '13

25 Feb '13

Tomas Jelinek has submitted this change and it was merged. Change subject: tools: Added SpiceProxyDefault property to vdc_options ...................................................................... tools: Added SpiceProxyDefault property to vdc_options The value of SpiceProxyDefault is in form of [protocol://]<host>[:port] and will be used in FE to fill into the spice client Change-Id: Ie5521021fc6d826e8f70706e4eb7e971339e8e56 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/tools/src/main/conf/engine-config.properties 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5521021fc6d826e8f70706e4eb7e971339e8e56 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: set up Proxy property to SPICE
by tjelinek＠redhat.com 25 Feb '13

25 Feb '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin,userportal: set up Proxy property to SPICE ...................................................................... webadmin,userportal: set up Proxy property to SPICE This patch reads the SpiceProxyDefault property from vdc_options and sets it to the Proxy property of SPICE client(both cab and xpi). If the SpiceProxy is not set then nothing is set to the client. Change-Id: If269869413eae577fb243bffe849548f90ff8f4a Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceInterfaceImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpice.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 3 files changed, 30 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If269869413eae577fb243bffe849548f90ff8f4a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : ImportVm with snapshots without collapse - not all di...
by amureini＠redhat.com 25 Feb '13

25 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core : ImportVm with snapshots without collapse - not all disks are copied ...................................................................... core : ImportVm with snapshots without collapse - not all disks are copied When importing a vmlists of disk ids and image ids are being populated in order to be used when creating the parameters for MoveOrCopyImageGroupCommand. When vm has snapshots, vm.getImages() returnes the DiskImage instances of all the disks snapshots as well - that caused that when importing the vm that has snapshots without collapse, same disk id was added few times to the disk's id list. When creating the tasks for copying the disks, the iteration is according to the disk count, meaning that possibly we will execute copy of the same image group while other image groups won't be copied at all - which will cause that the imported vm will have only some of it's disks. the proposed fix adds only the disk id\image of the leaf disk, so duplicate id's won't be added. Change-Id: Ib850d2d22ea6acb37320ad2b1bd6c571e1048faa Bug-Url: https://bugzilla.redhat.com/912697 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib850d2d22ea6acb37320ad2b1bd6c571e1048faa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated 'nfs exports' step alignment in cleanup
by juan.hernandez＠redhat.com 25 Feb '13

25 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated 'nfs exports' step alignment in cleanup ...................................................................... packaging: Updated 'nfs exports' step alignment in cleanup Change-Id: I06d36c964a6b8125982ce85328c52f603c227245 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-cleanup.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06d36c964a6b8125982ce85328c52f603c227245 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: changed psql execution environment
by juan.hernandez＠redhat.com 25 Feb '13

25 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: changed psql execution environment ...................................................................... packaging: changed psql execution environment Added LC_ALL=C in the environment provided by getPgPassEnv used whenever psql is called. Renamed getPgPassEnv to getPgEnv and added the documentation. Change-Id: I24869748184d9397192461fa01da632a558208f7 Bug-Url: https://bugzilla.redhat.com/912426 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-cleanup.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine-upgrade.py 4 files changed, 19 insertions(+), 16 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24869748184d9397192461fa01da632a558208f7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Don't resolve plugins
by juan.hernandez＠redhat.com 25 Feb '13

25 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Don't resolve plugins ...................................................................... packaging: Don't resolve plugins Now that we have a plugin in the project that is required for the build (the jboss modules plugin) this will always fail in the first build. Change-Id: I9667a5d3dc416cd46ff8fb5b08f74baddab86d50 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9667a5d3dc416cd46ff8fb5b08f74baddab86d50 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix broken bll unit test
by amureini＠redhat.com 25 Feb '13

25 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix broken bll unit test ...................................................................... core: Fix broken bll unit test An error was introduced due to usage of AsyncTaskDao.getAll in the CTOR of the AsyncTaskManager sinleton The following patch uses mocking to create mocked data source + mocked db facade to handle the error. Change-Id: If70f5da87e1238f0a545496d6e9700151275d642 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeLocator.java 2 files changed, 27 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If70f5da87e1238f0a545496d6e9700151275d642 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removal of @override annotation
by amureini＠redhat.com 25 Feb '13

25 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removal of @override annotation ...................................................................... core: Removal of @override annotation This removes an @override annotation which breaks compatbility with open jdk6. Change-Id: I486b521252abcca77fea54fe6dd0dbc1f72590c2 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I486b521252abcca77fea54fe6dd0dbc1f72590c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: tool-tip for DirectLUN disk column
by derez＠redhat.com 24 Feb '13

24 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: tool-tip for DirectLUN disk column ...................................................................... webadmin: tool-tip for DirectLUN disk column Added a tool-tip for DirectLUN disk column (for each item). Affected tabs: Disks main-tab and VM -> Disks sub-tab ('All' view). Change-Id: I939fb57ca024baba86090b9b1840b62a1425dc66 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I939fb57ca024baba86090b9b1840b62a1425dc66 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Storage tabs - move description column
by derez＠redhat.com 24 Feb '13

24 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Storage tabs - move description column ...................................................................... webadmin: Storage tabs - move description column For keeping the convention on other tabs: * move description column to the right. * rename 'Domain Description' to 'Description'. Change-Id: Idbdac003253f15f8806c465980b29f059e5d09b4 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskStorageView.java 4 files changed, 30 insertions(+), 30 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12377 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbdac003253f15f8806c465980b29f059e5d09b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0