February 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix modifiers in VmGuestAgentInterfaceDao
by amureini＠redhat.com 12 Feb '13

12 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix modifiers in VmGuestAgentInterfaceDao ...................................................................... core: Fix modifiers in VmGuestAgentInterfaceDao Added missing implied final and static modifiers and @Override annotations in VmGuestAgentInterfaceDaoDbFacadeImpl, to resolve the MS_SHOULD_BE_FINAL issue detected by FindBugs. Change-Id: I3b28efa59756f3f022271b8d8e352ceb3c91887d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmGuestAgentInterfaceDaoDbFacadeImpl.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b28efa59756f3f022271b8d8e352ceb3c91887d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove default audit logging
by amureini＠redhat.com 12 Feb '13

12 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove default audit logging ...................................................................... core: Remove default audit logging Removed the notion of default logging from AuditLogDirector and AuditLogableBase, as it literally did nothing. Change-Id: I00e2059f6793dcaaf909f28ab2428e04b9bf0281 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 2 files changed, 0 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00e2059f6793dcaaf909f28ab2428e04b9bf0281 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Move saveIsInitialized to VmDao
by amureini＠redhat.com 12 Feb '13

12 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Move saveIsInitialized to VmDao ...................................................................... core: Move saveIsInitialized to VmDao Moved saveIsInitialized(vmId, isInitialized) from DbFacade to VmDao, where it belongs. Change-Id: Id4cea34ec7306b64f99c9a46a78d11083a91eb20 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java 6 files changed, 46 insertions(+), 41 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4cea34ec7306b64f99c9a46a78d11083a91eb20 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Singleton row mapper for Bookmarks
by amureini＠redhat.com 12 Feb '13

12 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Singleton row mapper for Bookmarks ...................................................................... core: Singleton row mapper for Bookmarks Added a singleton row mapper for BookmarkDAO, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: I3eccfb32acd4c2e335a385b9440e22c118ec68d5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BookmarkDAODbFacadeImpl.java 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3eccfb32acd4c2e335a385b9440e22c118ec68d5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: MapEntry iterator in PostgresDbEngineDialect
by amureini＠redhat.com 12 Feb '13

12 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: MapEntry iterator in PostgresDbEngineDialect ...................................................................... core: MapEntry iterator in PostgresDbEngineDialect Iterated over the entries in extractOutputParameters(CallableStatement,List) instead of the keySet for better performance. Note that this addressed the FindBugs issue of WMI_WRONG_MAP_ITERATOR for this class. Change-Id: I42c320fd77c485b787e94899c4944c39d6fddec8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/PostgresDbEngineDialect.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42c320fd77c485b787e94899c4944c39d6fddec8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Singleton row mapper for Tags
by amureini＠redhat.com 12 Feb '13

12 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Singleton row mapper for Tags ...................................................................... core: Singleton row mapper for Tags Added a singleton row mapper for TagDAO, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: I016cee1e6e219924b11e6a3cfe33efd8bc5202a3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAODbFacadeImpl.java 1 file changed, 18 insertions(+), 18 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I016cee1e6e219924b11e6a3cfe33efd8bc5202a3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: notifier - add aditional validation
by dfediuck＠redhat.com 12 Feb '13

12 Feb '13

Doron Fediuck has submitted this change and it was merged. Change subject: tools: notifier - add aditional validation ...................................................................... tools: notifier - add aditional validation Check for valid email (simple @ validation) Check for valid port number (1-65536) Check for true or false in HTML_MESSAGE_FORMAT Change-Id: Id97cb5bd1903991717e653cf2ca4ca16f362f8e6 Bug-Url: https://bugzilla.redhat.com/883417 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/tools/src/main/shell/engine-notifier.sh 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Noam Slomianko: Verified -- To view, visit http://gerrit.ovirt.org/11549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id97cb5bd1903991717e653cf2ca4ca16f362f8e6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: notifier - add validation to mail type properties
by dfediuck＠redhat.com 12 Feb '13

12 Feb '13

Doron Fediuck has submitted this change and it was merged. Change subject: tools: notifier - add validation to mail type properties ...................................................................... tools: notifier - add validation to mail type properties Creating smtp requests with FROM/USER properties set to values not in the format user@domain will fail, so we now enforce it the the bash script *?@?* means that there must be a @ with at least one char on each side Change-Id: I652d6b7aa9ca34192d6892174bf57b11335cb98a Bug-Url: https://bugzilla.redhat.com/885436 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/tools/src/main/shell/engine-notifier.sh 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I652d6b7aa9ca34192d6892174bf57b11335cb98a Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: engine-notifier accept special chars
by dfediuck＠redhat.com 12 Feb '13

12 Feb '13

Doron Fediuck has submitted this change and it was merged. Change subject: tools: engine-notifier accept special chars ...................................................................... tools: engine-notifier accept special chars Due to the way configuration was loaded in the bash script special characters would create some unwanted behaviors. Now the configuration file is read and the variables are added using "declare" statement It is expected that the config file is of the form key=value Change-Id: I5e6419a225bd02edaf1db38a2025dee74761ddf2 Bug-Url: https://bugzilla.redhat.com/883301 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/tools/src/main/shell/engine-notifier.sh 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10704 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e6419a225bd02edaf1db38a2025dee74761ddf2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix problem with changing host cluster
by tnisan＠redhat.com 12 Feb '13

12 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix problem with changing host cluster ...................................................................... core: Fix problem with changing host cluster The VDS entity vds_group_id property was changed to vdsGroupId, in the canDo action of ChangeVDSCluster the field change validation was hard coded to the old property name thus failing on host cluster change even if the host is in maintenance state, changed the check to use the new field name Change-Id: Ia5789c931e69bc2ed5f7840d8503dcf843a102ed Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5789c931e69bc2ed5f7840d8503dcf843a102ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0