February 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Change storage dialog styles to fit to size with F...
by derez＠redhat.com 12 Feb '13

12 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Change storage dialog styles to fit to size with French local ...................................................................... webadmin: Change storage dialog styles to fit to size with French local When using webadmin localized to French the storage dialog exceeded it's size and an inner scroll bar appeared, styles were adjusted to make the elements fit the size in French locale Change-Id: Ia4b77224d4a9a4ab9f3da8428dbf743da48b53ac Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4b77224d4a9a4ab9f3da8428dbf743da48b53ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Add task cleaner utility to ovirt-engine-setup rp...
by juan.hernandez＠redhat.com 12 Feb '13

12 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Add task cleaner utility to ovirt-engine-setup rpm ...................................................................... packaging: Add task cleaner utility to ovirt-engine-setup rpm Add the task cleaner utility to ovirt-engine-setup rpm. In this way, the utility will always be avaialble for engine-upgrade. Change-Id: I854768c529965043bebee4a3c2e43dc674418216 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M Makefile M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-upgrade.py M packaging/fedora/spec/ovirt-engine.spec.in 4 files changed, 11 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I854768c529965043bebee4a3c2e43dc674418216 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : Non admin user have access to /hosts url (#909692)
by yzaslavs＠redhat.com 12 Feb '13

12 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: restapi : Non admin user have access to /hosts url (#909692) ...................................................................... restapi : Non admin user have access to /hosts url (#909692) Non admin users should not be able to see hosts using /api/hosts Change-Id: I496a9560d462156944c3aa23b61d2b6d587d1700 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=909692 Signed-off-by: Ravi Nori <rnori(a)redhat.com> Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsByVdsIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVdsByVdsIdQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java 4 files changed, 6 insertions(+), 10 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I496a9560d462156944c3aa23b61d2b6d587d1700 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Disable revomal of plugged vnic on a running vm
by alkaplan＠redhat.com 12 Feb '13

12 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Disable revomal of plugged vnic on a running vm ...................................................................... webadmin: Disable revomal of plugged vnic on a running vm On Networks->Virtual Machines the remove action should be disabled if the vm is running and the vnic is plugged. Also, it should be disabled in all the vm states that are not UP or DOWN. Virtual Machines->Network interfaces already works correctly. Also a little code fix- there is no need to check the HotPlugEnabled property when deciding if the user can remove the vnic. It is enough to make sure the vnic is unplugged. If HotPlug is not enabled the vnic is always plugged. Change-Id: I795096615e8ef5118cceb56155aa6806af736ebb Bug-Url: https://bugzilla.redhat.com/910021 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java 2 files changed, 14 insertions(+), 15 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I795096615e8ef5118cceb56155aa6806af736ebb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fix message in importing VM dialog
by alkaplan＠redhat.com 12 Feb '13

12 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: fix message in importing VM dialog ...................................................................... webadmin: fix message in importing VM dialog This patch modify the message presented in the dialog that is being shown when importing VM, such that it won't say that the import status is shown in the events tab of the specific destination storage domain, as it's not true and it's not trivial to implement because there can be multiple destination storage domains (can be different for each disk) Change-Id: I5f000933abd0802bb6cbc715cffd30d9fde42e41 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f000933abd0802bb6cbc715cffd30d9fde42e41 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fix message in importing template dialog
by alkaplan＠redhat.com 12 Feb '13

12 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: fix message in importing template dialog ...................................................................... webadmin: fix message in importing template dialog This patch modify the message presented in the dialog that is being shown when importing template, such that it won't say that the import status is shown in the events tab of the specific destination storage domain, as it's not true and it's not trivial to implement because there can be multiple destination storage domains (can be different for each disk) Change-Id: I6565428cb6235f2423f155b39e5634c7e5faf28a Bug-Url: https://bugzilla.redhat.com/886436 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6565428cb6235f2423f155b39e5634c7e5faf28a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Logging configuration for dal tests
by amureini＠redhat.com 12 Feb '13

12 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Logging configuration for dal tests ...................................................................... core: Logging configuration for dal tests A simple initial log4j configuration file for the dal tests. This configuration solves most of the "noise" that's printed to the screen during these tests. Change-Id: I1862bd1aa4a936fceaf79f5419e8b4ae079cd601 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- A backend/manager/modules/dal/src/test/resources/log4j.xml 1 file changed, 79 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1862bd1aa4a936fceaf79f5419e8b4ae079cd601 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: 'No No Alerts' shown in 0 alerts + cleanup
by gchaplik＠redhat.com 12 Feb '13

12 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: 'No No Alerts' shown in 0 alerts + cleanup ...................................................................... webadmin: 'No No Alerts' shown in 0 alerts + cleanup AlertListModel updates wrongfully its title. did a little bit of clean-up, since the fix there is no longer need for some of the items, and the rest items are very old. Change-Id: I0b4b4502e949343c10ae3cc3abef337b4c8378df Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/AlertListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 3 files changed, 6 insertions(+), 217 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b4b4502e949343c10ae3cc3abef337b4c8378df Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix build break in VdsStaticDAODbFacadeImpl
by gchaplik＠redhat.com 12 Feb '13

12 Feb '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix build break in VdsStaticDAODbFacadeImpl ...................................................................... core: Fix build break in VdsStaticDAODbFacadeImpl Patch I56a7b0d3237029e91e7b0cb4bbff18b64e729d9e introduced a call to a wrong field (wrong capatilization in the property name). This patch fixes the build break. Change-Id: Ice2de210d62fb3474133cb45fed75aa22e6ea53c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/11970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice2de210d62fb3474133cb45fed75aa22e6ea53c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fix typo in ExistingPoolNameLengthValidationTest
by derez＠redhat.com 12 Feb '13

12 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: fix typo in ExistingPoolNameLengthValidationTest ...................................................................... webadmin: fix typo in ExistingPoolNameLengthValidationTest The method getPoolName_noVmsAlloved was renamed to getPoolName_noVmsAllowed Change-Id: Ie693aadb492502966dcfcaedbba29388b5978994 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/ExistingPoolNameLengthValidationTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie693aadb492502966dcfcaedbba29388b5978994 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0