February 2013 - Engine-commits - oVirt List Archives

Change in samples-uiplugins[master]: Shell-In-A-Box plugin: refactoring and renaming
by derez＠redhat.com 12 Feb '13

12 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: Shell-In-A-Box plugin: refactoring and renaming ...................................................................... Shell-In-A-Box plugin: refactoring and renaming * Using 'hostname' property instead of 'name'. * Refactoring 'getShellInABoxUrl' method signature to get the selected host. * Renaming all occurrences of 'Shell Box' to 'Shell In A Box'. * Removing 'isAccessible' method. Change-Id: Id24155f0480e0af5497c2b74eee203dfdf60e3f8 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- D shellbox-plugin/shellbox-files/start.html D shellbox-plugin/shellbox.json R shellinabox-plugin/README A shellinabox-plugin/shellinabox-files/start.html A shellinabox-plugin/shellinabox.json 5 files changed, 53 insertions(+), 57 deletions(-) Approvals: Daniel Erez: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id24155f0480e0af5497c2b74eee203dfdf60e3f8 Gerrit-PatchSet: 1 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: UI-Plugins - VM IP address mapping
by derez＠redhat.com 12 Feb '13

12 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: UI-Plugins - VM IP address mapping ...................................................................... webadmin: UI-Plugins - VM IP address mapping Add mapping to VM IP address, EntityObject: Map 'getVmIp' to 'ipaddress' property (IP Address column). Change-Id: I24b1208031d454d1774a43ddb0cccd7a85f23d2e Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/entity/EntityObject.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24b1208031d454d1774a43ddb0cccd7a85f23d2e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: UI-Plugins - fix host name mapping
by derez＠redhat.com 12 Feb '13

12 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: UI-Plugins - fix host name mapping ...................................................................... webadmin: UI-Plugins - fix host name mapping EntityObject: * Map 'getvds_name' to 'name' property (Name column). * Map 'gethost_name' to 'hostname' property (Hostname/IP column). Change-Id: Id947436ccdf2a5654ca6852f6e57af143dad8b21 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/entity/EntityObject.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11420 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id947436ccdf2a5654ca6852f6e57af143dad8b21 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : version values for hosts are wrong for libvirt
by yzaslavs＠redhat.com 12 Feb '13

12 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: restapi : version values for hosts are wrong for libvirt ...................................................................... restapi : version values for hosts are wrong for libvirt When a new host is added to engine and the status is either installing for rebooting the libvirt version is unknown and is reported as -1. This patch supresses the libvirt version from /api/hosts if the version is unknown. Change-Id: I0c0525b6bb8c90d2ce4e10ac4f5c26f1a1b1e6b0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=904935 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c0525b6bb8c90d2ce4e10ac4f5c26f1a1b1e6b0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:[Power Management]: Unable to edit power...
by emesika＠redhat.com 12 Feb '13

12 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: core:[Power Management]: Unable to edit power... ...................................................................... core:[Power Management]: Unable to edit power... [Power Management]: Unable to edit power management fields, engine mistakenly thinks that host is operational. Fixing a typo in the vmSatatic getPmSEcondaryUser name (was getPmSEcondaryuser) This typo caused the validation to fail when the PM secondary User field was changed. Change-Id: If4b1bc4f84bab665e045505d7e31e983db4b7bc6 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=908351 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 5 files changed, 7 insertions(+), 7 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4b1bc4f84bab665e045505d7e31e983db4b7bc6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: updated branded theme
by ydary＠redhat.com 12 Feb '13

12 Feb '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: updated branded theme ...................................................................... reports: updated branded theme Change-Id: Ib028ad8720d9f6ce913166d37d7bb42ec6301069 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/.folder.xml D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/buttons.css.data D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/buttons.css.xml D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/containers.css.data D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/containers.css.xml D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/controls.css.data D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/controls.css.xml D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/dataDisplays.css.data D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/dataDisplays.css.xml D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/dialogSpecific.css.data D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/dialogSpecific.css.xml D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/forPrint.css.data D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/forPrint.css.xml M reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/.folder.xml D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/Thumbs.db.data D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/Thumbs.db.xml A reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/banner_bkgd.png.data A reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/banner_bkgd.png.xml M reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/body_bkgnd.png.xml M reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/button_action_jumbo_primary_sprite.png.xml M reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/button_action_jumbo_sprite.png.xml M reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/button_action_primary_sprite.png.xml M reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/button_capsule_sprite.png.xml A reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/logo.png.data A reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/logo.png.xml D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/logo_ovirt.png.data D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/logo_ovirt.png.xml M reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/menu_primaryNav_sprite.png.data M reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/menu_primaryNav_sprite.png.xml M reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/panel_confirm_bkgd.png.xml M reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/tabs_horizontal_sprite.png.xml M reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/tabs_vertical_sprite.png.xml D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/lists.css.data D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/lists.css.xml M reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/overrides_custom.css.data M reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/overrides_custom.css.xml D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/overrides_ie.css.data D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/overrides_ie.css.xml D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/overrides_ie7.css.data D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/overrides_ie7.css.xml D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/overrides_ie8.css.data D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/overrides_ie8.css.xml D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/pageSpecific.css.data D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/pageSpecific.css.xml D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/pages.css.data D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/pages.css.xml D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/samples.css.data D reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/samples.css.xml 48 files changed, 165 insertions(+), 15,583 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib028ad8720d9f6ce913166d37d7bb42ec6301069 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add vm from snapshot revert flow
by tnisan＠redhat.com 12 Feb '13

12 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: add vm from snapshot revert flow ...................................................................... core: add vm from snapshot revert flow The behaviour was changed when applying the revert flow to import vm template command, there are few issues in that flow (some related and some are not) - i'm currently applying the previous behaviour and will reapply that change after all issues are solved - there's gonna be a whole design change in that area, so meanwhile just applying the previous logic. Change-Id: Icdaed44a09f712fa0a6a4c1f5b5890f0c9c4f7a9 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icdaed44a09f712fa0a6a4c1f5b5890f0c9c4f7a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: codegen: refactor rsdl/xsd codegen
by mpastern＠redhat.com 12 Feb '13

12 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: refactor rsdl/xsd codegen ...................................................................... codegen: refactor rsdl/xsd codegen Change-Id: I6a885eab0cefc58d9e8385d6a863c98bff2fd6a0 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- A src/codegen/common/__init__.py A src/codegen/common/icodegen.py M src/codegen/main.py A src/codegen/rsdl/__init__.py A src/codegen/rsdl/abstractrsdlcodegen.py A src/codegen/rsdl/rsdlcodegen.py A src/codegen/utils/fileutils.py A src/codegen/utils/stringutils.py M src/codegen/utils/typeutil.py A src/codegen/xsd/__init__.py A src/codegen/xsd/abstractxsdcodegen.py A src/codegen/xsd/xsdcodegen.py M src/ovirtsdk/infrastructure/proxy.py 13 files changed, 983 insertions(+), 413 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11962 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a885eab0cefc58d9e8385d6a863c98bff2fd6a0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: codegen: cleanup
by mpastern＠redhat.com 12 Feb '13

12 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: cleanup ...................................................................... codegen: cleanup Change-Id: I1d10588d325ad3b0249988a1252dbf529267b527 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/main.py 1 file changed, 87 insertions(+), 118 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d10588d325ad3b0249988a1252dbf529267b527 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: regenerate against latest api
by mpastern＠redhat.com 12 Feb '13

12 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: regenerate against latest api ...................................................................... sdk: regenerate against latest api - added [@param host.display.address: string] - added [@param action.ticket.value: string] Change-Id: I45af7e01104f5fd3adf7538604078da1b98eb3fb Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 2 files changed, 39 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45af7e01104f5fd3adf7538604078da1b98eb3fb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0