April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[engine_3.2]: packaging: ovirt-engine-3.2.2
by oschreib＠redhat.com 01 May '13

01 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: ovirt-engine-3.2.2 ...................................................................... packaging: ovirt-engine-3.2.2 updated version to 3.2.2 Change-Id: I56b6ef52d905a5914786ef1f7d9bd287d58d2288 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56b6ef52d905a5914786ef1f7d9bd287d58d2288 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: fix environment for java
by oschreib＠redhat.com 30 Apr '13

30 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-service: fix environment for java ...................................................................... packaging: engine-service: fix environment for java python dict.update() returns None. Change-Id: I781557e81db3417e80c144c6b05315f6011f2e31 Reported-By: Limor Gavish <lgavish(a)gmail.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14314 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I781557e81db3417e80c144c6b05315f6011f2e31 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "engine: Use isBlockDomain() where possible"
by amureini＠redhat.com 30 Apr '13

30 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: Revert "engine: Use isBlockDomain() where possible" ...................................................................... Revert "engine: Use isBlockDomain() where possible" This is a partial revert of the rest parts of commit f4eaef896d8927f968023c01e36db173c3deb73d It was commit without the proper review, and should never have been merged. Change-Id: I181986b7ead007e0193d48253261132554a7f69b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java 2 files changed, 18 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I181986b7ead007e0193d48253261132554a7f69b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove StoragePoolIsoMapDAO.update impl
by amureini＠redhat.com 30 Apr '13

30 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove StoragePoolIsoMapDAO.update impl ...................................................................... core: Remove StoragePoolIsoMapDAO.update impl Since the owner column was removed from StoragePoolIsoMap in the previous patch, it's only (database) mutable column is the status column. In other words, there is no difference between the update and updateStatus methods. This patch removes the Updatestorage_pool_iso_map stored procedure and replaces the implementation of the update method with a delegation to updateStatus. Change-Id: Ia661353ed7b100795d90c9390866c955a1a6290d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/storages_san_sp.sql M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDAODbFacadeImpl.java 2 files changed, 1 insertion(+), 23 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia661353ed7b100795d90c9390866c955a1a6290d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove StorageDomainOwnerType
by amureini＠redhat.com 30 Apr '13

30 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove StorageDomainOwnerType ...................................................................... core: Remove StorageDomainOwnerType The StorageDomainOwnerType enum contains only one value ("Unknown"), and as such, is pretty useless and can be removed. This patch removes it and all its references. Change-Id: Iae13123bc33c2fdff2d7dd5e128c1a5cee7d262f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/storages_san_sp.sql A backend/manager/dbscripts/upgrade/03_03_0110_drop_storage_owner.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainOwnerType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePoolIsoMap.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ObjectStreamDeserializerTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ObjectStreamSerializerTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 11 files changed, 11 insertions(+), 71 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae13123bc33c2fdff2d7dd5e128c1a5cee7d262f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed ImportCandidateTypeEnum
by amureini＠redhat.com 30 Apr '13

30 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed ImportCandidateTypeEnum ...................................................................... core: Removed ImportCandidateTypeEnum The aforementioned enum is not used anywhere in the codebase, and should thus be removed. Change-Id: Ic547d2356e310324fa53b49122786bfe3f769ab4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ImportCandidateTypeEnum.java 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic547d2356e310324fa53b49122786bfe3f769ab4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core, webadmin: Remove TabType
by amureini＠redhat.com 30 Apr '13

30 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core, webadmin: Remove TabType ...................................................................... core, webadmin: Remove TabType The TabType enum is not used anywhere in the codebase, and thus should be removed. This patch removes it and any localization references to it. Change-Id: I2e17e4e533439d9038654213d2f5375c16b24f0a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TabType.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 3 files changed, 0 insertions(+), 63 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e17e4e533439d9038654213d2f5375c16b24f0a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Clean up Common.gwt.xml
by amureini＠redhat.com 30 Apr '13

30 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Clean up Common.gwt.xml ...................................................................... webadmin: Clean up Common.gwt.xml Cleaned up Common.gwt.xml from numerous entries in order to make the file more maintainable and speed up the build a tad. The following entries were removed: 1. Classes that no longer exist in the code base (e.g., time_lease_vm_pool_map). 2. Classes that are not used by the frontend (e.g., LUN_storage_server_connection_map). 3. Double entries (e.g., UsbPolicy). 4. Specific entries that can be inferred from more general entries (e.g., common/action/VdcActionType.java does not need to be specified since common/action/* already is). Change-Id: Idebce672b96192f7b114fc1596ba462fe097d9b8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 1 file changed, 2 insertions(+), 60 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idebce672b96192f7b114fc1596ba462fe097d9b8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: Redundant nullcheck
by shavivi＠redhat.com 30 Apr '13

30 Apr '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Redundant nullcheck ...................................................................... findbugs: Redundant nullcheck Change-Id: Id991b677df2d447b8124de5ae8a1f1a52aca98e5 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id991b677df2d447b8124de5ae8a1f1a52aca98e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi:Correct rsdl for add bricks
by mpastern＠redhat.com 30 Apr '13

30 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi:Correct rsdl for add bricks ...................................................................... restapi:Correct rsdl for add bricks Add bricks command causes an exception in cli when passed a collection of bricks. Changed the rsdl to brick--COLLECTION as per Michael's suggestion Change-Id: I2a229faa90c8fcded33b53ab8801c4cb03094798 Bug-Url: https://bugzilla.redhat.com/923169 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 15 insertions(+), 16 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a229faa90c8fcded33b53ab8801c4cb03094798 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>

1 0