April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Fix gluster host force detach message
by gchaplik＠redhat.com 02 Apr '13

02 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix gluster host force detach message ...................................................................... webadmin: Fix gluster host force detach message The message is changed to 'Force Detach' to be inline with force remove message. Change-Id: I05508feb015f92d85dc5a55cf0ffb57a5e6ac4ca Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05508feb015f92d85dc5a55cf0ffb57a5e6ac4ca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix for wrong error massage in add disk
by gchaplik＠redhat.com 02 Apr '13

02 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix for wrong error massage in add disk ...................................................................... core: Fix for wrong error massage in add disk while quota in audit mode, when user tried to add a disk to an SD which has no assigned quota - an error message was presented and the operation was blocked. The error message was not correctly formatted. This happens because when the DC was moved from Enforced to Audit mode the quota cache was not refreshed. So all quotas on that DC remained in the old enforcement mode. Fixed the cache refresh rule. Now that the error is thrown from the correct place in the code and only in Enforced mode, it is correctly formatted. Change-Id: Ifb23898a52c654dd03b7c9d1421fe456c9196da2 Bug-Url: https://bugzilla.redhat.com/906485 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java 2 files changed, 4 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb23898a52c654dd03b7c9d1421fe456c9196da2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: noam slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Application continue polling after logout
by ecohen＠redhat.com 01 Apr '13

01 Apr '13

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: Application continue polling after logout ...................................................................... webadmin: Application continue polling after logout - Fixed queries to BookMarks not stopping when logging out. - Fixed queries to RoleListModel not stopping when logging out. - Fixed queries to SystemPermissionListModel not stopping when logging out. Change-Id: Ibd2718649ab4031e6ff2b0d0e6c449f53164ff9f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=888492 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendFailureEventListener.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/CommonModelManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/presenter/LoginSectionPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/presenter/LoginSectionPresenter.java 6 files changed, 12 insertions(+), 52 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd2718649ab4031e6ff2b0d0e6c449f53164ff9f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal,webadmin: fix dtd check
by derez＠redhat.com 01 Apr '13

01 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal,webadmin: fix dtd check ...................................................................... userportal,webadmin: fix dtd check In another patch we added set-property-fallback which is not defined in the GWT dtd before 2.5. This patch sets the DTD to 2.5 so that eclipse doesn't complain about it. Note that the DTD version for userportal was 2.3 and webadmin was 2.2. The build doesn't actually care about the DTD. Change-Id: I9523686fa7b7e005830b4f247d998fbfb01259e2 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/WebAdmin.gwt.xml 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Alexander Wels: Verified Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9523686fa7b7e005830b4f247d998fbfb01259e2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: removed --no-mem-check from engine-setup
by juan.hernandez＠redhat.com 01 Apr '13

01 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: removed --no-mem-check from engine-setup ...................................................................... packaging: removed --no-mem-check from engine-setup If minimum memory requirements are not met: - on interactive mode, stop, warn and ask if to abort - on answer file mode don't stop, issue the warning in the log. The assumption here is that users of the answer file are aware of the requirements and had to read the manual to use this option. Moved requirements check after process initialization avoiding double execution of the check. Change-Id: I7180589490cf74fcb402bd3b957ae8ae8479715d Bug-Url: https://bugzilla.redhat.com/928386 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py 1 file changed, 23 insertions(+), 11 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7180589490cf74fcb402bd3b957ae8ae8479715d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: remove redundant file from spec
by juan.hernandez＠redhat.com 01 Apr '13

01 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: remove redundant file from spec ...................................................................... packaging: remove redundant file from spec Change-Id: Icf65792b0ce1ab1774852a8d2f17a409a92e1620 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13380 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf65792b0ce1ab1774852a8d2f17a409a92e1620 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: cleanup: merge check for running ...
by juan.hernandez＠redhat.com 01 Apr '13

01 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: cleanup: merge check for running process ...................................................................... packaging: engine-service: cleanup: merge check for running process Change-Id: I20238c634c418029c669bdf2b4b77e329b39faa1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20238c634c418029c669bdf2b4b77e329b39faa1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: cleanup pyflakes warnings
by juan.hernandez＠redhat.com 01 Apr '13

01 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: cleanup pyflakes warnings ...................................................................... packaging: engine-service: cleanup pyflakes warnings Change-Id: I2186d79e96aaf2789ee860e7e7e34a20d71e6287 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2186d79e96aaf2789ee860e7e7e34a20d71e6287 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: /etc/ovirt-engine/engine.conf* should not be owne...
by juan.hernandez＠redhat.com 01 Apr '13

01 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: /etc/ovirt-engine/engine.conf* should not be owned by engine ...................................................................... packaging: /etc/ovirt-engine/engine.conf* should not be owned by engine engine does not and should not write into it. if there is secret configuration it can be explicitly written owned by engine. Change-Id: I6d9ca270bd1d3a16591a3d4fae65bbaac65c8654 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M packaging/fedora/setup/common_utils.py M packaging/fedora/spec/ovirt-engine.spec.in 3 files changed, 7 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d9ca270bd1d3a16591a3d4fae65bbaac65c8654 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: /etc/ovirt-engine should not be owned by engine
by juan.hernandez＠redhat.com 01 Apr '13

01 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: /etc/ovirt-engine should not be owned by engine ...................................................................... packaging: /etc/ovirt-engine should not be owned by engine engine does not and should not write into it. Change-Id: Ic24afe853410a56bd27dd613764bb8dd8b18e1c3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in M packaging/fedora/spec/ovirt-engine.spec.in 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic24afe853410a56bd27dd613764bb8dd8b18e1c3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0