April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: Fix findbugs error in VmListModel class
by tnisan＠redhat.com 25 Apr '13

25 Apr '13

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Fix findbugs error in VmListModel class ...................................................................... frontend: Fix findbugs error in VmListModel class Change-Id: I38b0b40dd4316162440ed40d2947549a63a41b1e Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolVmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 2 files changed, 101 insertions(+), 103 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38b0b40dd4316162440ed40d2947549a63a41b1e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.0]: vdsm: bridge: fix typo in format when querying network manag...
by Alon Bar-Lev 25 Apr '13

25 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: bridge: fix typo in format when querying network manager ...................................................................... vdsm: bridge: fix typo in format when querying network manager Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=956602 Change-Id: Id594f22fe49b7def9e278466ce1623e951252f88 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/ovirt-host-deploy/vdsm/bridge.py 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14236 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id594f22fe49b7def9e278466ce1623e951252f88 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: bridge: fix typo in format when querying network manag...
by Alon Bar-Lev 25 Apr '13

25 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: bridge: fix typo in format when querying network manager ...................................................................... vdsm: bridge: fix typo in format when querying network manager Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=956602 Change-Id: Id594f22fe49b7def9e278466ce1623e951252f88 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/ovirt-host-deploy/vdsm/bridge.py 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14234 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id594f22fe49b7def9e278466ce1623e951252f88 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: start method with lowercase
by tnisan＠redhat.com 25 Apr '13

25 Apr '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: start method with lowercase ...................................................................... webadmin: start method with lowercase Start private method with lowercase in StorageListModel Change-Id: I515aaf27351928cf5b7d4f43378c2865f6a1fcf0 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 19 insertions(+), 19 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I515aaf27351928cf5b7d4f43378c2865f6a1fcf0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: api: rename method in BackendStorageDomainsResource
by tnisan＠redhat.com 25 Apr '13

25 Apr '13

Tal Nisan has submitted this change and it was merged. Change subject: api: rename method in BackendStorageDomainsResource ...................................................................... api: rename method in BackendStorageDomainsResource Renamed internal method because it was too long and didn't match all the use cases it was dealing with. Change-Id: I862f7da6a9460268f3573f82acbfab68c0f14551 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I862f7da6a9460268f3573f82acbfab68c0f14551 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Propagate error message when quering for LDAP users/...
by asaf＠redhat.com 25 Apr '13

25 Apr '13

Asaf Shakarchi has submitted this change and it was merged. Change subject: engine: Propagate error message when quering for LDAP users/groups ...................................................................... engine: Propagate error message when quering for LDAP users/groups Propagating error message when searching AD users/groups via SearchQuery fails, The error is propagated to the webadmin and an inline error message is displayed within the permission view popup. Change-Id: I50da72d12c6d60642ad5e65b9376efc49e4ef699 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapReturnValueBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 84 insertions(+), 9 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Asaf Shakarchi: Verified; Looks good to me, approved Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50da72d12c6d60642ad5e65b9376efc49e4ef699 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Improved gluster validation in add host
by sanjal＠redhat.com 25 Apr '13

25 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: Improved gluster validation in add host ...................................................................... gluster: Improved gluster validation in add host When checking if the host is part of another gluster cluster, - Ignore if the command (gluster peer status) fails, to handle cases where glusterfs is not installed or glusterd is down - Do not perform the check if the cluster in which the host is being added is currently empty i.e. when the host being added will be the first host of the cluster. Change-Id: I06a2ee4621b175aa70f1ccdcf7a740d830494acf Bug-Url: https://bugzilla.redhat.com/956077 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVdsCommandTest.java 2 files changed, 47 insertions(+), 6 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06a2ee4621b175aa70f1ccdcf7a740d830494acf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: [cleanup] organize canMigrateVm method
by ofrenkel＠redhat.com 25 Apr '13

25 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: [cleanup] organize canMigrateVm method ...................................................................... core: [cleanup] organize canMigrateVm method This patch organize MigrateVmCommand#canMigrateVm method: 1. replaced the unused paramter vmGuid with VM instance. that way, the method is more testable (can be tested without mocking, just insert a different VM to check as parameter) 2. remove the can-do-action error messages list from the parameters, and use addCanDoActionMessage & failCanDoAction methods inside the method instead 3. set the action and type for the can-do-action messages in the standard way by override setActionMessageParameters method Change-Id: Ica36ecc272a295ee82ec51d7b62a90d84489d8c9 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java 3 files changed, 51 insertions(+), 54 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/14125 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica36ecc272a295ee82ec51d7b62a90d84489d8c9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: block VM migration during live storage migration
by ofrenkel＠redhat.com 25 Apr '13

25 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: block VM migration during live storage migration ...................................................................... core: block VM migration during live storage migration This is a best-effort fix for preventing a VM from being migrated during migration of one of its disks (live storage migration), and vice versa. One way is already covered - live storage migration is made only when the VM state is up or paused so it can't be executed when the VM is in migration. This patch is partial fix for the opposite way - a check is added to MigrateVmCommand to verify that none of the VM's disks is locked, which is the case when one of its disks is being migrated (or during snapshot creation for the disk). This fix doesn't cover a situation where the VM migration and storage migration/snapshot creation are taking place simultanously, and not cover the case where the VM migration fails thus being rerun and the VM state is switched to 'UP' in the middle of the process. Change-Id: Id630a01368290ba9ac6c71c5cab2095f84fa018b Bug-Url: https://bugzilla.redhat.com/878131 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java 5 files changed, 18 insertions(+), 15 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/14122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id630a01368290ba9ac6c71c5cab2095f84fa018b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-live[master]: ovirt-live: remove wget sanlock 2.6-7
by mgoldboi＠redhat.com 24 Apr '13

24 Apr '13

Moran Goldboim has submitted this change and it was merged. Change subject: ovirt-live: remove wget sanlock 2.6-7 ...................................................................... ovirt-live: remove wget sanlock 2.6-7 we used to get this sanlock version from koji due to a bug. now that this package is in the f18 repo it's not needed Change-Id: I16968be5120673eb6991d09b442aceae55ecaf68 Signed-off-by: Ohad Basan <obasan(a)redhat.com> --- M build.sh 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Moran Goldboim: Looks good to me, approved David Caro: Looks good to me, but someone else must approve Kiril Nesenko: Looks good to me, but someone else must approve Ohad Basan: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16968be5120673eb6991d09b442aceae55ecaf68 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0