April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove checkImagesLocked(vmId, messages)
by amureini＠redhat.com 21 Apr '13

21 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove checkImagesLocked(vmId, messages) ...................................................................... core: Remove checkImagesLocked(vmId, messages) Removed ImagesHandler.checkImagesLocked(Guid vmId, List<String messages), as ImagesHandler should not know about VMs. Wherever it was used (two places - AddVmFromSnapshot and LiveMigrateVmDisks), it was replaced with a direct call to DiskDao and then a simpler call to ImagesHandler.checkImagesLocked (messages, disks). Change-Id: Iae603af05f4b90e8c021113779031846a56c99ff Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 3 files changed, 11 insertions(+), 15 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae603af05f4b90e8c021113779031846a56c99ff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: spelling: s/clsuter/cluster
by amureini＠redhat.com 21 Apr '13

21 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: spelling: s/clsuter/cluster ...................................................................... spelling: s/clsuter/cluster Change-Id: Icc54bd40f76037c3c58dca8da35d14a69f89283f Signed-off-by: Itamar Heim <iheim(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmValidationUtils.java 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc54bd40f76037c3c58dca8da35d14a69f89283f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: use DiskImage.copyOf in getAllDisks query
by derez＠redhat.com 21 Apr '13

21 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: core: use DiskImage.copyOf in getAllDisks query ...................................................................... core: use DiskImage.copyOf in getAllDisks query GetAllDisksByStorageDomainIdQuery: add a copy of the active DiskImage to snapshots list [adding it as is causes infinte recursion in DiskImage->hashCode()] Change-Id: Ieef49f05980cdac8a5e3fbc3652a2ed261c6a8b0 Bug-Url: https://bugzilla.redhat.com/951909 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByStorageDomainIdQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieef49f05980cdac8a5e3fbc3652a2ed261c6a8b0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: wrong quota(s) in dc-quota subtab
by gchaplik＠redhat.com 21 Apr '13

21 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: wrong quota(s) in dc-quota subtab ...................................................................... webadmin: wrong quota(s) in dc-quota subtab Caused by a call to super.syncSearch(), which created a wrong (another) query to server. Change-Id: I3f9f347b15633ab1e8215a45816c7aba1149252b Bug-Url: https://bugzilla.redhat.com/950536 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterQuotaListModel.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14050 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f9f347b15633ab1e8215a45816c7aba1149252b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: When implementing compareTo implement Object.equal...
by shavivi＠redhat.com 21 Apr '13

21 Apr '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: When implementing compareTo implement Object.equals as well ...................................................................... findbugs: When implementing compareTo implement Object.equals as well Change-Id: I69d3ee3cded96c33c4e833fdca09461b7825cf07 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkStatistics.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkStatistics.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/dns/DnsSRVLocator.java 3 files changed, 117 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69d3ee3cded96c33c4e833fdca09461b7825cf07 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Don't mandate a network when adding a template NIC
by mkolesni＠redhat.com 21 Apr '13

21 Apr '13

Mike Kolesnik has submitted this change and it was merged. Change subject: restapi: Don't mandate a network when adding a template NIC ...................................................................... restapi: Don't mandate a network when adding a template NIC In template context, it should be possible to add a NIC even without the network id/name since the network unlinking feature was pushed. The backend will know to fail the action if an empty network is sent and the feature is unsupported. Change-Id: Id5b1953178f4ff5e04a71688d8ccec5d3c789395 Bug-Url: https://bugzilla.redhat.com/952647 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateNicsResource.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5b1953178f4ff5e04a71688d8ccec5d3c789395 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: resources->quota updating
by derez＠redhat.com 21 Apr '13

21 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal: resources->quota updating ...................................................................... userportal: resources->quota updating - Fixed resources quota class cast exception causing quota not to update. Change-Id: Iefbbd93e407f40070bf187557560fb2f73a41c0b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=928967 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/resources/VmTable.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14062 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefbbd93e407f40070bf187557560fb2f73a41c0b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Improved sorting in Setup Networks sub menu
by alkaplan＠redhat.com 21 Apr '13

21 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Improved sorting in Setup Networks sub menu ...................................................................... webadmin: Improved sorting in Setup Networks sub menu Items are now sorted "lexoNumerically" rather than lexicographically. Change-Id: I0de36b3e964801788dc5ccb364c470833f6ea783 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0de36b3e964801788dc5ccb364c470833f6ea783 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: invoke event dialog from sub-tabs
by derez＠redhat.com 21 Apr '13

21 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: invoke event dialog from sub-tabs ...................................................................... webadmin: invoke event dialog from sub-tabs Display event dialog on double-click (or right-click -> Details) an event in Events sub-tabs. Change-Id: I88c2ddbfc8db4e4bd476bb5e1a595274197c2a55 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DataCenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/QuotaModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/StorageModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/TemplateModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/UserModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AbstractSubTabEventView.java 9 files changed, 137 insertions(+), 17 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88c2ddbfc8db4e4bd476bb5e1a595274197c2a55 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.2]: cli: Error type "brick" does not exist." on replace brick
by mpastern＠redhat.com 21 Apr '13

21 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: Error type "brick" does not exist." on replace brick ...................................................................... cli: Error type "brick" does not exist." on replace brick When trying to perform replace-brick operation from the ovirt-shell we get an error message error: type "brick" does not exist. Change-Id: Iff900ec7e7ea8ebde3914ac28e5f72b426cf6544 Bug-Url: https://bugzilla.redhat.com/923196 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/action.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff900ec7e7ea8ebde3914ac28e5f72b426cf6544 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0