April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Japanese - truncated text in snapshots sub-tab
by derez＠redhat.com 17 Apr '13

17 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Japanese - truncated text in snapshots sub-tab ...................................................................... webadmin: Japanese - truncated text in snapshots sub-tab VMs - snapshots sub-tab: - fix columns width. - change header cells 'white-space' to normal (to allow multiple rows). Change-Id: I02f7afb0b7521886df2cf0d99fa9d2b19e077d31 Bug-Url: https://bugzilla.redhat.com/927617 Bug-Url: https://bugzilla.redhat.com/951067 Bug-Url: https://bugzilla.redhat.com/950289 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.ui.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/PopupCellTable.css 3 files changed, 10 insertions(+), 10 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02f7afb0b7521886df2cf0d99fa9d2b19e077d31 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Japanese - truncated text in disk dialog
by derez＠redhat.com 17 Apr '13

17 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Japanese - truncated text in disk dialog ...................................................................... webadmin: Japanese - truncated text in disk dialog Attach Disk dialog: fix columns' width. Change-Id: Ie630bbc4b0647d04454ecc585f5c07f150b580ed Bug-Url: https://bugzilla.redhat.com/927613 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmDiskPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmDiskPopupView.java 3 files changed, 13 insertions(+), 13 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie630bbc4b0647d04454ecc585f5c07f150b580ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: French - truncated text in luns list
by derez＠redhat.com 17 Apr '13

17 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: French - truncated text in luns list ...................................................................... webadmin: French - truncated text in luns list Storage Domain dialog: fix '#path' and 'Vendor Id' width. Change-Id: Ie6bb918b26eda3a283d23495947b1fa83a6a0939 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/SanStorageListLunRoot.css M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/SanStorageListLunTable.css M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/SanStorageListTargetRoot.css M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/SanStorageListTargetTable.css 6 files changed, 10 insertions(+), 10 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6bb918b26eda3a283d23495947b1fa83a6a0939 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Japanese - truncated text in login button
by derez＠redhat.com 17 Apr '13

17 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Japanese - truncated text in login button ...................................................................... webadmin: Japanese - truncated text in login button Storage Domain dialog - target list: fix 'Login' button style. Change-Id: I1a94eab7bfae4c852d0abe1fdbde1175a3509234 Bug-Url: https://bugzilla.redhat.com/927504 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a94eab7bfae4c852d0abe1fdbde1175a3509234 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Japanese - truncated text in target list
by derez＠redhat.com 17 Apr '13

17 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Japanese - truncated text in target list ...................................................................... webadmin: Japanese - truncated text in target list Storage Domain dialog - target list: fix 'Dev.Size' column width. Change-Id: I569b5f86bdd00ecb1f9c78a47306a44aeb89e209 Bug-Url: https://bugzilla.redhat.com/927504 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I569b5f86bdd00ecb1f9c78a47306a44aeb89e209 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Remove deprecated CopyTemplate logic
by derez＠redhat.com 17 Apr '13

17 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Remove deprecated CopyTemplate logic ...................................................................... webadmin: Remove deprecated CopyTemplate logic CopyTemplate is deprecated since MSD (multiple storage domains), hence its logic is no longer needed in the UI. Change-Id: I481ee7bd0c81d8d72d8bc4b6c2a09f22d4d6867a Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/TemplateModule.java 2 files changed, 0 insertions(+), 82 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I481ee7bd0c81d8d72d8bc4b6c2a09f22d4d6867a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Remove deprecated MoveVm logic
by derez＠redhat.com 17 Apr '13

17 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Remove deprecated MoveVm logic ...................................................................... webadmin: Remove deprecated MoveVm logic MoveVm is deprecated since MSD (multiple storage domains), hence its logic is no longer needed in the UI. Change-Id: Ia564a1fc35d1d76e3a2331d43a03afa5b53df4a8 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java 2 files changed, 0 insertions(+), 57 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia564a1fc35d1d76e3a2331d43a03afa5b53df4a8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VmInfoBuilder - use VdsProperties.IDE
by derez＠redhat.com 17 Apr '13

17 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: core: VmInfoBuilder - use VdsProperties.IDE ...................................................................... core: VmInfoBuilder - use VdsProperties.IDE VmInfoBuilder - use VdsProperties.IDE constant instead of hard-coded "ide". Change-Id: I3563cc71a37cfa23e55d8e4748086aadf2d92e2e Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3563cc71a37cfa23e55d8e4748086aadf2d92e2e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: agent: Perform string sanitization on messages
by bazulay＠redhat.com 17 Apr '13

17 Apr '13

Barak Azulay has submitted this change and it was merged. Change subject: agent: Perform string sanitization on messages ...................................................................... agent: Perform string sanitization on messages Messages sent via VirtIO are now checked for being presentable and additionally filtered for invalid characters due to invalid encodings. Change-Id: I499a22e1572b55d1a3a4de7ce6f89ebb130861a8 Bug-Url: https://bugzilla.redhat.com/947014 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/VirtIoChannel.py 1 file changed, 67 insertions(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve Barak Azulay: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I499a22e1572b55d1a3a4de7ce6f89ebb130861a8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DiskInterface enum - remove deprecated SCSI
by derez＠redhat.com 17 Apr '13

17 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: core: DiskInterface enum - remove deprecated SCSI ...................................................................... core: DiskInterface enum - remove deprecated SCSI SCSI DiskInterface is not supported, hence removing it. Change-Id: I416bd5ccce35b82b943506e6c6542ba44aa5d0c9 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskInterface.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 3 files changed, 1 insertion(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I416bd5ccce35b82b943506e6c6542ba44aa5d0c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0