April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: fix SD selection on clone VM from template
by derez＠redhat.com 10 Apr '13

10 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal: fix SD selection on clone VM from template ...................................................................... userportal: fix SD selection on clone VM from template Fixing storage domain selection when creating a VM from template using clone allocation. DisksAllocationModel -> getImageToDestinationDomainMap() should be passed to AddVmFromTemplateParameters (for getting user's selected values). Change-Id: Ic1d372d30b3bcf110fa2f63847f6dfa32f8e6b62 Bug-Url: https://bugzilla.redhat.com/928399 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 2 files changed, 19 insertions(+), 40 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1d372d30b3bcf110fa2f63847f6dfa32f8e6b62 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Fixing mailserver validation
by yzaslavs＠redhat.com 10 Apr '13

10 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Fixing mailserver validation ...................................................................... tools: Fixing mailserver validation This solves mail server validation - In case MAIL_SERVER does not exist, a proper error will be reported indicating MAIL_SERVER should exist. In case MAIL_SERVER exists, but empty or with a non resolvable content, a proper error indicating the MAIL_SERVER should contian resolvable address will be reported. Change-Id: Id78bec65bfa883e5fc7ec369a8b4beba6610b4d0 Bug-Url: https://bugzilla.redhat.com/921405 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/tools/src/main/shell/engine-notifier.sh 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id78bec65bfa883e5fc7ec369a8b4beba6610b4d0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: proxy: add missing /console.vv
by juan.hernandez＠redhat.com 09 Apr '13

09 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: proxy: add missing /console.vv ...................................................................... packaging: proxy: add missing /console.vv Change-Id: Ibfe591cf1087c05c9d6036456b3bb32193cca4e0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/ovirt-engine-proxy.conf.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfe591cf1087c05c9d6036456b3bb32193cca4e0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Display correct error when adding new storage
by tnisan＠redhat.com 09 Apr '13

09 Apr '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Display correct error when adding new storage ...................................................................... webadmin: Display correct error when adding new storage When adding a new Storage Domain (of NFS/Local type) the error displayed when the connection was failed was always "Error creating a storage domain" instead of the actual error from VDSM (no permission error etc.), the connect command was changed to propegated the VDSM error to the client there it will be tranlsated and be displayed as the translated user friendly value Change-Id: Ib8f721d3f10596253ca194a36139ba9ebcdff246 Bug-Url: https://bugzilla.redhat.com/843440 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 4 files changed, 20 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8f721d3f10596253ca194a36139ba9ebcdff246 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Builders infrastructure
by tjelinek＠redhat.com 09 Apr '13

09 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: Builders infrastructure ...................................................................... userportal,webadmin: Builders infrastructure An implementation of a flexible, easy to use, reuse an extend functionality of the builders between backend and frontend models. Change-Id: If81d4c71f9feebd6ececb9a2be46b353383046de Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/BaseSyncBuilder.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/Builder.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/BuilderExecutor.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/BuilderList.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/CompositeBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/builders/BuilderExecutorTest.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/builders/TestingBackendModel.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/builders/TestingFrontendModel.java 9 files changed, 634 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If81d4c71f9feebd6ececb9a2be46b353383046de Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:delete_async_tasks_and_compensation_data...
by emesika＠redhat.com 09 Apr '13

09 Apr '13

Eli Mesika has submitted this change and it was merged. Change subject: core:delete_async_tasks_and_compensation_data... ...................................................................... core:delete_async_tasks_and_compensation_data... delete_async_tasks_and_compensation_data.sql exits on KeyError Adding a CASCADE to the TRUNCATE commands to force tables cleanup. Change-Id: I097bf1f388f082f768cd50c33d11ea1e9f081004 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=949229 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/delete_async_tasks_and_compensation_data.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I097bf1f388f082f768cd50c33d11ea1e9f081004 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove value from LockIdNameAttribute declaration
by mkublin＠redhat.com 09 Apr '13

09 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: core: remove value from LockIdNameAttribute declaration ...................................................................... core: remove value from LockIdNameAttribute declaration Remove specifying isReleaseAtEndOfExecute=true in @LockIdNameAttribute annotation declaration since it is the default value anyway. Change-Id: I2092f0c6c9a616b2133ce99cb557ba31a9cc1755 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13588 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2092f0c6c9a616b2133ce99cb557ba31a9cc1755 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in otopi[master]: core: cleanup pep8 warnings
by Alon Bar-Lev 09 Apr '13

09 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: cleanup pep8 warnings ...................................................................... core: cleanup pep8 warnings not shown at my environment... Change-Id: If3d16997af12e27216bad55339ecfb927ab6cec1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/context.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3d16997af12e27216bad55339ecfb927ab6cec1 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix overriding placeholder val in audit log
by mkublin＠redhat.com 09 Apr '13

09 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: core: fix overriding placeholder val in audit log ...................................................................... core: fix overriding placeholder val in audit log Fix overriding placeholder value set in AugitLogableBase.customValues with empty string in TypeCompat. In cases when the value of a placeholder was already populated with custom value, no need to invoke a method to try populate it again since in some cases an empty string returns causing the override of already set non empty value. Example where bug is shown - storagePoolName is displayed as unknown. "Host cannot access one of the Storage Domains attached to the Data Center <UNKNOWN>. Setting Host state to Non-Operational." Change-Id: I4239085d0bd0246369e93e38a394ab8306c05887 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4239085d0bd0246369e93e38a394ab8306c05887 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Stay in the same tab if possible
by gchaplik＠redhat.com 09 Apr '13

09 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Stay in the same tab if possible ...................................................................... webadmin: Stay in the same tab if possible Suggested behaviour for the system tree: - Dont change the selected main tab if the new tree item can show that tab Example case: Hosts tab is selected -> select spesific storage in system tree old behaviour: switch to clusters tab new behaviour: stay in hosts tab (because it is possible) Change-Id: I2c27536ecb5ef9a8f48205c217fbdf295860e363 Signed-off-by: noam slomianko <nslomian(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 35 insertions(+), 26 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c27536ecb5ef9a8f48205c217fbdf295860e363 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Anonymous Coward #1000376 Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0