April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: findbugs: Field masks field in superclass
by shavivi＠redhat.com 28 Apr '13

28 Apr '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Field masks field in superclass ...................................................................... findbugs: Field masks field in superclass Change-Id: I544d5e4e602040c70020fa9b2c43a49ad0bbcb9d Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeOptionsInfoQueryTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I544d5e4e602040c70020fa9b2c43a49ad0bbcb9d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: #920483 - Group Wrongly Displayed as User (within p...
by oliel＠redhat.com 28 Apr '13

28 Apr '13

Ori Liel has submitted this change and it was merged. Change subject: restapi: #920483 - Group Wrongly Displayed as User (within permission) ...................................................................... restapi: #920483 - Group Wrongly Displayed as User (within permission) Change-Id: I08ad600d9b8af6dc8628a8ea9677d9c37fe89928 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendEntityAssignedPermissionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUserAssignedPermissionsResourceTest.java 3 files changed, 28 insertions(+), 17 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08ad600d9b8af6dc8628a8ea9677d9c37fe89928 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Suggest an action when network is out of sync
by masayag＠redhat.com 28 Apr '13

28 Apr '13

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Suggest an action when network is out of sync ...................................................................... webadmin: Suggest an action when network is out of sync Change-Id: I21bccd87bf1311f6d2d87683f1fb1c7507bb8461 Bug-Url: https://bugzilla.redhat.com/951920 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21bccd87bf1311f6d2d87683f1fb1c7507bb8461 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: make cpu-mode enumerable values lower-case #915042
by mpastern＠redhat.com 28 Apr '13

28 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: make cpu-mode enumerable values lower-case #915042 ...................................................................... restapi: make cpu-mode enumerable values lower-case #915042 Change-Id: I50623ebbc1ec7146c2b35c0f48e23aa69691df3e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=915042 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50623ebbc1ec7146c2b35c0f48e23aa69691df3e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: log rotation - do not execute ls on non-existing ...
by oschreib＠redhat.com 28 Apr '13

28 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: log rotation - do not execute ls on non-existing files ...................................................................... packaging: log rotation - do not execute ls on non-existing files Due to the usage of ls, ovirtlogrot.sh would print error messages if it couldn't find any file matching the pattern engine.log.* This patch removes the execution of ls, and therefore, removes the error messages. Change-Id: Icb3d443dd26c6e22302a694c1d0f433383f312b7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=889751 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M packaging/resources/ovirtlogrot.sh 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb3d443dd26c6e22302a694c1d0f433383f312b7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: update .gitignore
by oschreib＠redhat.com 28 Apr '13

28 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: update .gitignore ...................................................................... packaging: update .gitignore Change-Id: Ibdfa98a74f41feba87a89d2562ed91fdbcd300d9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdfa98a74f41feba87a89d2562ed91fdbcd300d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove get image info call before images commands
by ofrenkel＠redhat.com 28 Apr '13

28 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: Remove get image info call before images commands ...................................................................... core: Remove get image info call before images commands BaseImageCommands calls for an image info updates its last modification time on success and does nothing(!) on failure - the nothing is achieved by updating the status in the DB and throwing an exception right afterwards - which means a rollback to the update will be made. also removed the unused VdcBllErrors.RESOURCE_MANAGER_VM_SNAPSHOT_MISSMATCH Change-Id: I93e53f009030fe38d57274544146102010570814 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreFromSnapshotCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 10 files changed, 0 insertions(+), 61 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13994 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93e53f009030fe38d57274544146102010570814 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging - added check on firewall-cmd support
by oschreib＠redhat.com 28 Apr '13

28 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging - added check on firewall-cmd support ...................................................................... packaging - added check on firewall-cmd support Added a check for --permanet option support for firewall-cmd. If it's not supported, firewalld will not be available as firewall manager. Moved firewalld to global scope, the import will not fail also if firewalld is not installed on the system. Change-Id: I64c441c7fde548a8b2798c9f63d59962ff6e51c3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine_firewalld.py 2 files changed, 19 insertions(+), 6 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64c441c7fde548a8b2798c9f63d59962ff6e51c3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove printing from VmHandlerTest
by amureini＠redhat.com 28 Apr '13

28 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove printing from VmHandlerTest ...................................................................... core: Remove printing from VmHandlerTest Removed System.out.println usage from VmHandlerTest - this is not how to log. Change-Id: I523ed85999cab2fda40dbf0bddfca8d8308df671 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I523ed85999cab2fda40dbf0bddfca8d8308df671 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RemoveVdsCommandTest + CanDoActionTestUtils
by amureini＠redhat.com 28 Apr '13

28 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveVdsCommandTest + CanDoActionTestUtils ...................................................................... core: RemoveVdsCommandTest + CanDoActionTestUtils Use CanDoActionTestUtils in RemoveVdsCommandTest instead of reinventing the wheel. Change-Id: I946881b0cc7cdad1293b27517a04a624231b9563 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java 1 file changed, 7 insertions(+), 37 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I946881b0cc7cdad1293b27517a04a624231b9563 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0