April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[master]: sdk: release 3.3.0.1-1
by mpastern＠redhat.com 02 Apr '13

02 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: release 3.3.0.1-1 ...................................................................... sdk: release 3.3.0.1-1 Change-Id: I3981966bb960a0e1d0fd6a15f06fe7bba97641f7 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-sdk.spec.in 2 files changed, 27 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3981966bb960a0e1d0fd6a15f06fe7bba97641f7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: regenerate against the latest api
by mpastern＠redhat.com 02 Apr '13

02 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: regenerate against the latest api ...................................................................... sdk: regenerate against the latest api - added new collection ClusterGlusterVolumeBrickStatistics - added new argument to the ClusterGlusterVolumeBricks.list(all_content=None) - added NetUp 'cloned disk' importing capabilities - to host install method added new parameter "image" - to host add method added new parameter "display.address" - to vm add method added new parameter "vm.cpu.mode" - to vm add method added new overload for creating vm from snapshot Change-Id: Ice91c2cd3744b177baf9dcabd091108990d01ee4 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 2 files changed, 1,239 insertions(+), 21 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13515 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice91c2cd3744b177baf9dcabd091108990d01ee4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Wrong error message is shown, when SuperUser permi...
by mkublin＠redhat.com 02 Apr '13

02 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: webadmin: Wrong error message is shown, when SuperUser permissions are removing from admin internal ...................................................................... webadmin: Wrong error message is shown, when SuperUser permissions are removing from admin internal The following bug contains two errors: 1. Fixing error message: Cannot ${action} ${type}. 2. In canDoAction() , if we failed at first condition, no reason to perfrom additional checks Change-Id: I825a379b383fd923046e17e6f1d27c6003c48900 Bug-Url: https://bugzilla.redhat.com/924880 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemovePermissionCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 15 insertions(+), 4 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I825a379b383fd923046e17e6f1d27c6003c48900 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.2]: sdk: return error if amount of fetched objects in X.get() is...
by mpastern＠redhat.com 02 Apr '13

02 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: return error if amount of fetched objects in X.get() is > 1 #890327 ...................................................................... sdk: return error if amount of fetched objects in X.get() is > 1 #890327 https://bugzilla.redhat.com/show_bug.cgi?id=890327 Change-Id: I98b72a9235825f62297b35a26c0bd76413bc0143 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/templates/collectiongetdiskstemplate M src/codegen/templates/collectiongetnotsearchabletemplate M src/codegen/templates/collectiongetsearchabletemplate M src/codegen/templates/subcollectiongettemplate M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/infrastructure/errors.py M src/ovirtsdk/utils/filterhelper.py M src/ovirtsdk/xml/params.py 8 files changed, 415 insertions(+), 85 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98b72a9235825f62297b35a26c0bd76413bc0143 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Block Hot Adding a Nic in 3.0
by msalem＠redhat.com 02 Apr '13

02 Apr '13

Muli Salem has submitted this change and it was merged. Change subject: engine: Block Hot Adding a Nic in 3.0 ...................................................................... engine: Block Hot Adding a Nic in 3.0 This patch makes sure not to hot-plug a nic in a VM that belongs to a cluster with a version that does not support hot-plugging. Previously, the condition that was used in the canDoAction coupled between two conditions that are not related. Change-Id: Ic0ee6563b55a84421b3a9a068e6d69ff228d46ae Bug-Url: https://bugzilla.redhat.com/923332 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0ee6563b55a84421b3a9a068e6d69ff228d46ae Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Additional clean up in AuditLogDirector
by mkublin＠redhat.com 02 Apr '13

02 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Additional clean up in AuditLogDirector ...................................................................... engine: Additional clean up in AuditLogDirector Variable auditLogable can not be null, if it null we will fail on NullPointerException inside updateTimeoutLogableObject method. After removing such condition, were removed all relevant and dead code. Also, I chnaged tempVar to auditLog varibale, don't see reason for using tempVar Change-Id: Ia0eb406d78965bb0d84c7ce80761028877ab2879 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 38 insertions(+), 48 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0eb406d78965bb0d84c7ce80761028877ab2879 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Clean unused method
by mkublin＠redhat.com 02 Apr '13

02 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Clean unused method ...................................................................... engine: Clean unused method The following method is not in use, so removed Change-Id: I82d7ae999a38c4ec9690192e4e26d09bf0f5343f Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java 2 files changed, 0 insertions(+), 25 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82d7ae999a38c4ec9690192e4e26d09bf0f5343f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Super audit log improvement
by mkublin＠redhat.com 02 Apr '13

02 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Super audit log improvement ...................................................................... engine: Super audit log improvement So what is current (before patch) behaviour inorder to make some audit log message: 1. Pass class that extends AuditLogableBase 2. Pass a message with keys that should be replaces based on properties from passed class 3. Go over all properties in passed class, collect them and create a HashMap with key as property name and value as property value 4. Replace keys in message using a created HashMap. Now, lets take a look on 3, how we retrieve a properties - we invoke all getXXX methods in our class. How many getXXX methods has simple AuditLogableBase class? How big will be our HashMap? How many queries/calculations will run during invoking some of the getXXX messages, because our class not simple bean? The only answer is a lot, only in simple run I saw a HashMap with 150 values (sic!). I fix this, if I have a message I know all keys that I need, I don't need to go throught all getXXX methods. Intresting fact: optimized solution required less code. Another intresting fact - adding of additional getter to AuditLogableBase, before a fix, was like adding a small brake to the system. Change-Id: Id68a098be36fcfc47c23c57fce3abea50e6273e3 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirectorTest.java 2 files changed, 23 insertions(+), 23 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id68a098be36fcfc47c23c57fce3abea50e6273e3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Improving memory footprint for almost every command ...
by mkublin＠redhat.com 02 Apr '13

02 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Improving memory footprint for almost every command in the system ...................................................................... engine: Improving memory footprint for almost every command in the system The custom properties is private case, so allocation of HashMap is required only in small number of commands, benefit - we will not allocate thouthands of HashMaps In case that we need a custom properties , map will be allocated Change-Id: I266ac0abd5e53ec7c7948059ee575aac6b53c17b Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I266ac0abd5e53ec7c7948059ee575aac6b53c17b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Simplify AuditLogHelper
by mkublin＠redhat.com 02 Apr '13

02 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Simplify AuditLogHelper ...................................................................... engine: Simplify AuditLogHelper Replacing hand made code by java standard code. Change-Id: Ibf52160dba842985b6cb1fa66fc08c538b2ead6a Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogHelper.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogHelperTest.java 2 files changed, 23 insertions(+), 28 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf52160dba842985b6cb1fa66fc08c538b2ead6a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0