May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix NPE in LiveMigrateVmDisksCommand
by derez＠redhat.com 26 May '13

26 May '13

Daniel Erez has submitted this change and it was merged. Change subject: core: Fix NPE in LiveMigrateVmDisksCommand ...................................................................... core: Fix NPE in LiveMigrateVmDisksCommand Commit ed336c64b281bac151cb365f84668f401f272afa removes 'setStoragePoolId(getVm().getStoragePoolId())' from getPermissionCheckSubjects() since it's not needed for perms check anymore. Hence, added it back in canDoAction to prevent NPE on canDo validations. Change-Id: Ic64bddc52fa5c1745c6064c8243f8c4e7921ef22 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved Maor Lipchuk: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic64bddc52fa5c1745c6064c8243f8c4e7921ef22 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Avoid empty statements
by amureini＠redhat.com 26 May '13

26 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Avoid empty statements ...................................................................... engine: Avoid empty statements Cleared the code of empty statements (";" with nothing else) and enabled the checkstyle validation to make sure they don't re-occur. Change-Id: I4c2a9bc60b17796fcb0bd2a3b0f0f076f2117f4d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmAndTemplatesGenerationsDaoTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReapedMap.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/archivers/tar/TarTest.java M build-tools-root/checkstyles/src/main/resources/checkstyle.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java 6 files changed, 8 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15006 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c2a9bc60b17796fcb0bd2a3b0f0f076f2117f4d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: doc: document dao database upgrade
by yzaslavs＠redhat.com 23 May '13

23 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: doc: document dao database upgrade ...................................................................... doc: document dao database upgrade Change-Id: I0fbd1d9bb5f10466a78ff0d7984d0db7c487e783 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README.developer 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fbd1d9bb5f10466a78ff0d7984d0db7c487e783 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Re-ordering validations at create snapshot command.
by mlipchuk＠redhat.com 23 May '13

23 May '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Re-ordering validations at create snapshot command. ...................................................................... core: Re-ordering validations at create snapshot command. Some validations in the create snapshot command were only executed if the VM had disks, that caused the command to skip validations for diskless VM. The fix was to move the relevant validations to be executed regardless to the VM disks. Also added a test for create snapshot from VM. Bug-Url: https://bugzilla.redhat.com/903245 Change-Id: I58bfc73383ce5ca06bf670a8f63b5563da9caa02 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java 2 files changed, 306 insertions(+), 25 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58bfc73383ce5ca06bf670a8f63b5563da9caa02 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix test break in UpdateVmDisksCommandTest
by mlipchuk＠redhat.com 23 May '13

23 May '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix test break in UpdateVmDisksCommandTest ...................................................................... core: Fix test break in UpdateVmDisksCommandTest Fixed the test break caused by commit b0e796daa33a5c2e693bc785c064b81dc7e9e79f. Change-Id: Ifa0f74d5ebe8aa33b70ce9cb3772d8ce5c894cbb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa0f74d5ebe8aa33b70ce9cb3772d8ce5c894cbb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: Remove double.doubleToLongBits from VM.hashCode
by shavivi＠redhat.com 23 May '13

23 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: Remove double.doubleToLongBits from VM.hashCode ...................................................................... Remove double.doubleToLongBits from VM.hashCode patch http://gerrit.ovirt.org/#/c/14965 added hashCode to VM, but GWT doesn't support doubleToLongBits() method. Change-Id: I4b5f9afabb645ece870df409e5959d151d1952e1 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b5f9afabb645ece870df409e5959d151d1952e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Check all attached VMs when updating shared disk boot ...
by tnisan＠redhat.com 23 May '13

23 May '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Check all attached VMs when updating shared disk boot flag ...................................................................... core: Check all attached VMs when updating shared disk boot flag When updating a VM disk to be bootable, the other VMs that the disk is attached to were checked to see if they already have a bootable disk attached and if so the operation would have failed giving an error message that the VM already has a bootable disk attached. This check was changed to check all VMs and after iterating on all if one or more contained a bootable disk fail and give an error message containing all of the VMs that the operation failed on so the user will have all the info in the first try Also introduced a new DAO method to retrieve a VM bootable disk from the DB Bug-Url: https://bugzilla.redhat.com/949923 Change-Id: I82ee07e02e08d60f559017d9f8205ab7df41c5c3 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/dbscripts/all_disks_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 69 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82ee07e02e08d60f559017d9f8205ab7df41c5c3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: liron aravot <liron.aravot(a)gmail.com>

1 0

Change in ovirt-engine[master]: core: add destination sd to CopyImageVDSCommand log
by tnisan＠redhat.com 23 May '13

23 May '13

Tal Nisan has submitted this change and it was merged. Change subject: core: add destination sd to CopyImageVDSCommand log ...................................................................... core: add destination sd to CopyImageVDSCommand log When executing CopyImageVDSCommand, the destination sd wasn't printed. Adding it to have more clear logs. Change-Id: I8e36973cc099d3a373b1f3d2b8a08bf9fe50100a Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CopyImageVDSCommand.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e36973cc099d3a373b1f3d2b8a08bf9fe50100a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: fix forwarding vdsm errors
by sanjal＠redhat.com 23 May '13

23 May '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: fix forwarding vdsm errors ...................................................................... gluster: fix forwarding vdsm errors set 'null' to VdcFault.Error to make the frontend to show the error returned by vdsm instead of "Internal Server Error". Change-Id: I5df008d6626da5ff0de4ad6231ef65f51e08ec84 Bug-Url: https://bugzilla.redhat.com/956159 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Shireesh Anjal: Looks good to me, approved Kanagaraj M: Verified -- To view, visit http://gerrit.ovirt.org/15022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5df008d6626da5ff0de4ad6231ef65f51e08ec84 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated otopi for fully automated execution
by juan.hernandez＠redhat.com 23 May '13

23 May '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated otopi for fully automated execution ...................................................................... packaging: Updated otopi for fully automated execution This patch updates an otopi engine-setup plugin to allow a completely automated setup execution with the additional config file provided on command line. This allows a flow similar to one using an "answerfile" in the legacy setup. Additionally, this patch updates parameters for the automated cleanup flows, so they also can be done in unattended mode. This patch updates the handling of the following constants: OVESETUP_APACHE/configureRootRedirection OVESETUP_APACHE/configureSsl OVESETUP_CONFIG/isoDomainMountPoint OVESETUP_DIALOG/confirmSettings OVESETUP_CORE/engineStop OVESETUP_CORE/remove Change-Id: Ia327a4be9e1f5498e6aedc7dfb66663dd861fc26 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/apache/root.py M packaging/setup/plugins/ovirt-engine-setup/apache/ssl.py M packaging/setup/plugins/ovirt-engine-setup/config/iso_domain.py M packaging/setup/plugins/ovirt-engine-setup/dialog/preview.py 5 files changed, 61 insertions(+), 26 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia327a4be9e1f5498e6aedc7dfb66663dd861fc26 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0