May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: align path field in local storage dialog
by tnisan＠redhat.com 26 May '13

26 May '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: align path field in local storage dialog ...................................................................... webadmin: align path field in local storage dialog Align path field in local storage popup dialog so it will be aligned with rest of the fields in dialog. Change-Id: Iaf55a833fb0bb0084ec2548a90b094ef40daf4b9 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/LocalStorageView.ui.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf55a833fb0bb0084ec2548a90b094ef40daf4b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: fix failure of cleaning database
by oschreib＠redhat.com 26 May '13

26 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: fix failure of cleaning database ...................................................................... packaging: setup: fix failure of cleaning database Change-Id: I698eead168e25019f57feb0b9493bc87aa38ce33 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-remove/db/clear.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I698eead168e25019f57feb0b9493bc87aa38ce33 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: separate pki config and keys groups
by oschreib＠redhat.com 26 May '13

26 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: separate pki config and keys groups ...................................................................... packaging: setup: separate pki config and keys groups using separate pki config and keys for uninstall groups Change-Id: Ied09af0cb1ace07101629273746ed3eb820a78ee Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/config/ca.py M packaging/setup/plugins/ovirt-engine-setup/pki/ca.py 2 files changed, 13 insertions(+), 14 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied09af0cb1ace07101629273746ed3eb820a78ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: fixed uninstall UX
by oschreib＠redhat.com 26 May '13

26 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: fixed uninstall UX ...................................................................... packaging: setup: fixed uninstall UX - avoid to create empty section in uninstall file - avoid to ask more than one time about uninstalling a group Change-Id: I95dddc2205a7e16dc4f4848fb6fdeab7b1e2ec2b Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-remove/files/simple.py M packaging/setup/plugins/ovirt-engine-setup/core/uninstall.py 2 files changed, 65 insertions(+), 31 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95dddc2205a7e16dc4f4848fb6fdeab7b1e2ec2b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: fixed cpu validation
by oschreib＠redhat.com 26 May '13

26 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: fixed cpu validation ...................................................................... packaging: setup: fixed cpu validation - removed unused constant AIO_VDSM_CAPS_MODULE. - added check on virtualization hardware / bios support - avoid to enable AIO plugin if the host doesn't support virtualization Change-Id: I9c19c1d6bf80c0d5f54105f785d97ba7b203cccc Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/all-in-one/cpu.py 2 files changed, 35 insertions(+), 17 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c19c1d6bf80c0d5f54105f785d97ba7b203cccc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: clone does not call super clone method
by shavivi＠redhat.com 26 May '13

26 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: clone does not call super clone method ...................................................................... findbugs: clone does not call super clone method findbugs reason: CN: clone method does not call super.clone() (CN_IDIOM_NO_SUPER_CALL) Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> Change-Id: Idfe05e69c8cde480c4cba93a1ce185691d9d9316 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParametersWrapper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/Signature.java 3 files changed, 8 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfe05e69c8cde480c4cba93a1ce185691d9d9316 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: Redundant nullcheck of value known to be non null
by shavivi＠redhat.com 26 May '13

26 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Redundant nullcheck of value known to be non null ...................................................................... findbugs: Redundant nullcheck of value known to be non null findbugs reason: RCN: Redundant nullcheck of value known to be non-null Change-Id: Iba61834fecf74eabdcabd8f120b184430038c8c6 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddEventSubscriptionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJobTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/PairQueryable.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainsResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReapedMap.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/NullableButtonCell.java 17 files changed, 43 insertions(+), 70 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba61834fecf74eabdcabd8f120b184430038c8c6 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-dwh[master]: history: added missing enum keys for OS (#966437)
by ydary＠redhat.com 26 May '13

26 May '13

Yaniv Dary has submitted this change and it was merged. Change subject: history: added missing enum keys for OS (#966437) ...................................................................... history: added missing enum keys for OS (#966437) Bug-Url: https://bugzilla.redhat.com/966437 Change-Id: I86f8c98a54b686c470939c2601a355c7e3abc0f6 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- A data-warehouse/historydbscripts_postgres/upgrade/03_02_0080_added_missing_os_enums.sql 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15064 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86f8c98a54b686c470939c2601a355c7e3abc0f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: ignore: Redundant null check from getConfigValue
by shavivi＠redhat.com 26 May '13

26 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: Redundant null check from getConfigValue ...................................................................... findbugs: ignore: Redundant null check from getConfigValue findbugs complains that we are checking ldapPort for null when its not suppose to be null. in this case we are checking for the return value from getConfigValue() and we may have a null value from the Database findbugs reason: RCN: Redundant nullcheck of value known to be non-null Change-Id: If712c28362bae2cfa756c14d8cadf1e96fc3e187 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/tools/exclude-filters.xml 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15019 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If712c28362bae2cfa756c14d8cadf1e96fc3e187 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: fndbugs: method contains a redundant check of a null value
by shavivi＠redhat.com 26 May '13

26 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: fndbugs: method contains a redundant check of a null value ...................................................................... fndbugs: method contains a redundant check of a null value findbugs reason: RCN: Redundant nullcheck of value known to be null Change-Id: I9655ef3c2b03ff0b9f6f4da8eaafe275950a6394 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/CustomSelectionCell.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9655ef3c2b03ff0b9f6f4da8eaafe275950a6394 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0