May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Added functionality to Providers tab
by oourfali＠redhat.com 27 May '13

27 May '13

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Added functionality to Providers tab ...................................................................... webadmin: Added functionality to Providers tab Added EXTREMELY BASIC command implementations to add and remove providers. Change-Id: Iab47b6896c752bf867fb4eb6efe3935497eeb138 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ProviderModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/provider/ProviderPopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.ui.xml 8 files changed, 283 insertions(+), 8 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab47b6896c752bf867fb4eb6efe3935497eeb138 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Network Provider main tab
by oourfali＠redhat.com 27 May '13

27 May '13

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Network Provider main tab ...................................................................... webadmin: Network Provider main tab Change-Id: Ide66dd42695293f66d1a0c6ca4a067fff5e81a1d Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderGeneralModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ManagedComponents.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/UiCommonModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ProviderModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/ApplicationPlaces.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabEventPresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabProviderPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabReportsPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabUserPresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/provider/ProviderSubTabPanelPresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/provider/SubTabProviderGeneralPresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabProviderView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/ProviderSubTabPanelView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderGeneralView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderGeneralView.ui.xml 20 files changed, 734 insertions(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11114 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide66dd42695293f66d1a0c6ca4a067fff5e81a1d Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: add and use GetProvidersByType
by oourfali＠redhat.com 27 May '13

27 May '13

Oved Ourfali has submitted this change and it was merged. Change subject: add and use GetProvidersByType ...................................................................... add and use GetProvidersByType Change-Id: I87ef591a2470726cebef142e72eaee28103c81fd Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/dbscripts/providers_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/GetAllProvidersQuery.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllProvidersParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/provider/ProviderDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/provider/ProviderDaoDbFacadeImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 9 files changed, 93 insertions(+), 5 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87ef591a2470726cebef142e72eaee28103c81fd Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: check that the returned pmOptions are not null
by oourfali＠redhat.com 27 May '13

27 May '13

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: check that the returned pmOptions are not null ...................................................................... webadmin: check that the returned pmOptions are not null Change-Id: I7d18c746ee365ca06b972a350fe28cbe2067129f Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 10 insertions(+), 7 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d18c746ee365ca06b972a350fe28cbe2067129f Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: foreman integration - showing foreman hosts in new host dial...
by oourfali＠redhat.com 27 May '13

27 May '13

Oved Ourfali has submitted this change and it was merged. Change subject: foreman integration - showing foreman hosts in new host dialog ...................................................................... foreman integration - showing foreman hosts in new host dialog This patch adds external host provider interface, with an implementation for Foreman, to allow viewing foreman hosts from the "add new host" dialog. Limitations (will be addressed later): 1. Will only work with non-SSL foreman servers Change-Id: I30ea180e477a8f0714c4dc97ec55f29be515723a Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/pom.xml A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetHostListFromExternalProviderQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/HostProviderProxy.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHost.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxyFactory.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetHostListFromExternalProviderQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ProviderType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetHostListFromExternalProviderParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/HostPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 22 files changed, 1,056 insertions(+), 129 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14582 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30ea180e477a8f0714c4dc97ec55f29be515723a Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : Cookies are being set even when not using persiste...
by mpastern＠redhat.com 27 May '13

27 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : Cookies are being set even when not using persistent authentication ...................................................................... restapi : Cookies are being set even when not using persistent authentication API sets jsession id when not using persistent authentication. This patch creates a session only when persistent authentication header is passed in the request. Change-Id: Ieb004fefbd9a276efacb2ce6fa8b7a48a9516c6e Bug-Url: https://bugzilla.redhat.com/962730 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb004fefbd9a276efacb2ce6fa8b7a48a9516c6e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, root: Prevent JSESSIONID cookie for root path
by ecohen＠redhat.com 27 May '13

27 May '13

Einav Cohen has submitted this change and it was merged. Change subject: webadmin,root: Prevent JSESSIONID cookie for root path ...................................................................... webadmin,root: Prevent JSESSIONID cookie for root path Engine "root" web application containing various utility servlets sets JSESSIONID cookie for / (root path) upon following occasions: a. when requesting document file for a missing language, DocsServlet ensures HttpSession -> JSESSIONID cookie in order to read/store "langPageShown" attribute: "Show missing language page only for the first time" b. when processing any JSP page, since each JSP gets HttpSession -> JSESSIONID cookie created eagerly: - ovirt-engine.jsp (splash page) - no_lang.jsp (missing language page) However, setting cookie X for path=/ essentially shadows any other cookie(s) with same name (X) set for path=/foo Consider following example: 1. User visits WebAdmin: - new cookie JSESSIONID for path=/webadmin - WebAdmin JavaScript reads JSESSIONID cookie, correct value is returned 2. User visits "root" web application: - new cookie JSESSIONID for path=/ - WebAdmin JavaScript reads JSESSIONID cookie, wrong value is returned because there are two JSESSIONID cookies and path=/ takes precedence This patch prevents "root" web application from using JSESSIONID cookie (see occasions a. and b. above), which prevents cookie shadowing for WebAdmin. In future, we should consider using different "session" cookie names for different web applications in order to avoid such problems. Change-Id: I3b4c95f0a716bf3cc05d102a1026b3c6aee5879c Bug-Url: https://bugzilla.redhat.com/966525 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/DocsServlet.java M backend/manager/modules/root/src/main/webapp/WEB-INF/help/no_lang.jsp M backend/manager/modules/root/src/main/webapp/WEB-INF/ovirt-engine.jsp 3 files changed, 26 insertions(+), 5 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15057 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b4c95f0a716bf3cc05d102a1026b3c6aee5879c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: core: split out hardware check as it is shared with ovirt-en...
by Alon Bar-Lev 26 May '13

26 May '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: split out hardware check as it is shared with ovirt-engine-setup ...................................................................... core: split out hardware check as it is shared with ovirt-engine-setup Change-Id: I0e9aa168b6f30e2bc2d4dbc3439562e9402dca59 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M po/POTFILES.in M src/ovirt_host_deploy/Makefile.am A src/ovirt_host_deploy/hardware.py M src/plugins/ovirt-host-deploy/vdsm/hardware.py 4 files changed, 222 insertions(+), 154 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e9aa168b6f30e2bc2d4dbc3439562e9402dca59 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: Remove VDS super.clone method
by shavivi＠redhat.com 26 May '13

26 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: Remove VDS super.clone method ...................................................................... Remove VDS super.clone method Not supported by GWT (the actual type that is not supported is the exception: java.lang.CloneNotSupportedException) Change-Id: I3673da05f1cc9c1de834cda4f9ef5865a058d6c8 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3673da05f1cc9c1de834cda4f9ef5865a058d6c8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: fixed br9 query syntax error (#967276)
by ydary＠redhat.com 26 May '13

26 May '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed br9 query syntax error (#967276) ...................................................................... reports: fixed br9 query syntax error (#967276) Bug-Url: https://bugzilla.redhat.com/967276 Change-Id: Iae4e8519323637e00c9dc348bedac8214197136d Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/Reports/Inventory/VM_Inventory_files/full details.jrxml.data 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae4e8519323637e00c9dc348bedac8214197136d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0