July 2013 - Engine-commits - oVirt List Archives

Change in otopi[master]: miniyum: print transaction information when built
by Alon Bar-Lev 11 Jul '13

11 Jul '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: miniyum: print transaction information when built ...................................................................... miniyum: print transaction information when built Change-Id: I94f0f8778a2de99825df0bdcd95d5855ee93f6e8 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/miniyum.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94f0f8778a2de99825df0bdcd95d5855ee93f6e8 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: miniyum: better way to read transaction status
by Alon Bar-Lev 11 Jul '13

11 Jul '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: miniyum: better way to read transaction status ...................................................................... miniyum: better way to read transaction status Change-Id: I08861c971a24a8d2a5b11903e9233847d0d16f6f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/miniyum.py 1 file changed, 15 insertions(+), 11 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08861c971a24a8d2a5b11903e9233847d0d16f6f Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in mom[master]: Remove Collector.instance
by agl＠us.ibm.com 11 Jul '13

11 Jul '13

Adam Litke has submitted this change and it was merged. Change subject: Remove Collector.instance ...................................................................... Remove Collector.instance The virtual function Collector.instance can be replaced with general logic which avoids the need to redefine some boiler-plate code for each new Collector. Change-Id: Icb49d7397fadae141caad61033151d527ea9752c Signed-off-by: Adam Litke <agl(a)us.ibm.com> Reviewed-on: http://gerrit.ovirt.org/13762 --- M mom/Collectors/Collector.py M mom/Collectors/GuestBalloon.py M mom/Collectors/GuestMemory.py M mom/Collectors/GuestNetworkDaemon.py M mom/Collectors/GuestQemuAgent.py M mom/Collectors/GuestQemuProc.py M mom/Collectors/HostKSM.py M mom/Collectors/HostMemory.py M mom/Controllers/Balloon.py M mom/Controllers/KSM.py M mom/PolicyEngine.py 11 files changed, 2 insertions(+), 38 deletions(-) Approvals: Adam Litke: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb49d7397fadae141caad61033151d527ea9752c Gerrit-PatchSet: 4 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Mei Liu <liumbj(a)linux.vnet.ibm.com>

1 0

Change in mom[master]: cleanup: Remove trailing whitespace from all python files
by agl＠us.ibm.com 11 Jul '13

11 Jul '13

Adam Litke has submitted this change and it was merged. Change subject: cleanup: Remove trailing whitespace from all python files ...................................................................... cleanup: Remove trailing whitespace from all python files Using the command below, remove all trailing whitespace characters from python files in the MOM source. This will help make MOM code cleaner and will avoid incremental whitespace noise in future patches. Change-Id: Ibb4ccce9c0cb6884d9d75b04f72c885a272490ed Signed-off-by: Adam Litke <agl(a)us.ibm.com> Reviewed-on: http://gerrit.ovirt.org/13761 --- M contrib/mom-rpcclient.py M mom/Collectors/Collector.py M mom/Collectors/GuestNetworkDaemon.py M mom/Collectors/GuestQemuAgent.py M mom/Collectors/GuestQemuProc.py M mom/Collectors/HostKSM.py M mom/Collectors/HostMemory.py M mom/Collectors/QemuGuestAgentClient.py M mom/Controllers/Balloon.py M mom/Controllers/KSM.py M mom/Entity.py M mom/GuestManager.py M mom/GuestMonitor.py M mom/HostMonitor.py M mom/LogUtils.py M mom/Monitor.py M mom/Plotter.py M mom/Policy/Parser.py M mom/RPCServer.py M mom/debug/StackDumper.py 20 files changed, 100 insertions(+), 100 deletions(-) Approvals: Adam Litke: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb4ccce9c0cb6884d9d75b04f72c885a272490ed Gerrit-PatchSet: 4 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Mei Liu <liumbj(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: frontend: Creating VM without active storage domain
by tjelinek＠redhat.com 11 Jul '13

11 Jul '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Creating VM without active storage domain ...................................................................... frontend: Creating VM without active storage domain In past the engine allowed user to create a VM even if the SD was not initialized (by manually selecting specific DC in the tree menu). This patch brings this functionality back. Change-Id: Ib1ae0b7564be7fa7072af6ab2a545affefbd0bed Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1ae0b7564be7fa7072af6ab2a545affefbd0bed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove compatibility version from IrsBaseVDSCommandPar...
by ofrenkel＠redhat.com 11 Jul '13

11 Jul '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: remove compatibility version from IrsBaseVDSCommandParameters ...................................................................... core: remove compatibility version from IrsBaseVDSCommandParameters The IrsBaseVDSCommandParameters class had a compatibility version field that was really used only by UpgradeStoragePoolVDSCommand, thus it is moved to UpgradeStoragePoolVDSCommandParameters. This patch also contains other kinds of minor refactoring: 1. move field declarations to the beginning of the classes 2. remove 'private' prefix from field names Change-Id: I785e868a1a192af5e5722c5c4562870c69c96b9c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveTemplateSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/CreateImagePlaceholderTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CopyImageVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateImageVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateSnapshotVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DeleteImageGroupVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DestroyImageVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/IrsBaseVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MergeSnapshotsVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MoveImageGroupVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UpgradeStoragePoolVDSCommandParameters.java 25 files changed, 69 insertions(+), 99 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/16710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I785e868a1a192af5e5722c5c4562870c69c96b9c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: move VmCommand#removeVmInSpm method
by ofrenkel＠redhat.com 11 Jul '13

11 Jul '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: move VmCommand#removeVmInSpm method ...................................................................... core: move VmCommand#removeVmInSpm method Move VmCommand#removeVmInSpm method to RemoveVmFromImportExportCommand class as it is the only place where this method is called from. The code which is related to disk images removal is extracted from the execute method of RemoveVmFromImportExportCommand to separate method. In addition, minor refactoring is made in the canDoAction method of RemoveVmFromImportExportCommand. Change-Id: Id3945268925fb5f1541fa29c9ef24e97fc243228 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 2 files changed, 26 insertions(+), 20 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/16709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3945268925fb5f1541fa29c9ef24e97fc243228 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup in RemoveVmCommand class
by ofrenkel＠redhat.com 11 Jul '13

11 Jul '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: cleanup in RemoveVmCommand class ...................................................................... core: cleanup in RemoveVmCommand class - Remove canRemoveVmWithDetachDisks#isSnapshotsPresent field - Extract the parameters construction in removeVmImages method to separate method Change-Id: I4079a58d39c613a55c832c62831e78767580842a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java 1 file changed, 11 insertions(+), 14 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/16708 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4079a58d39c613a55c832c62831e78767580842a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: change RemoveVmFromImportExportParamenters to get VM I...
by ofrenkel＠redhat.com 11 Jul '13

11 Jul '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: change RemoveVmFromImportExportParamenters to get VM ID ...................................................................... core: change RemoveVmFromImportExportParamenters to get VM ID RemoveVmFromImportExportCommand only needs the ID of the VM to work with, yet RemoveVmFromImportExportParamenters received VM object. at the REST API and at the UI we were creating VM object just as a wrapper of the VM ID to pass to the parameters class. This patch changes the parameter class to receive ID of VM instead of VM object. This patch also contains minor refactoring in RemoveVmFromImportExportParamenters class. Change-Id: I0fff20548248d3c47087d2d004d285c429a1c081 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmFromImportExportParamenters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java 4 files changed, 17 insertions(+), 28 deletions(-) Approvals: Michael Pasternak: Looks good to me, but someone else must approve Omer Frenkel: Verified; Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/16707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fff20548248d3c47087d2d004d285c429a1c081 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: memory snapshot feature support
by ofrenkel＠redhat.com 11 Jul '13

11 Jul '13

Omer Frenkel has submitted this change and it was merged. Change subject: restapi: memory snapshot feature support ...................................................................... restapi: memory snapshot feature support This patch adds support in the REST API for the memory snapshot feature which is about saving the memory state as part of snapshots, so that it will be possible to restore the same state of the VM as it was at the moment the snapshot was taken, when the VM is reverted to the snapshot. An attribute of type boolean which indicates whether the snapshot contains memory or not is added to the snapshot entity. The user can select when creating a snapshot whether the created snapshot should include memory state or not. The user can select when previewing and restoring snapshots whether to restore the snapshot's memory (which means that the memory that is saved in the snapshot, if exists, will be restored when running the VM for the first time after the action is done) or not. Change-Id: I9ccbbaf9a4d242255a4ff999e5f08644d45402eb Bug-Url: https://bugzilla.redhat.com/960931 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/SnapshotMapper.java 6 files changed, 31 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/15687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ccbbaf9a4d242255a4ff999e5f08644d45402eb Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0