August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: Remove keys on cleanup after upgrade
by oschreib＠redhat.com 27 Aug '13

27 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: Remove keys on cleanup after upgrade ...................................................................... packaging: setup: Remove keys on cleanup after upgrade Remove engine_id_rsa, apache-ca.pem and apache.key.nopass on cleanup after upgrade from 3.2. Before this change, many other files were removed in such a case, but not these ones. Change-Id: I06a015fa56594997a17ae073b12b0fcab1c11be7 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/legacy/ca.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06a015fa56594997a17ae073b12b0fcab1c11be7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix error message on change DC quota mode
by gchaplik＠redhat.com 27 Aug '13

27 Aug '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix error message on change DC quota mode ...................................................................... webadmin: Fix error message on change DC quota mode When creating a new DC and changing the DC Quota enforcement mode to Audit, no message should be presented. Fixed logic of the message pop up Change-Id: I21e4238979c225b2c6a2a04702c73b50f5c4e8b4 Bug-Url: https://bugzilla.redhat.com/974172 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18588 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21e4238979c225b2c6a2a04702c73b50f5c4e8b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Changed units of Network QoS in UI
by gchaplik＠redhat.com 27 Aug '13

27 Aug '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Changed units of Network QoS in UI ...................................................................... webadmin: Changed units of Network QoS in UI Network QoS 'Burst' property is commonly counted in Megabytes and not Megabits. vdsm API also receives this value in Megabytes. UI was changed (label) to support this convention and tooltip added to point the difference between 'Burst' and 'Average' and 'Peak' fields. Change-Id: I1dd2367b136d547f7f93fdc8a1b76561920ce59a Bug-Url: https://bugzilla.redhat.com/999799 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.java 2 files changed, 13 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1dd2367b136d547f7f93fdc8a1b76561920ce59a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Allowed editing a VNIC when VM image locked
by masayag＠redhat.com 27 Aug '13

27 Aug '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Allowed editing a VNIC when VM image locked ...................................................................... engine: Allowed editing a VNIC when VM image locked This allows updating VNICs while creating a VM from template. Change-Id: Id3fa46642beacd2ecc0c6d2ad2bde05c890d8256 Bug-Url: https://bugzilla.redhat.com/996568 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 13 insertions(+), 24 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3fa46642beacd2ecc0c6d2ad2bde05c890d8256 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: minor cleanup in MigrateVmToServerCommand
by ofrenkel＠redhat.com 27 Aug '13

27 Aug '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: minor cleanup in MigrateVmToServerCommand ...................................................................... core: minor cleanup in MigrateVmToServerCommand - remove var_action and var_type settings which are already set in MigrateVmCommand#setActionMessageParameters - call failCanDoAction instead of having nested if-else statements - move comment that explains a method to be right before the method instead of inside the method body Change-Id: Ic455ae7ba1a38cd8d7e67e4d925d2ce18493227a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java 1 file changed, 15 insertions(+), 16 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic455ae7ba1a38cd8d7e67e4d925d2ce18493227a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove MigrateVmCommand#canMigrateVm
by ofrenkel＠redhat.com 27 Aug '13

27 Aug '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: remove MigrateVmCommand#canMigrateVm ...................................................................... core: remove MigrateVmCommand#canMigrateVm All that MigrateVmCommand#canDoAction was doing was to delegate to canMigrateVm method and canMigrateVm method was not called from anywhere else. Thus, this patch removes the canMigrateVm method and put its body in the canDoAction method instead. InternalMigrateVmCommand is also changed accordingly. Change-Id: If88012b8bdbc7d23ad9350acf207431727e1d51e Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 2 files changed, 11 insertions(+), 13 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If88012b8bdbc7d23ad9350acf207431727e1d51e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup in MigrateVmCommand
by ofrenkel＠redhat.com 27 Aug '13

27 Aug '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: cleanup in MigrateVmCommand ...................................................................... core: cleanup in MigrateVmCommand Extract the code in MigrateVmCommand#perform method which is related only to the parameters initialization to separate methods, to make it shorter and easier to read. This patch also includes other minor refactoring in this class. Change-Id: I138ac8c64e7c0fe70c579e80313b56d4d1d47848 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 42 insertions(+), 52 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I138ac8c64e7c0fe70c579e80313b56d4d1d47848 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[master]: cli: fix date in spec
by mpastern＠redhat.com 27 Aug '13

27 Aug '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: fix date in spec ...................................................................... cli: fix date in spec caused rpm build issues on f19 Change-Id: I86506b3bb581e5af621e3aed1efee1b042377627 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-cli.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86506b3bb581e5af621e3aed1efee1b042377627 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: restapi: Support for gluster hooks added
by oliel＠redhat.com 27 Aug '13

27 Aug '13

Ori Liel has submitted this change and it was merged. Change subject: restapi: Support for gluster hooks added ...................................................................... restapi: Support for gluster hooks added Gluster hooks are deployed during installation of gluster in the servers of a gluster cluster. The ovirt engine polls each of the servers in the cluster and stores information about the gluster hooks - primarily to check if the hook scripts are in sync across servers. This patch adds API support for managing gluster hooks. - api/cluster/{id}/glusterhooks lists all gluster hooks in the cluster along with conflict status - api/cluster/{id}/glusterhooks/{glusterhook:id}|rel=delete resolve missing hook conflict by removing hook script from all servers and engine database - api/cluster/{id}/glusterhooks/{id} show details of a gluster hook actions supported: - enable enables hook in all servers in the cluster - disable disables hook in all servers in the cluster - resolve action.resolutionType = COPY resolve content conflict by copying content from either engine or from one of the servers to all or servers where the hook is missing as applicable (based on parameters) action.resolutionType = ADD resolve missing hook conflict by copying hook stored in engine database to all servers where the hook is missing Change-Id: Ibf9c0299977448e0b50feeed6e38a015c60b86fd Bug-Url: https://bugzilla.redhat.com/970046 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/HookContentType.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/HookStage.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/HookStatus.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/ResolutionType.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ClusterResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterHookResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterHooksResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClustersResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterHookResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterHooksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterHookResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterHooksResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterHookMapper.java 19 files changed, 1,186 insertions(+), 3 deletions(-) Approvals: Ori Liel: Looks good to me, approved Kanagaraj M: Verified -- To view, visit http://gerrit.ovirt.org/18495 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf9c0299977448e0b50feeed6e38a015c60b86fd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Webadmin: Initial Run subsection not present by default at R...
by shavivi＠redhat.com 27 Aug '13

27 Aug '13

Shahar Havivi has submitted this change and it was merged. Change subject: Webadmin: Initial Run subsection not present by default at Run Once dialog ...................................................................... Webadmin: Initial Run subsection not present by default at Run Once dialog Change-Id: I18447e7c317fe8778100437825889e1696cc1609 Bug-Url: https://bugzilla.redhat.com/999879 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18447e7c317fe8778100437825889e1696cc1609 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0