August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: cluster policy dialog - minor fixes
by dfediuck＠redhat.com 28 Aug '13

28 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: webadmin: cluster policy dialog - minor fixes ...................................................................... webadmin: cluster policy dialog - minor fixes * Adding abillity to filter to have no position. * Fixing dnd not disabled while cluster policy is locked. Change-Id: I4698753320fecf24cc0fbf4e95af2c0ea8c57b31 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/panels/PolicyUnitPanel.java 4 files changed, 21 insertions(+), 2 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/18548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4698753320fecf24cc0fbf4e95af2c0ea8c57b31 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: Engine: VMs search by name NPE
by rgolan＠redhat.com 28 Aug '13

28 Aug '13

Roy Golan has submitted this change and it was merged. Change subject: Engine: VMs search by name NPE ...................................................................... Engine: VMs search by name NPE The search is trying to search for OS which is not a string. After commit: 282f87b3b0a96008d87cad21cc48e4d8adcd4cf9 change VmOsType with OS_info Change-Id: I9eb009b6463f33b37984f3f1410e5c47c6159911 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9eb009b6463f33b37984f3f1410e5c47c6159911 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: remove status text column from Volumes tab
by kmayilsa＠redhat.com 28 Aug '13

28 Aug '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: remove status text column from Volumes tab ...................................................................... webadmin: remove status text column from Volumes tab Removed 'Status' text column from the Volumes main tab. Added a tooltip(Up/Down) to Status image. Change-Id: Ia40d69dae246e1ba9797c3ee324a34898d99a909 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusCell.java 2 files changed, 14 insertions(+), 17 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia40d69dae246e1ba9797c3ee324a34898d99a909 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: backend: Fixing log print when vdsm version is not supported...
by oschreib＠redhat.com 28 Aug '13

28 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: backend: Fixing log print when vdsm version is not supported in cluster ...................................................................... backend: Fixing log print when vdsm version is not supported in cluster When adding new host we verify its vdsm version and cluster compatibility as part of HandleVdsVersionCommand. During that we printed the same message for both compatibilities issue (vdsm version and cluster level support). This patch separates the validation part with two different prints. Change-Id: Iacfb3875a0617f978b4453769a0b1c5704282fa5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=974101 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 6 files changed, 29 insertions(+), 23 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacfb3875a0617f978b4453769a0b1c5704282fa5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: fix duplicate values in non operational reasons
by oschreib＠redhat.com 28 Aug '13

28 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: core: fix duplicate values in non operational reasons ...................................................................... core: fix duplicate values in non operational reasons As a result of recent changes, NonOperationalReasom enum contains two entries with duplicated int values, this patch changes them to have unique values. Change-Id: I80ecc00898c05ef80d346fe171bbe08993b148cc Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80ecc00898c05ef80d346fe171bbe08993b148cc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Removed unused variable declaration
by oschreib＠redhat.com 28 Aug '13

28 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: engine: Removed unused variable declaration ...................................................................... engine: Removed unused variable declaration Change-Id: I2d048479f4cd566fc198f0496e2222b26f2575c4 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d048479f4cd566fc198f0496e2222b26f2575c4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Fixing validation of Auth Ssh Port
by oschreib＠redhat.com 28 Aug '13

28 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: webadmin: Fixing validation of Auth Ssh Port ...................................................................... webadmin: Fixing validation of Auth Ssh Port The field's validation was set but without using the getIsValid as part of the general tab validation. Clicking OK forwarded the user to PM page instead of failing the operation. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=987910 Change-Id: Ie5bc99cfeaebd2c76a09ac2255557051626acef2 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5bc99cfeaebd2c76a09ac2255557051626acef2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Blocking port field in edit host popup and refacto...
by oschreib＠redhat.com 28 Aug '13

28 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: webadmin: Blocking port field in edit host popup and refactor its name ...................................................................... webadmin: Blocking port field in edit host popup and refactor its name Was a bug, before we locked the vdsm port (54321) field, instead of the auth port. To avoid such confusions this patch also modifies the name of the field from hostPort to authSshPort. Change-Id: Ic2af8e3168d7ac9688079f6a32edc71d79f997b0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=997542 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 8 files changed, 24 insertions(+), 23 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2af8e3168d7ac9688079f6a32edc71d79f997b0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Using stored VDS.sshUsername instead of default ro...
by oschreib＠redhat.com 28 Aug '13

28 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: webadmin: Using stored VDS.sshUsername instead of default root in reinstall view ...................................................................... webadmin: Using stored VDS.sshUsername instead of default root in reinstall view When loading InstallHost model we launched InstallPopupView filled with root username in the ssh user name area. This patch uses the stored VDS object and places in the username field the SshUsername that was saved during first installation. Change-Id: Ia9870d35f7dbabb102a809d02c356c15dd1bebff Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9870d35f7dbabb102a809d02c356c15dd1bebff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Adding tooltip and style to PublicKey field
by oschreib＠redhat.com 28 Aug '13

28 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: webadmin: Adding tooltip and style to PublicKey field ...................................................................... webadmin: Adding tooltip and style to PublicKey field Change-Id: I6fab16684a9b1bb57587e672ff1ba7fbf7eae40b Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelTextAreaLabelEditor.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 6 files changed, 28 insertions(+), 29 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fab16684a9b1bb57587e672ff1ba7fbf7eae40b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0