August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: UI for cpu shares
by dfediuck＠redhat.com 06 Aug '13

06 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: webadmin: UI for cpu shares ...................................................................... webadmin: UI for cpu shares Added UI for CPU shares. Changed the UI for CPU Pinning topology (was moved to the 'Resource Allocation' tab and added info icon instead of the example panel) Change-Id: I5c975cf521f8aa18d3a6836dee31fd249a8815bb Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java 16 files changed, 194 insertions(+), 36 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c975cf521f8aa18d3a6836dee31fd249a8815bb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: add engine-upgrade-check script
by oschreib＠redhat.com 06 Aug '13

06 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: add engine-upgrade-check script ...................................................................... packaging: setup: add engine-upgrade-check script Change-Id: I9131b405efd26730bc03eac53a765aceb2ce94af Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M ovirt-engine.spec.in A packaging/setup/bin/ovirt-engine-upgrade-check 3 files changed, 143 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9131b405efd26730bc03eac53a765aceb2ce94af Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: Do not enable Gluster in Default cluster
by oschreib＠redhat.com 06 Aug '13

06 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: Do not enable Gluster in Default cluster ...................................................................... packaging: setup: Do not enable Gluster in Default cluster DEFAULT cluster is created during installation of engine. If Application mode is selected as BOTH during installation, DEFAULT cluster will be created with both Gluster and Virt enabled by default. By default only virt will be enabled in DEFAULT cluster. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988453 Change-Id: Ic8b4d15689c730428aad09dd0c981faf5732731d Signed-off-by: Aravinda VK <avishwan(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py M packaging/setup/plugins/ovirt-engine-setup/config/appmode.py 2 files changed, 27 insertions(+), 12 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8b4d15689c730428aad09dd0c981faf5732731d Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Aravinda VK <avishwan(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Add VM.cpuShares attribute to the API
by dfediuck＠redhat.com 06 Aug '13

06 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: restapi: Add VM.cpuShares attribute to the API ...................................................................... restapi: Add VM.cpuShares attribute to the API This patch adds a new argument to the calls related to VM. It is used to set the cpu allocation priority for the given VM. Change-Id: Ieb42d5b132bcf7718f4c8e6162bbbc916ac24b99 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 4 files changed, 22 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb42d5b132bcf7718f4c8e6162bbbc916ac24b99 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add storage validation when plugging an image.
by mlipchuk＠redhat.com 06 Aug '13

06 Aug '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add storage validation when plugging an image. ...................................................................... core: Add storage validation when plugging an image. When a plugging a disk to a VM, the engine should validate that the storage domain that the disk resides on is active. There is no reason to call VDSM if it can't connect to the storage. The validation should be done on plug disk, and also on its derived operation attachDisk. Change-Id: Ieeb2522bc5aa280b9b98ef728737aeeaa82d1263 Bug-Url: https://bugzilla.redhat.com/969767 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotUnPlugDiskFromVmCommandTest.java 4 files changed, 73 insertions(+), 11 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieeb2522bc5aa280b9b98ef728737aeeaa82d1263 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Enhance for loop at import VM.
by mlipchuk＠redhat.com 06 Aug '13

06 Aug '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Enhance for loop at import VM. ...................................................................... core: Enhance for loop at import VM. The for loop in the import VM commands iterates over the volumes of the image, besides the last one. this behaviour is not logic and error prone, all volumes of the image should be set with the same disk id Change-Id: I6f6ca389739143f5102e0ef940fe6fac0164b17d Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17172 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f6ca389739143f5102e0ef940fe6fac0164b17d Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: extract method to ImagesHandler
by mlipchuk＠redhat.com 06 Aug '13

06 Aug '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: extract method to ImagesHandler ...................................................................... core: extract method to ImagesHandler Add a method which returns the activated volume from the image volumes. Change-Id: I7700c28323908128a63910866eddb7dfa4b112fb Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 3 files changed, 8 insertions(+), 9 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17171 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7700c28323908128a63910866eddb7dfa4b112fb Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: apache: remove ovirt-engine-style.css reference
by oschreib＠redhat.com 06 Aug '13

06 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: apache: remove ovirt-engine-style.css reference ...................................................................... packaging: apache: remove ovirt-engine-style.css reference file was removed at 3806a44b33e. Change-Id: Ic0af64ce8ae0d24a3810a976e1ee442c0b355486 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/conf/ovirt-engine-proxy.conf.v2.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0af64ce8ae0d24a3810a976e1ee442c0b355486 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: disable yum packager during remove
by oschreib＠redhat.com 06 Aug '13

06 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: disable yum packager during remove ...................................................................... packaging: setup: disable yum packager during remove we do not need online connection for remove, nor update packages. Change-Id: I3850c7b5febecb7a34dc2e2fceaec41b6ff1228d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/bin/ovirt-engine-remove 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3850c7b5febecb7a34dc2e2fceaec41b6ff1228d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fix updating of "shareable" property for direct LUNs
by derez＠redhat.com 06 Aug '13

06 Aug '13

Daniel Erez has submitted this change and it was merged. Change subject: engine: Fix updating of "shareable" property for direct LUNs ...................................................................... engine: Fix updating of "shareable" property for direct LUNs Currently the update of "shareable" property for direct LUNs is broken due to ClassCastException as described in BZ993117. Change-Id: Ie7b0e7c53b7a877b850106f8ea0f99026cee96e3 Bug-Url: https://bugzilla.redhat.com/993117 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7b0e7c53b7a877b850106f8ea0f99026cee96e3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0