August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: engine-setup - add vdsm stage
by oschreib＠redhat.com 06 Aug '13

06 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-setup - add vdsm stage ...................................................................... packaging: engine-setup - add vdsm stage Adds vdsm stage in order to support ovirt live plugin after aio run Change-Id: I03b42e98a3d31b76899837e875de8e3d6dc68774 Signed-off-by: Ohad Basan <obasan(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/all-in-one/vdsm.py 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03b42e98a3d31b76899837e875de8e3d6dc68774 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: fix broken tests
by tjelinek＠redhat.com 06 Aug '13

06 Aug '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: fix broken tests ...................................................................... frontend: fix broken tests Some tests expected the WINDOWS_VM_NAME_MAX_LIMIT and NON_WINDOWS_VM_NAME_MAX_LIMIT to be set, but they was set from the AsyncDataProvider which is not inited in tests. Added fallback to the default values. Change-Id: Ia570c7e06f0c411025ae0a694225ccac83250d3f Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia570c7e06f0c411025ae0a694225ccac83250d3f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add mom policy update command
by mkolesni＠redhat.com 06 Aug '13

06 Aug '13

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add mom policy update command ...................................................................... core: Add mom policy update command Add a command to allow update of mom policy on host. Change-Id: I64350c17f182c1dd0ba1d06130e5d56019b32fc9 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateMomPolicyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 13 files changed, 117 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved ofri masad: Verified -- To view, visit http://gerrit.ovirt.org/17379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64350c17f182c1dd0ba1d06130e5d56019b32fc9 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: policy unit crud store proc
by lhornyak＠redhat.com 06 Aug '13

06 Aug '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: policy unit crud store proc ...................................................................... core: policy unit crud store proc Insert and Update policy unit db store procedures with tests Change-Id: I8838ae56c2ed927428c54e0319865425c54f51d7 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/PolicyUnitDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PolicyUnitDaoTest.java M packaging/dbscripts/policy_unit_sp.sql 4 files changed, 69 insertions(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8838ae56c2ed927428c54e0319865425c54f51d7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: vm name max length validation hardcoded
by tjelinek＠redhat.com 06 Aug '13

06 Aug '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: vm name max length validation hardcoded ...................................................................... userportal,webadmin: vm name max length validation hardcoded There is a config value MaxVmNameLengthWindows and MaxVmNameLengthNonWindows for VM name lengths, but the frontend ignored this config values and had the lenghts hardcoded. Change-Id: I08eae6dac69963f7c604cf80bba423f0987a199c Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08eae6dac69963f7c604cf80bba423f0987a199c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove FormatException
by amureini＠redhat.com 06 Aug '13

06 Aug '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove FormatException ...................................................................... core: Remove FormatException FormatException was introduced in the very first git commit of oVirt, and has not been used since. It's safe to assume that it never will, and can safely be removed, along with any code attempting to catch it. Change-Id: Ie3e4351aab1f51bbc8ae6b28892ff822d7fa4467 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/FormatException.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 2 files changed, 3 insertions(+), 24 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16812 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3e4351aab1f51bbc8ae6b28892ff822d7fa4467 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Change in Network QoS UI
by gchaplik＠redhat.com 06 Aug '13

06 Aug '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Change in Network QoS UI ...................................................................... webadmin: Change in Network QoS UI Change in the network QoS UI. Setting default values to all fields Change-Id: I7808be49c10ff4bf3e566baa2667ac58a1dbc9ac Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkQoSModel.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 5 files changed, 58 insertions(+), 60 deletions(-) Approvals: ofri masad: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7808be49c10ff4bf3e566baa2667ac58a1dbc9ac Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: codegen: allow xml types as container key
by mpastern＠redhat.com 06 Aug '13

06 Aug '13

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: allow xml types as container key ...................................................................... codegen: allow xml types as container key Change-Id: Id20db54da97ae101b19f0181c23f8450a341a175 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/utils/parsehelper.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id20db54da97ae101b19f0181c23f8450a341a175 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: codegen: compile generated sources
by mpastern＠redhat.com 06 Aug '13

06 Aug '13

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: compile generated sources ...................................................................... codegen: compile generated sources compile generated sources so the changes will be visible to the consuming code that already loaded this module Change-Id: Ic90104ef9b86f6362a749246be6c87b1a8146577 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/codegen/rsdl/rsdlcodegen.py M src/codegen/xsd/xsdcodegen.py 2 files changed, 14 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic90104ef9b86f6362a749246be6c87b1a8146577 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: fix login error message
by derez＠redhat.com 05 Aug '13

05 Aug '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal,webadmin: fix login error message ...................................................................... userportal,webadmin: fix login error message - Fixed issue where error message on login failure wouldn't be translated properly. Change-Id: I186daf4b828e7f546c470b7cd97c792fe486203e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=991042 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I186daf4b828e7f546c470b7cd97c792fe486203e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0