September 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Improve CommandsFactory exception logging
by yzaslavs＠redhat.com 25 Sep '13

25 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Improve CommandsFactory exception logging ...................................................................... core: Improve CommandsFactory exception logging Change-Id: I5fe9337ca429574d99d9971e7c59219cf2dc7405 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fe9337ca429574d99d9971e7c59219cf2dc7405 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Removed dead code
by masayag＠redhat.com 24 Sep '13

24 Sep '13

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Removed dead code ...................................................................... webadmin: Removed dead code Was there originally to enable removing a VNIC if hotplug was available, but then the removal was disabled to make users explicitly unplug VNIC first. The code stayed there, some of it was removed due to findbugs findings but some was left. Change-Id: I20391d81e8bdb439191f1b47e0b8825fbf6f5e4e Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java 1 file changed, 0 insertions(+), 19 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20391d81e8bdb439191f1b47e0b8825fbf6f5e4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Attempt to add a 3.2 host into 3.3 env fails but t...
by iheim＠redhat.com 24 Sep '13

24 Sep '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Attempt to add a 3.2 host into 3.3 env fails but the host cannot be removed ...................................................................... webadmin: Attempt to add a 3.2 host into 3.3 env fails but the host cannot be removed When a 3.2 host is added to 3.3 env the server returns NonOperationalReason___CLUSTER_VERSION_INCOMPATIBLE_WITH_CLUSTER message. Since this message is not available in the frontend there is an exception thrown when a user clicks on the row for the host. So the row is not selected resulting in the action buttons not being activated. This patch adds a new message to LocalizedEnums Change-Id: Ib9763a444cb4c96d407e7e8bee55b72bccaff89f Bug-Url: https://bugzilla.redhat.com/1004675 Signed-off-by: Ravi Nori <rnori(a)redhat.com> Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9763a444cb4c96d407e7e8bee55b72bccaff89f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Fix NPE in UpdateVdsGroupCommand
by iheim＠redhat.com 24 Sep '13

24 Sep '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Fix NPE in UpdateVdsGroupCommand ...................................................................... engine: Fix NPE in UpdateVdsGroupCommand Fixed an NPE when updating a cluster Change-Id: Ibc2fd532e4955d9c2d4632ad8d5c2f47b6615838 Bug-Url: https://bugzilla.redhat.com/1011435 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc2fd532e4955d9c2d4632ad8d5c2f47b6615838 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: UX: fix typos
by sbonazzo＠redhat.com 24 Sep '13

24 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: UX: fix typos ...................................................................... UX: fix typos Fixed some typos left around. Bug-Url: https://bugzilla.redhat.com/1010889 Change-Id: Ib8ee2968013636e8ba7471e1b26b9788c3c5f54a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/cpu.py M src/plugins/ovirt-hosted-engine-setup/vm/image.py M src/plugins/ovirt-hosted-engine-setup/vm/memory.py 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8ee2968013636e8ba7471e1b26b9788c3c5f54a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Attempt to add a 3.2 host into 3.3 env fails but t...
by tnisan＠redhat.com 24 Sep '13

24 Sep '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Attempt to add a 3.2 host into 3.3 env fails but the host cannot be removed ...................................................................... webadmin: Attempt to add a 3.2 host into 3.3 env fails but the host cannot be removed In addition to the change I407154df67d51f28117f7aaf51f8030e39934678 the constant should also be added to LocalizedEnums.java in order to fix the bug correctly Change-Id: Iae24a99ea6b7f6df5586f638aefabdd20164e82f Bug-Url: https://bugzilla.redhat.com/1004675 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae24a99ea6b7f6df5586f638aefabdd20164e82f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: vdsm: vm.conf: migrate boot to bootOrder
by sbonazzo＠redhat.com 24 Sep '13

24 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm: vm.conf: migrate boot to bootOrder ...................................................................... vdsm: vm.conf: migrate boot to bootOrder migrated boot keyword used previously at VM configuration level to the new specification of bootOrder now used at devices specification level. Change-Id: I2f5cb3bde2bcb48d8e943201c3447b572835d5ef Bug-Url: https://bugzilla.redhat.com/1011031 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/os_install.py M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py M templates/vm.conf.in 3 files changed, 16 insertions(+), 11 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f5cb3bde2bcb48d8e943201c3447b572835d5ef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: vdsm: vm.conf: migrate boot to bootOrder
by sbonazzo＠redhat.com 24 Sep '13

24 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm: vm.conf: migrate boot to bootOrder ...................................................................... vdsm: vm.conf: migrate boot to bootOrder migrated boot keyword used previously at VM configuration level to the new specification of bootOrder now used at devices specification level. Change-Id: I2f5cb3bde2bcb48d8e943201c3447b572835d5ef Bug-Url: https://bugzilla.redhat.com/1011031 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/os_install.py M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py M templates/vm.conf.in 3 files changed, 16 insertions(+), 11 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/19510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f5cb3bde2bcb48d8e943201c3447b572835d5ef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.2]: log: default logging to timestamped files
by sbonazzo＠redhat.com 24 Sep '13

24 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: log: default logging to timestamped files ...................................................................... log: default logging to timestamped files Log messages to timestamped files as default, avoiding to overwrite existing ones. The default location of the logs was changed, to improve /var/log/ovirt-engine sanity. /var/log/ovirt-engine -> /var/log/ovirt-engine/ovirt-iso-uploader A log rotation was introduced in order to compress old logs. Bug-Url: https://bugzilla.redhat.com/1009115 Change-Id: I55f8d7061ea3a2f112ca602a954b87fec705baa8 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M .gitignore M configure.ac M ovirt-iso-uploader.spec.in M src/Makefile.am M src/__main__.py A src/config.py.in A src/logrotate.d/Makefile.am A src/logrotate.d/ovirt-iso-uploader.in 8 files changed, 104 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/19392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55f8d7061ea3a2f112ca602a954b87fec705baa8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: log: default logging to timestamped files
by sbonazzo＠redhat.com 24 Sep '13

24 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: log: default logging to timestamped files ...................................................................... log: default logging to timestamped files Log messages to timestamped files as default, avoiding to overwrite existing ones. The default location of the logs was changed, to improve /var/log/ovirt-engine sanity. /var/log/ovirt-engine -> /var/log/ovirt-engine/ovirt-log-collector A log rotation was introduced in order to compress old logs. Bug-Url: https://bugzilla.redhat.com/1009116 Change-Id: If180bb3c425d94449236147cddc17c504bf602b7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M .gitignore M configure.ac M ovirt-log-collector.spec.in M src/Makefile.am M src/__main__.py M src/config.py.in.in A src/logrotate.d/Makefile.am A src/logrotate.d/ovirt-log-collector.in 8 files changed, 85 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/19405 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If180bb3c425d94449236147cddc17c504bf602b7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0