September 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix exception handling
by yzaslavs＠redhat.com 29 Sep '13

29 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix exception handling ...................................................................... core: Fix exception handling Explicit exception handling should be done Change-Id: I455378d79e2ee2232f96dc18c10b010f954ca3be Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/BatchProcedureExecutionConnectionCallback.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/19352 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I455378d79e2ee2232f96dc18c10b010f954ca3be Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Prevent NPE with cobertura
by iheim＠redhat.com 28 Sep '13

28 Sep '13

Itamar Heim has submitted this change and it was merged. Change subject: core: Prevent NPE with cobertura ...................................................................... core: Prevent NPE with cobertura The NetworkDaoDbFacadeImpl contains an abstract row mapper and then two derived ones, and all of them, including the abstract one contain a singleton. The singleton in the abstract one is never used, and it causes a NPE if used. Some tools, like cobertura, generate code that uses all the fields, and thus reveal this hidden NPE. This patch just removes the unused field. Change-Id: I811fe567010037fd12e4deeb517fb3396c724b53 Bug-Url: https://bugzilla.redhat.com/1012455 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19599 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I811fe567010037fd12e4deeb517fb3396c724b53 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: set multi monitor only when compatible on import
by iheim＠redhat.com 28 Sep '13

28 Sep '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: set multi monitor only when compatible on import ...................................................................... engine: set multi monitor only when compatible on import Set true only for windows on 3.3 and higher, Also fix tests. Change-Id: I8a5ae4a6367fd5e4184f42b514f9be6e42879c26 Bug-Url: https://bugzilla.redhat.com/1007784 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java 3 files changed, 10 insertions(+), 3 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a5ae4a6367fd5e4184f42b514f9be6e42879c26 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[master]: Packaging: Add the missing dependencies
by bazulay＠redhat.com 28 Sep '13

28 Sep '13

Barak Azulay has submitted this change and it was merged. Change subject: Packaging: Add the missing dependencies ...................................................................... Packaging: Add the missing dependencies automake and pkg-confg are needed when building ovirt-guest-agent in a fresh Ubuntu environment. This patch also split each dependency to separated lines. The debhelper is a boilerplate so leave it at the first line. The other lines are custom dependencies so sort them to make it easier to maintain. Change-Id: I90f86100946c5b60cc816e664a2857cad5b4b0f5 Signed-off-by: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com> --- M debian/control 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90f86100946c5b60cc816e664a2857cad5b4b0f5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: build: ovirt-hosted-engine-setup-1.0.0-0.5.beta1
by sbonazzo＠redhat.com 27 Sep '13

27 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-1.0.0-0.5.beta1 ...................................................................... build: ovirt-hosted-engine-setup-1.0.0-0.5.beta1 Change-Id: Ia904631a88873efdfd63299ebf4f19a258e60457 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 12 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia904631a88873efdfd63299ebf4f19a258e60457 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: require answer file on additional hosts
by sbonazzo＠redhat.com 27 Sep '13

27 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: require answer file on additional hosts ...................................................................... packaging: setup: require answer file on additional hosts Require the use of an answer file on additional hosts deployment. Allows to fetch the answer file from the first host providing its address and root password. Change-Id: Ie8fd38828422c52c416ad3125c2e39193956d74f Bug-Url: https://bugzilla.redhat.com/1007422 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/core/Makefile.am M src/plugins/ovirt-hosted-engine-setup/core/__init__.py A src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py 5 files changed, 292 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8fd38828422c52c416ad3125c2e39193956d74f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: require answer file on additional hosts
by sbonazzo＠redhat.com 27 Sep '13

27 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: require answer file on additional hosts ...................................................................... packaging: setup: require answer file on additional hosts Require the use of an answer file on additional hosts deployment. Allows to fetch the answer file from the first host providing its address and root password. Change-Id: Ie8fd38828422c52c416ad3125c2e39193956d74f Bug-Url: https://bugzilla.redhat.com/1007422 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/core/Makefile.am M src/plugins/ovirt-hosted-engine-setup/core/__init__.py A src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py 5 files changed, 292 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Greg Padgett: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/19577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8fd38828422c52c416ad3125c2e39193956d74f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: validate host id
by sbonazzo＠redhat.com 27 Sep '13

27 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: validate host id ...................................................................... packaging: setup: validate host id Added host id validation on additional hosts setup. Requires: http://gerrit.ovirt.org/19140 Rebased the code for being compatible with http://gerrit.ovirt.org/19140 Bug-Url: https://bugzilla.redhat.com/1012417 Change-Id: I2487abfe1f722cb60e6f7c2a8daa4a81fb654bfd Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/bin/hosted-engine.in M src/ovirt_hosted_engine_setup/constants.py M src/ovirt_hosted_engine_setup/util.py M src/plugins/ovirt-hosted-engine-setup/sanlock/lockspace.py M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 5 files changed, 124 insertions(+), 33 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2487abfe1f722cb60e6f7c2a8daa4a81fb654bfd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: validate host id
by sbonazzo＠redhat.com 27 Sep '13

27 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: validate host id ...................................................................... packaging: setup: validate host id Added host id validation on additional hosts setup. Requires: http://gerrit.ovirt.org/19140 Rebased the code for being compatible with http://gerrit.ovirt.org/19140 Bug-Url: https://bugzilla.redhat.com/1012417 Change-Id: I2487abfe1f722cb60e6f7c2a8daa4a81fb654bfd Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/bin/hosted-engine.in M src/ovirt_hosted_engine_setup/constants.py M src/ovirt_hosted_engine_setup/util.py M src/plugins/ovirt-hosted-engine-setup/sanlock/lockspace.py M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 5 files changed, 124 insertions(+), 33 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Greg Padgett: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/19171 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2487abfe1f722cb60e6f7c2a8daa4a81fb654bfd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: client, broker: method to read agent metadata without broker
by gpadgett＠redhat.com 27 Sep '13

27 Sep '13

Greg Padgett has submitted this change and it was merged. Change subject: client, broker: method to read agent metadata without broker ...................................................................... client, broker: method to read agent metadata without broker Provide a method usable by the ha setup application which will read and parse the ha metadata from the domain without requiring the ha broker. The initial planned use for this is to have setup verify host_id uniqueness during setup before starting the ha daemons. Change-Id: I51612715eee18a488e7d1f7942f0891e35b1fc62 Bug-Url: https://bugzilla.redhat.com/1012417 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/broker/storage_broker.py M ovirt_hosted_engine_ha/client/client.py 2 files changed, 47 insertions(+), 8 deletions(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51612715eee18a488e7d1f7942f0891e35b1fc62 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0