January 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: spec: use wildcards to split into setup groups
by sbonazzo＠redhat.com 14 Jan '14

14 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: use wildcards to split into setup groups ...................................................................... packaging: spec: use wildcards to split into setup groups Change-Id: I3d45564acb2300ce799af921f34ad6348aa1869e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 4 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d45564acb2300ce799af921f34ad6348aa1869e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: spec: remove legacy utilities
by sbonazzo＠redhat.com 14 Jan '14

14 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: remove legacy utilities ...................................................................... packaging: spec: remove legacy utilities Change-Id: I2ce5105a5abded44dead0ed037a9e0816aefcdcd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M ovirt-engine.spec.in D packaging/bin/engine-check-update.sh D packaging/bin/engine-upgrade.sh 4 files changed, 0 insertions(+), 28 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23159 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ce5105a5abded44dead0ed037a9e0816aefcdcd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: frontend: Fix Spice ActiveX for IE 11
by iheim＠redhat.com 14 Jan '14

14 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: frontend: Fix Spice ActiveX for IE 11 ...................................................................... frontend: Fix Spice ActiveX for IE 11 This patch provides quick fix of SPICE plugin invocation for Internet Explorer 11. Since IE 11 doesn't report itself as MSIE anymore and doesn't support old IE DOM API, couple of small adjustments were needed. Change-Id: I14760ddf688a29eb1c5ef896c20e194fdc7ed8ca Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1052873 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/ClientAgentType.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ConsoleUtils.java 4 files changed, 40 insertions(+), 12 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14760ddf688a29eb1c5ef896c20e194fdc7ed8ca Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: bin: destroy VM on vm-start if it's down
by sbonazzo＠redhat.com 14 Jan '14

14 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: bin: destroy VM on vm-start if it's down ...................................................................... bin: destroy VM on vm-start if it's down Bug-Url: https://bugzilla.redhat.com/1024710 Change-Id: I49aa7b1cdd8eac6e99852dc02af2e888023f73f3 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/bin/hosted-engine.in 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/23219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49aa7b1cdd8eac6e99852dc02af2e888023f73f3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Extract nic labels check into a method
by mkolesni＠redhat.com 14 Jan '14

14 Jan '14

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Extract nic labels check into a method ...................................................................... engine: Extract nic labels check into a method The nic is recurrently being checked whether it is labeled. The same check is extracted into a method. Change-Id: Icef35e6a0f8a1334e871d2bdc718fb0eb1b9ece6 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetNetworkLabelsByHostNicIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/LabelNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UnlabelNicCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java 7 files changed, 22 insertions(+), 10 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/23193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icef35e6a0f8a1334e871d2bdc718fb0eb1b9ece6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Extract network label check into a method
by masayag＠redhat.com 14 Jan '14

14 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extract network label check into a method ...................................................................... engine: Extract network label check into a method The network is recurrently being checked whether it is labeled. The same check is extracted into its own method. Change-Id: I9e2370e085dbfa6aa4a26c0eb1eaecc2096981ff Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetNetworkLabelsByNetworkIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java 8 files changed, 21 insertions(+), 8 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e2370e085dbfa6aa4a26c0eb1eaecc2096981ff Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Adjust host networks when cluster changes
by masayag＠redhat.com 14 Jan '14

14 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Adjust host networks when cluster changes ...................................................................... engine: Adjust host networks when cluster changes When moving a host between clusters, the labeled host's networks should be updated by the assignment of those labeled network to the cluster: - Cluster-assigned labeled networks should be configured on the hosts if a nic is labeled with those labels - Labeled networks which were assigned to the host nics and not assigned to the target cluster should be removed from the host. Change-Id: I5fa6e324c2833366a5fb34db9d2d754426dce316 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 165 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23191 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fa6e324c2833366a5fb34db9d2d754426dce316 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[master]: agent: handle failures on Windows' write requests.
by vfeenstr＠redhat.com 14 Jan '14

14 Jan '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: agent: handle failures on Windows' write requests. ...................................................................... agent: handle failures on Windows' write requests. Windows' virtio-serial driver behavior was changed so a write request when the host is not connected results in immediate return with an error. Change-Id: I28ca3c1115f6b18295a29d1f87bf3144c00759e1 Signed-off-by: Gal Hammer <ghammer(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1026474 --- M ovirt-guest-agent/WinFile.py 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28ca3c1115f6b18295a29d1f87bf3144c00759e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: minor cleanup in ImportVmParameters
by ofrenkel＠redhat.com 14 Jan '14

14 Jan '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: minor cleanup in ImportVmParameters ...................................................................... core: minor cleanup in ImportVmParameters Change-Id: I9fda6ad505974414e42f8550d4be90fb96aaa367 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmParameters.java 1 file changed, 17 insertions(+), 17 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fda6ad505974414e42f8550d4be90fb96aaa367 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fixed bond-related flows in Setup Networks
by lvernia＠redhat.com 14 Jan '14

14 Jan '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Fixed bond-related flows in Setup Networks ...................................................................... webadmin: Fixed bond-related flows in Setup Networks Previously the free bonds on a host were queried every time the Setup Networks dialog was redrawn, where they could in fact only change when backend data was retrieved. Moreover, the computation of the next free bond name was performed by mistake several times whenever the dialog was redrawn, instead of just once. Change-Id: I9eacb27404eca28bb890973545f08fec9b983c4e Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 17 insertions(+), 14 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9eacb27404eca28bb890973545f08fec9b983c4e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0