January 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Use right command when updating cluster network
by lvernia＠redhat.com 14 Jan '14

14 Jan '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Use right command when updating cluster network ...................................................................... webadmin: Use right command when updating cluster network Instead of calling AttachNetworkToVdsGroup, UpdateNetworkOnCluster is now called in cases where fitting. Change-Id: I503a277cdcba548e1c98983306511dbff7cc07bb Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java 3 files changed, 30 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I503a277cdcba548e1c98983306511dbff7cc07bb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Removed recursion for readability's sake
by lvernia＠redhat.com 14 Jan '14

14 Jan '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Removed recursion for readability's sake ...................................................................... webadmin: Removed recursion for readability's sake The attach and detach commands were being run in parallel, so that when both terminate the dialog is closed and the source tab is refreshed. However, this was implemented in a bizarre recursion which wasn't trivial to follow. Hopefully it is more readable now. Change-Id: I4cb3238dbc82cbf8f41d9bf93889649f8d021f54 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java 1 file changed, 34 insertions(+), 29 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cb3238dbc82cbf8f41d9bf93889649f8d021f54 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Added overload for Frontend.runMultipleAction()
by lvernia＠redhat.com 14 Jan '14

14 Jan '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Added overload for Frontend.runMultipleAction() ...................................................................... webadmin: Added overload for Frontend.runMultipleAction() This overload doesn't allows to pass a callback, but doesn't force to pass state (where often the one that does is invoked with null). Change-Id: I18f4cf8b5a1fac4ea7bcf41c88a8ada55b81705d Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18f4cf8b5a1fac4ea7bcf41c88a8ada55b81705d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Extracted common code in manage cluster networks
by lvernia＠redhat.com 14 Jan '14

14 Jan '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Extracted common code in manage cluster networks ...................................................................... webadmin: Extracted common code in manage cluster networks Code was essentially duplicated in both ClusterNetworkListModel and NetworkClusterListModel, extracted it into the ClusterNetworkManageModel for maintainability. Change-Id: Ifa634f7d8011c25de7b1937984d4ec3627068b31 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkClusterListModel.java 4 files changed, 136 insertions(+), 237 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22903 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa634f7d8011c25de7b1937984d4ec3627068b31 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Update network label GUI field
by lvernia＠redhat.com 14 Jan '14

14 Jan '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Update network label GUI field ...................................................................... webadmin: Update network label GUI field Moved it from the provider section in the Add/Edit Network dialog, as now it has significance for an internal network as well. Changed it to be a suggest box instead of a text box, where in case the network is internal, the existing labels in the DC are suggested. Change-Id: Ib0ed563897fd1d7eb4acc9ff322373132f01f8c3 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml 6 files changed, 68 insertions(+), 17 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0ed563897fd1d7eb4acc9ff322373132f01f8c3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: prevent potential npe in VmConfigurationHelper
by derez＠redhat.com 13 Jan '14

13 Jan '14

Daniel Erez has submitted this change and it was merged. Change subject: core: prevent potential npe in VmConfigurationHelper ...................................................................... core: prevent potential npe in VmConfigurationHelper SnapshotVmConfigurationHelper -> markImagesIllegalIfNotInDb: avoid accessing imagesInDbMap when null. Change-Id: I75087440316cdc670552a25a9f2dd052b5573ed8 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotVmConfigurationHelper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75087440316cdc670552a25a9f2dd052b5573ed8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove unused members from query test
by derez＠redhat.com 13 Jan '14

13 Jan '14

Daniel Erez has submitted this change and it was merged. Change subject: core: remove unused members from query test ...................................................................... core: remove unused members from query test Remove unused members from GetVmConfigurationBySnapshotQueryTest. Change-Id: I66f3dfa585b34e8526bb3b08455e47aff3fb8b05 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQueryTest.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66f3dfa585b34e8526bb3b08455e47aff3fb8b05 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix tree view items sorting
by derez＠redhat.com 13 Jan '14

13 Jan '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: fix tree view items sorting ...................................................................... webadmin: fix tree view items sorting Fixed items in the left tree being not sorted under each DC. The fix applies to: storage domains, networks and clusters. Change-Id: Icea17fd037ea4c97cc9a9976eda869b73e489f21 Bug-Url: https://bugzilla.redhat.com/1045380 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java 2 files changed, 29 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icea17fd037ea4c97cc9a9976eda869b73e489f21 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: optional disks list for snapshot restore
by derez＠redhat.com 13 Jan '14

13 Jan '14

Daniel Erez has submitted this change and it was merged. Change subject: restapi: optional disks list for snapshot restore ...................................................................... restapi: optional disks list for snapshot restore BackendSnapshotResource -> restore: set parameters' disks list when needed (doAdd method). Feature: http://www.ovirt.org/Features/Single_Disk_Snapshot Change-Id: I82ed06edf8c82522585d78c02953cae6831b3a4a Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotResource.java 3 files changed, 6 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82ed06edf8c82522585d78c02953cae6831b3a4a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: optional disks list in create snapshot
by derez＠redhat.com 13 Jan '14

13 Jan '14

Daniel Erez has submitted this change and it was merged. Change subject: restapi: optional disks list in create snapshot ...................................................................... restapi: optional disks list in create snapshot BackendSnapshotsResource: * set parameters' disks list when needed (doAdd method). * added mapDisks method. Feature: http://www.ovirt.org/Features/Single_Disk_Snapshot Change-Id: Idabf1b152136ec92bb703903ba40e695be4d57aa Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotsResource.java 2 files changed, 21 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idabf1b152136ec92bb703903ba40e695be4d57aa Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0