January 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Extract getVlanDevice() to NetworkParametersBuilder
by masayag＠redhat.com 14 Jan '14

14 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extract getVlanDevice() to NetworkParametersBuilder ...................................................................... engine: Extract getVlanDevice() to NetworkParametersBuilder The method could be used by other parameter builders, therefore it should moved to the base class. Change-Id: Id3792ef68ac28bd901005642ae0f58dfd9930c1b Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java 2 files changed, 23 insertions(+), 22 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3792ef68ac28bd901005642ae0f58dfd9930c1b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Extract network creation logic into method
by masayag＠redhat.com 14 Jan '14

14 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extract network creation logic into method ...................................................................... engine: Extract network creation logic into method The network creation logic can and will be reused. For that purpose it is being extracted into a base class. Change-Id: I18c1992c14603e5f00d4b7e26b9d27100e8ccf33 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/LabelNicCommand.java 2 files changed, 24 insertions(+), 7 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18c1992c14603e5f00d4b7e26b9d27100e8ccf33 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Support labels on host nics
by masayag＠redhat.com 14 Jan '14

14 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Support labels on host nics ...................................................................... restapi: Support labels on host nics Adding support for labels on host nic level. The support actions for labels are GET, POST and DELETE done via: /api/hosts/{host:id}/nics/{nic:id}/labels /api/hosts/{host:id}/nics/{nic:id}/labels/{label:id} See: http://www.ovirt.org/Features/NetworkLabels#REST Change-Id: I127c77382f0a4790d7c9ba40d77577e941e51919 Bug-Url: https://bugzilla.redhat.com/1040586 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/HostNicResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicLabelResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicLabelsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicLabelResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicLabelsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResourceTest.java 11 files changed, 498 insertions(+), 5 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I127c77382f0a4790d7c9ba40d77577e941e51919 Gerrit-PatchSet: 29 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Support labels on networks
by masayag＠redhat.com 14 Jan '14

14 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Support labels on networks ...................................................................... restapi: Support labels on networks Adding support for labels on network level. Currently the engine supports a single label per network. The support actions for labels are GET, POST and DELETE, done via: /api/networks/{network:id}/labels /api/networks/{network:id}/labels/{label:id} /api/datacenters/{datacenter:id}/networks/{network:id}/labels /api/datacenters/{datacenter:id}/networks/{network:id}/labels/{label:id} An example of the labels model: <network> ... <labels> <label id="lbl1" /> </labels> ... <network> See: http://www.ovirt.org/Features/NetworkLabels#REST Change-Id: Id8f6f18c6195a2822d87ad626f034cefe43847b4 Bug-Url: https://bugzilla.redhat.com/1040586 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/LabelResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/LabelsResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/NetworkResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworkLabelResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworkLabelsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworkResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendNetworkLabelResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendNetworkLabelsResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/LabelMapper.java 14 files changed, 676 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22804 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8f6f18c6195a2822d87ad626f034cefe43847b4 Gerrit-PatchSet: 34 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix rendering issue in DetailsRenderer
by kmayilsa＠redhat.com 13 Jan '14

13 Jan '14

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: fix rendering issue in DetailsRenderer ...................................................................... webadmin: fix rendering issue in DetailsRenderer Widgets like MemorySizeTextBoxLabel are inherited from ValueBoxBase. ValueBoxBase uses input-text html element to display the data as opposed to div/innerHtml used by ValueLabel. So instead of taking the innerHtml from these fields, DetailsRenderer will use getValue() to get the data. Change-Id: I244819f17be801f8ba8c5c709e5127bd66567c81 Bug-Url: https://bugzilla.redhat.com/1049892 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/DetailsRenderer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I244819f17be801f8ba8c5c709e5127bd66567c81 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin, userportal: Improve TextBoxLabelBase
by vszocs＠redhat.com 13 Jan '14

13 Jan '14

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Improve TextBoxLabelBase ...................................................................... webadmin,userportal: Improve TextBoxLabelBase This patch modifies constructor: public TextBoxLabelBase(Renderer<T> renderer) ... to become: public TextBoxLabelBase(Renderer<? super T> renderer) ... in order to support broader range of renderers, i.e. renderer for T or any supertype of T, up to Object. Assuming GWT compiler discards generic type information, in the worst case, things will blow up on bad method signature. However, TextBoxLabelBase extends ValueBoxBase which uses provided renderer like so: public void setValue(T value, boolean fireEvents) { ... setText(renderer.render(value)); ... } and the above renderer usage should be safe even when using Renderer<? super T> instead of just Renderer<T> at runtime. (Makes me wonder why GWT ValueBoxBase doesn't work with Renderer<? super T> just like GWT ValueLabel.) Change-Id: Ie691685ec6e9e1830da1457a0747901ba833be5d Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/TextBoxLabelBase.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/DetailsTextBoxLabel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/NullableNumberTextBoxLabel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/DetailsRenderer.java 4 files changed, 18 insertions(+), 13 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22236 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie691685ec6e9e1830da1457a0747901ba833be5d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add type to instantiated hash map
by masayag＠redhat.com 13 Jan '14

13 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add type to instantiated hash map ...................................................................... engine: Add type to instantiated hash map Change-Id: Iadf7c2f17f68d266021f4d7b2f43bcdea5ccb2d8 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23217 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadf7c2f17f68d266021f4d7b2f43bcdea5ccb2d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: fix remove host when host is not part of cluster
by ofrenkel＠redhat.com 13 Jan '14

13 Jan '14

Omer Frenkel has submitted this change and it was merged. Change subject: gluster: fix remove host when host is not part of cluster ...................................................................... gluster: fix remove host when host is not part of cluster VDSM in hosts with compatitbility version 3.3(or less) doesn't return appropriate error status(GlusterHostIsNotPartOfCluster) during the host remove if the operation is failed because the host which is being removed is not part of the gluster-cluster. The Host can be present in engine but not in the actual gluster-cluster if the host installation is failed. This issue is now fixed by verifying the peer list and remove the host if the host is not found in the list. Change-Id: I785beb895f0fb72bc486055c666936073b5a5d59 Bug-Url: https://bugzilla.redhat.com/1050135 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java 3 files changed, 82 insertions(+), 48 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23152 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I785beb895f0fb72bc486055c666936073b5a5d59 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin, core: Prevent arch mismatches in the FE
by rgolan＠redhat.com 13 Jan '14

13 Jan '14

Roy Golan has submitted this change and it was merged. Change subject: webadmin, core: Prevent arch mismatches in the FE ...................................................................... webadmin, core: Prevent arch mismatches in the FE This patch introduces some changes in the frontend in order to prevent the user from making mistakes and receive errors from the backend commands. These changes include: * Show only CPUs compatible with the cluster's current CPU when editing clusters; * Show only clusters with the same architecture as the host when editing hosts; Change-Id: I0033c399061108c4495029ae2bca3f62e75fac68 Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> Signed-off-by: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetHostArchitectureQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsClusterEmptyQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M packaging/dbscripts/vds_groups_sp.sql 9 files changed, 223 insertions(+), 23 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0033c399061108c4495029ae2bca3f62e75fac68 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-3.3]: packaging: changed minor version to 3.3.3
by ydary＠redhat.com 13 Jan '14

13 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: changed minor version to 3.3.3 ...................................................................... packaging: changed minor version to 3.3.3 Change-Id: Ibad254f98bd8a086307495e4a09dece68b5cfb00 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M pom.xml M reports/jars/ChartsCustomizers/pom.xml M reports/jars/CustomOvirtReportsQueryManipulator/pom.xml M reports/jars/EngineAuthentication/pom.xml M reports/jars/ReportsLineBarChartTheme/pom.xml M reports/jars/ReportsPieChartTheme/pom.xml M reports/jars/WebadminLineBarChartTheme/pom.xml M reports/jars/pom.xml M reports/pom.xml M version.mak 10 files changed, 18 insertions(+), 18 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibad254f98bd8a086307495e4a09dece68b5cfb00 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0