May 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: engine: Persist only reported supported cluster levels
by oourfali＠redhat.com 13 May '14

13 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Persist only reported supported cluster levels ...................................................................... engine: Persist only reported supported cluster levels In order to configure the management network on the host, only the supported cluster levels should be persisted, so the setup networks can identify the supported api by the host. Change-Id: Ifc82a6d113f1b023f2dc6950e2b3c7aad8aa9ec6 Bug-Url: https://bugzilla.redhat.com/1096757 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataAfterInstallationVDSCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/27626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc82a6d113f1b023f2dc6950e2b3c7aad8aa9ec6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Add broker type to neutron agent configuration
by masayag＠redhat.com 13 May '14

13 May '14

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Add broker type to neutron agent configuration ...................................................................... webadmin: Add broker type to neutron agent configuration The broker type was added to neutron agent configuration so additional broker types could be supported. Change-Id: I04966edaebd4c9d260bbb42cae16ef3a42467ce3 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/HostNeutronAgentModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronAgentModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/NeutronAgentWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/NeutronAgentWidget.ui.xml 7 files changed, 36 insertions(+), 6 deletions(-) Approvals: Lior Vernia: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/27566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04966edaebd4c9d260bbb42cae16ef3a42467ce3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Generalize messaging server broker type
by masayag＠redhat.com 13 May '14

13 May '14

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Generalize messaging server broker type ...................................................................... webadmin: Generalize messaging server broker type Since we intend to support additional messaging broker types (i.e. RabbitMQ), there is a need to update all references to the messaging configuration. Change-Id: I0a18937e5174b5cf95e99b4959f622f368a333c0 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/HostNeutronAgentModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronAgentModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/NeutronAgentWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/NeutronAgentWidget.ui.xml 5 files changed, 66 insertions(+), 66 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a18937e5174b5cf95e99b4959f622f368a333c0 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Generalize messaging broker type
by masayag＠redhat.com 13 May '14

13 May '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Generalize messaging broker type ...................................................................... engine: Generalize messaging broker type The patch starts a series of refactoring patches to support various messaging broker types to be configured on hosts which are installed with an external network provider. Change-Id: Ib8075f2ef1227ab9c4a40cd3a961921d42d5ac22 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OpenstackNetworkProviderProperties.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronAgentModel.java A packaging/dbscripts/upgrade/03_05_0420_generalize_messaging_broker_type.sql 5 files changed, 76 insertions(+), 23 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8075f2ef1227ab9c4a40cd3a961921d42d5ac22 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Persist only reported supported cluster levels
by masayag＠redhat.com 13 May '14

13 May '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Persist only reported supported cluster levels ...................................................................... engine: Persist only reported supported cluster levels In order to configure the management network on the host, only the supported cluster levels should be persisted, so the setup networks can identify the supported api by the host. Change-Id: Ifc82a6d113f1b023f2dc6950e2b3c7aad8aa9ec6 Bug-Url: https://bugzilla.redhat.com/1096757 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataAfterInstallationVDSCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/27618 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc82a6d113f1b023f2dc6950e2b3c7aad8aa9ec6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-cli[master]: cli: Escape comma in values
by juan.hernandez＠redhat.com 13 May '14

13 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Escape comma in values ...................................................................... cli: Escape comma in values When a command line option uses a value with several items we use the comman character as the delimiter of name value pairs, for example: # update vm myvm --cpu-cpu_tune-vcpu_pin "vcpu_pin.vcpu=0,vcpu_pin.cpu_set=0" But some values may actually contain commas, for example the "cpu_set" value may contain a list of CPU indexes separated by commas: # update vm myvm --cpu-cpu_tune-vcpu_pin "vcpu_pin.vcpu=0,vcpu_pin.cpu_set=0,1" The CLI can't currently support this, as it assumes that "1" is a name, instead of taking it as part of the value. To allow this kind of values this patch introduces the backslash as a way to escape the delimiter (the comma), so that the command can be written as follows: # update vm myvm --cpu-cpu_tune-vcpu_pin "vcpu_pin.vcpu=0,vcpu_pin.cpu_set=0\,1" Change-Id: I4bcc5944e3f4236b3495acc02801acae7ec82eb2 Bug-Url: https://bugzilla.redhat.com/1088914 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 44 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/27078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4bcc5944e3f4236b3495acc02801acae7ec82eb2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Fixed view to return correct task
by kmayilsa＠redhat.com 13 May '14

13 May '14

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Fixed view to return correct task ...................................................................... engine: Fixed view to return correct task The task associated with volume is used to build the activity column. In case of jobs that are started but not yet associated with task id, the job status will be 'STARTED'. Fixed the stored proc to use this logic to pick the correct task id. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1064295 Change-Id: Ifb25e2f59c4d5cfa063e498ada4e0091cc4ff53b Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M packaging/dbscripts/gluster_volumes_sp.sql 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/24364 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb25e2f59c4d5cfa063e498ada4e0091cc4ff53b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: frontend: console protocol priority
by oourfali＠redhat.com 13 May '14

13 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: frontend: console protocol priority ...................................................................... frontend: console protocol priority this patch adds priority to ConsoleProtocol enum. This priority determines precedence of protocols when selecting default option in the ui. Change-Id: I9256ef44071f40552e47f03d829d95da810086ab Bug-Url: https://bugzilla.redhat.com/1086244 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleProtocol.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsolesBase.java A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleProtocolTest.java 3 files changed, 92 insertions(+), 8 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/27462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9256ef44071f40552e47f03d829d95da810086ab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add selinux host info to VdsDynamic
by emesika＠redhat.com 13 May '14

13 May '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Add selinux host info to VdsDynamic ...................................................................... core: Add selinux host info to VdsDynamic Added the SELinux enforce mode of the host, as reported by vdsm. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=894084 Change-Id: If472f68702b59280c721450d4db50dc27dc19a30 Signed-off-by: Dima Kuznetsov <dkuznets(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SELinuxMode.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_05_0410_add_selinux_to_vds_dynamic.sql M packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql M packaging/dbscripts/vds_sp.sql 19 files changed, 155 insertions(+), 9 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If472f68702b59280c721450d4db50dc27dc19a30 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuznets(a)redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: fix behavior of console client doc window
by tjelinek＠redhat.com 13 May '14

13 May '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: fix behavior of console client doc window ...................................................................... frontend: fix behavior of console client doc window This patch fixes behavior of console client resources window in webadmin and userportal in MSIE. Previously the content window was opened without the possibility of resizing and with invisible scrollbars. Change-Id: Id872043b88c7cb8fc4077b79a696e97ec8891c8f Bug-Url: https://bugzilla.redhat.com/1078141 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/27597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id872043b88c7cb8fc4077b79a696e97ec8891c8f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0