May 2014 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.1]: fixed exception when trying to access dict item
by msivak＠redhat.com 12 May '14

12 May '14

Martin Sivák has submitted this change and it was merged. Change subject: fixed exception when trying to access dict item ...................................................................... fixed exception when trying to access dict item Change-Id: I9faa898efa9e54844f1816c75d51d3cb94c1c50a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1092075 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/state_machine.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/27588 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9faa898efa9e54844f1816c75d51d3cb94c1c50a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.1 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Persist reported host data
by masayag＠redhat.com 12 May '14

12 May '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Persist reported host data ...................................................................... engine: Persist reported host data When host is being added into the system, its capabilities should be persisted, so it can be referenced for the sake of host management network configuration. Change-Id: I94ceba389afce2cd2e39cfbb45ed0ad06a17273c Bug-Url: https://bugzilla.redhat.com/1096757 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataAfterInstallationVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 3 files changed, 22 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/27587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94ceba389afce2cd2e39cfbb45ed0ad06a17273c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal, webadmin: fixed unchecked cast to PropertyChange...
by awels＠redhat.com 12 May '14

12 May '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: fixed unchecked cast to PropertyChangedEventArgs ...................................................................... userportal, webadmin: fixed unchecked cast to PropertyChangedEventArgs fixed unchecked cast to PropertyChangedEventArgs in AbstractLoginPresenterWidget.java. Fixes a Coverity complaint. Change-Id: I5f0d08647d3fed033fa66f6ed8351d83e95680c0 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPresenterWidget.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/27551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f0d08647d3fed033fa66f6ed8351d83e95680c0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: setup: Force a minimal ETL version
by ydary＠redhat.com 12 May '14

12 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Force a minimal ETL version ...................................................................... packaging: setup: Force a minimal ETL version Change-Id: Iccef80d1397c6b66ad5a8440e59af238b42416a7 Bug-Url: https://bugzilla.redhat.com/1059283 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M Makefile M packaging/setup/ovirt_engine_setup/dwhconfig.py.in M packaging/setup/ovirt_engine_setup/dwhconstants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py M version.mak 6 files changed, 119 insertions(+), 4 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccef80d1397c6b66ad5a8440e59af238b42416a7 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: export iso domain to engine only
by sbonazzo＠redhat.com 12 May '14

12 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: export iso domain to engine only ...................................................................... packaging: setup: export iso domain to engine only Since Ia35aaf42cb46247a2a02df1c2418f4613ad6b965 we ask the user for the ACL to use when exporting the iso domain. We kept the default to be the same as the old behavior - export read-write to the entire network. This is a security risk, potentially allowing unauthorized changes to iso images. This change makes the iso domain accessible by default to the engine's machine only. Change-Id: I504d608896277d66b7c8adfe6e7f45ea00255fb8 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py 2 files changed, 13 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/23450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I504d608896277d66b7c8adfe6e7f45ea00255fb8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: List unreverted changes on cleanup
by sbonazzo＠redhat.com 12 May '14

12 May '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: List unreverted changes on cleanup ...................................................................... packaging: setup: List unreverted changes on cleanup Similarly to what we do with files that do not match their saved hash and are not deleted, output lines in files that were supposed to be reverted but are not found. Change-Id: Ib9555c6d6a2f1652edc1065f9c49154123e8accc Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/files/simple.py 1 file changed, 53 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/22621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9555c6d6a2f1652edc1065f9c49154123e8accc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: add authz namespace support
by yzaslavs＠redhat.com 12 May '14

12 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: add authz namespace support ...................................................................... aaa: add authz namespace support in an environment of large network as active directory forest we need a way to query subset of the content. the namespace will enable the provider to place partitions / domains into context to allow user interface to present selector. currently user interface does not support that, so we query all namespaces at server side. Topic: AAA Change-Id: I38968ae4b61aa8d0a5120a22a17e016cbe96c5e9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthz.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java 4 files changed, 53 insertions(+), 22 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38968ae4b61aa8d0a5120a22a17e016cbe96c5e9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: cleanup AuthzUtils
by yzaslavs＠redhat.com 12 May '14

12 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: cleanup AuthzUtils ...................................................................... aaa: cleanup AuthzUtils reorder parameters to be consistent. remove unneeded parameters. rename parameters and sync to better reflect meaning. Topic: AAA Change-Id: I4b833ca69531b6d8d6b554c3086d7e31c08ff544 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java 1 file changed, 7 insertions(+), 13 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b833ca69531b6d8d6b554c3086d7e31c08ff544 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Add CustomProperties member to HostNIC
by juan.hernandez＠redhat.com 12 May '14

12 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add CustomProperties member to HostNIC ...................................................................... restapi: Add CustomProperties member to HostNIC Added a new Properties member to HostNIC, as well as updated its mapper (and corresponding test class) to reflect it. Also updated the Setup Networks entry in rsdl_metadata.yaml to include the new argument. Change-Id: Ie1cd53d4e3fd0d2f0d7bec7f1a480679a31c6c8f Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostNicMapperTest.java 5 files changed, 26 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1cd53d4e3fd0d2f0d7bec7f1a480679a31c6c8f Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Render CustomPropertiesUtils usable by frontend
by lvernia＠redhat.com 12 May '14

12 May '14

Lior Vernia has submitted this change and it was merged. Change subject: core: Render CustomPropertiesUtils usable by frontend ...................................................................... core: Render CustomPropertiesUtils usable by frontend Removed usage of Pattern/Matcher and of StringUtils where it wasn't necessary, as well as removed new generic instantiation syntax. Change-Id: I7926222061b88325ea0df35e39ad40ec8cce235d Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDeviceCustomPropertiesQuery.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringHelper.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/CustomPropertiesUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/DevicePropertiesUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/SimpleCustomPropertiesUtil.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/ValidationFailureReason.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/VmPropertiesUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/customprop/CustomPropertiesUtilsTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/customprop/DevicePropertiesUtilsTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/customprop/PropertiesUtilsTestHelper.java 10 files changed, 82 insertions(+), 137 deletions(-) Approvals: Lior Vernia: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7926222061b88325ea0df35e39ad40ec8cce235d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0