May 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Arbitrary vlan device name
by juan.hernandez＠redhat.com 13 May '14

13 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Arbitrary vlan device name ...................................................................... restapi: Arbitrary vlan device name 1. base_interface and vlan_id property will be received on GET VdsNetworkInterface. 2.Changes in "setupnetworks" ACTION- - If the base_interface is specified, it will be used instead of determining it from the device name. (The device name will be ignored). - If not, the base_interface name will be determined from the device name as before. (This should be done to keep backward compatibility). See: http://www.ovirt.org/Feature/ArbitraryVlanDeviceName#REST_Api Change-Id: I2b0a42c3f666e408f336f3475903062e9a80a952 Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java 3 files changed, 13 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/27496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b0a42c3f666e408f336f3475903062e9a80a952 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Move custom properties utils to Common package
by lvernia＠redhat.com 13 May '14

13 May '14

Lior Vernia has submitted this change and it was merged. Change subject: core: Move custom properties utils to Common package ...................................................................... core: Move custom properties utils to Common package This to enable usage by the frontend as well. Change-Id: I33f91dac432c40cb3a4d43fa55bf59e7b42638a0 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmCustomPropertiesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/ClusterPolicyCRUDCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryResult.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryThread.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VnicProfileValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/customprop/CustomPropertiesUtils.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/customprop/SimpleCustomPropertiesUtil.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/customprop/ValidationError.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/customprop/ValidationFailureReason.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/customprop/VmPropertiesUtils.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/exceptions/InitializationException.java R backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/customprop/CustomPropertiesUtilsTest.java R backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/customprop/PropertiesUtilsTestHelper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M backend/manager/modules/utils/pom.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/DevicePropertiesUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/customprop/DevicePropertiesUtilsTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/UserDefinedVMPropertiesValueHelper.java M build-tools-root/checkstyles/src/main/resources/checkstyle-suppressions.xml 30 files changed, 61 insertions(+), 46 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33f91dac432c40cb3a4d43fa55bf59e7b42638a0 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: serialVersionUID for console priority comparator
by tjelinek＠redhat.com 13 May '14

13 May '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: serialVersionUID for console priority comparator ...................................................................... frontend: serialVersionUID for console priority comparator follow-up patch Change-Id: Ic455f1ea88e8919af05789b542e9c13bff6991cd Bug-Url: https://bugzilla.redhat.com/1086244 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleProtocol.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/27608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic455f1ea88e8919af05789b542e9c13bff6991cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: frontend: Console PriorityComparator should be serializable
by tjelinek＠redhat.com 13 May '14

13 May '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Console PriorityComparator should be serializable ...................................................................... frontend: Console PriorityComparator should be serializable Change-Id: If1ca0640414981a01e30d2b2d44fd903c309928a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1086244 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleProtocol.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/27579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1ca0640414981a01e30d2b2d44fd903c309928a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Extract common Custom Properties code
by lvernia＠redhat.com 13 May '14

13 May '14

Lior Vernia has submitted this change and it was merged. Change subject: core: Extract common Custom Properties code ...................................................................... core: Extract common Custom Properties code Moved basic validation from SimpleCustomPropertiesUtil to CustomPropertiesUtils, as well as some validation from VmPropertiesUtils that should be common to all custom properties. Removed a lot of additional logic from VmPropertiesUtils that could be accomplished using logic already existing in CustomPropertiesUtils (in some cases after small modifications). Change-Id: I24efa004b1b7fe4359046bca1e6c87188cececf9 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/CustomPropertiesUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/SimpleCustomPropertiesUtil.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/VmPropertiesUtils.java 3 files changed, 89 insertions(+), 207 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24efa004b1b7fe4359046bca1e6c87188cececf9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Persist reported host data
by oourfali＠redhat.com 13 May '14

13 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Persist reported host data ...................................................................... engine: Persist reported host data When host is being added into the system, its capabilities should be persisted, so it can be referenced for the sake of host management network configuration. Change-Id: I94ceba389afce2cd2e39cfbb45ed0ad06a17273c Bug-Url: https://bugzilla.redhat.com/1096757 Bug-Url: https://bugzilla.redhat.com/1096715 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataAfterInstallationVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 3 files changed, 22 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/27590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94ceba389afce2cd2e39cfbb45ed0ad06a17273c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: UI: possible NPE prevention
by shavivi＠redhat.com 13 May '14

13 May '14

Shahar Havivi has submitted this change and it was merged. Change subject: UI: possible NPE prevention ...................................................................... UI: possible NPE prevention Change-Id: Ie8925e63f7cd0343c7d1379a8f830ca49b45d448 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8925e63f7cd0343c7d1379a8f830ca49b45d448 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: host-deploy: support remain in same vector entry
by yzaslavs＠redhat.com 13 May '14

13 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: host-deploy: support remain in same vector entry ...................................................................... host-deploy: support remain in same vector entry this enables setting N values based on external source such as database table. Change-Id: Ib535fe2e971ca074cd7de7dd501d561db21e8d9f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java 1 file changed, 116 insertions(+), 107 deletions(-) Approvals: Alon Bar-Lev: Verified Moti Asayag: Looks good to me, approved Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib535fe2e971ca074cd7de7dd501d561db21e8d9f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[node-3.0]: engine_page: set password when no address is used
by dougsland＠redhat.com 13 May '14

13 May '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: set password when no address is used ...................................................................... engine_page: set password when no address is used We should allow users to set password even when no registration is required. Change-Id: I4d2f27901fd01a8ebd1926ac7328b5cf04ea88aa Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1096074 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d2f27901fd01a8ebd1926ac7328b5cf04ea88aa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: node-3.0 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: set password when no address is used
by dougsland＠redhat.com 13 May '14

13 May '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: set password when no address is used ...................................................................... engine_page: set password when no address is used We should allow users to set password even when no registration is required. Change-Id: I4d2f27901fd01a8ebd1926ac7328b5cf04ea88aa Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1096074 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d2f27901fd01a8ebd1926ac7328b5cf04ea88aa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: automation(a)ovirt.org

1 0