June 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: spice: expose support to control the user data tran...
by juan.hernandez＠redhat.com 04 Jun '14

04 Jun '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: spice: expose support to control the user data transfer ...................................................................... restapi: spice: expose support to control the user data transfer spice supports agent based file transfer support and clipboard copy-paste. Those features are enabled by default, but can be turned off independently. This patch exposes the feature control toggle through the REST API. Change-Id: I337d0b46c40f5ffe20d153707c66a83acbb2a7c1 Bug-Url: https://bugzilla.redhat.com/1082479 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/TemplateMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 6 files changed, 44 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I337d0b46c40f5ffe20d153707c66a83acbb2a7c1 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: fix NPE on vm statistics
by juan.hernandez＠redhat.com 04 Jun '14

04 Jun '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: fix NPE on vm statistics ...................................................................... restapi: fix NPE on vm statistics The problem was that the getMigrationProgressPercent can return null, but this case was not handled and the setting to long throw a NPE. Fixed by explicitly handling the null. Change-Id: Iee06e42c33a6ade371a84deb89d459586d82a9c3 Bug-Url: https://bugzilla.redhat.com/1103490 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/VmStatisticalQuery.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee06e42c33a6ade371a84deb89d459586d82a9c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: AuthenticationProfileRepository to become observer of E...
by yzaslavs＠redhat.com 04 Jun '14

04 Jun '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: AuthenticationProfileRepository to become observer of ExtensionsManager ...................................................................... aaa: AuthenticationProfileRepository to become observer of ExtensionsManager Topic: AAA Change-Id: Ie201fa985eb412f47fe492695b79afee21de66f8 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetDomainListQueryTest.java 2 files changed, 23 insertions(+), 25 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie201fa985eb412f47fe492695b79afee21de66f8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[master]: ovirt-log-collector:Fix: Ask password before engine log coll...
by sbonazzo＠redhat.com 03 Jun '14

03 Jun '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-log-collector:Fix: Ask password before engine log collection. ...................................................................... ovirt-log-collector:Fix: Ask password before engine log collection. The Rest-Api password to be asked before collecting the engine log whenever needed. Currently the password is asked after collecting engine and postgres data. Change-Id: I5e49f3196f5dc5076fe784d7819160dba24e0184 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1098029 Signed-off-by: ndarshan <dnarayan(a)redhat.com> --- M src/__main__.py 1 file changed, 18 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Darshan N: Verified Keith Robertson: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e49f3196f5dc5076fe784d7819160dba24e0184 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: RNG device sources reporting
by juan.hernandez＠redhat.com 03 Jun '14

03 Jun '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: RNG device sources reporting ...................................................................... restapi: RNG device sources reporting This is a restapi part to RNG sources reporting. It adds required_rng_sources to cluster and supported_rng_sources to host resources. Change-Id: I4416fa456d16e65e080df7935769e7153e73b50e Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/977079 --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/ClusterValidator.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/ClusterMapperTest.java 5 files changed, 21 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/27187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4416fa456d16e65e080df7935769e7153e73b50e Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: No trailing / in network labels metadata
by oourfali＠redhat.com 03 Jun '14

03 Jun '14

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: No trailing / in network labels metadata ...................................................................... restapi: No trailing / in network labels metadata The RSDL metadata that describes the operations to add network labels contains an extra slash at the end of the URL. This makes the RSDL generator ignore the URL. As a result the RSDL documentation doesn't contains the headers, and the SDKs are generated incorrectly. Change-Id: I88781dad71e9dca372de6a84c5c2eb3c8d36c21f Bug-Url: https://bugzilla.redhat.com/1101531 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 8ec2ee221b3c2b3c0f2efa2720d15d082d9287ec) --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88781dad71e9dca372de6a84c5c2eb3c8d36c21f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix regression related to update pool
by ahadas＠redhat.com 03 Jun '14

03 Jun '14

Arik Hadas has submitted this change and it was merged. Change subject: core: fix regression related to update pool ...................................................................... core: fix regression related to update pool Because of the use of do-while to add the missing VMs in pool after updating the pool, we were adding a VM also in case no new VMs where requested (because of the 'do' part). The solution is to replace the do-while with for loop. Change-Id: I027d687ecca87dd5eb784e99cd14b115ad55903f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/28307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I027d687ecca87dd5eb784e99cd14b115ad55903f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Confusing message fix
by tnisan＠redhat.com 03 Jun '14

03 Jun '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Confusing message fix ...................................................................... core: Confusing message fix Changed the message related to ACTION_TYPE_FAILED_VM_STATUS_ILLEGAL in all of the files. Change-Id: Ie481d2ece9a330e33051ae231491874edd25de31 Bug-Url: https://bugzilla.redhat.com/1091685 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie481d2ece9a330e33051ae231491874edd25de31 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup - Fix typo in class name
by tnisan＠redhat.com 03 Jun '14

03 Jun '14

Tal Nisan has submitted this change and it was merged. Change subject: core: cleanup - Fix typo in class name ...................................................................... core: cleanup - Fix typo in class name Changed AttachDettachVmDiskParameters to AttachDetachVmDiskParameters. Double-t in detach is misspelled. Change-Id: I2b91c5754da60a5faca23b692baf3894b90962de Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AttachDiskToVmCommandTest.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachDetachVmDiskParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 10 files changed, 29 insertions(+), 29 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/27653 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b91c5754da60a5faca23b692baf3894b90962de Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: minor SPICE cleanup
by tjelinek＠redhat.com 03 Jun '14

03 Jun '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: minor SPICE cleanup ...................................................................... frontend: minor SPICE cleanup This patch removes confusing code that acts like it's responsible for installing SPICE plugin. In 3.y era we actually don't support this (on windows, the plugin installation is handled internally by activex, on Linux we don't support plugin installation at all.). Change-Id: Ib3af00d6eba93756db881229edd112085f217260 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceHtml5Impl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceNativeImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpice.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 5 files changed, 3 insertions(+), 71 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/27132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3af00d6eba93756db881229edd112085f217260 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0