June 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal, webadmin: additional protection for GWT RPC
by awels＠redhat.com 02 Jun '14

02 Jun '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: additional protection for GWT RPC ...................................................................... userportal,webadmin: additional protection for GWT RPC - Added additional protection to GWT-RPC calls. Change-Id: Ia4a5ad1f33eb985aa79e1376aecb48ae365d334d Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/GWTRPCCommunicationProvider.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/XsrfRpcRequestBuilder.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/gwtservices/GenericApiGWTService.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/gwtservices/XsrfProtectedRpcService.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/AbstractXsrfProtectedRpcServlet.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/XsrfProtectedRpcServlet.java M frontend/webadmin/modules/frontend/src/main/resources/META-INF/web-fragment.xml M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendActionTest.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendTest.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/communication/GWTRPCCommunicationProviderTest.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml 14 files changed, 579 insertions(+), 118 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4a5ad1f33eb985aa79e1376aecb48ae365d334d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: adding option to not connect host to inactive domains ...
by laravot＠redhat.com 02 Jun '14

02 Jun '14

Liron Ar has submitted this change and it was merged. Change subject: core: adding option to not connect host to inactive domains servers ...................................................................... core: adding option to not connect host to inactive domains servers This patch adds support for skipping storage server connection of inactive domains when executing ConnectHostToStoragePoolServers command Change-Id: I7cdde23f8513afa119af6eeff0a02e77c43395f3 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServerCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ConnectHostToStoragePoolServersParameters.java 5 files changed, 49 insertions(+), 9 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Liron Ar: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cdde23f8513afa119af6eeff0a02e77c43395f3 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: support for querying connections of domains in given s...
by laravot＠redhat.com 02 Jun '14

02 Jun '14

Liron Ar has submitted this change and it was merged. Change subject: core: support for querying connections of domains in given statuses ...................................................................... core: support for querying connections of domains in given statuses this patch adds the abillity to load storage server connections of domains in provided statuses. Change-Id: Ie05c371b37fb0cb2c723e6aee3d416abd0d8eb20 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/storages_san_sp.sql 6 files changed, 160 insertions(+), 7 deletions(-) Approvals: Liron Ar: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie05c371b37fb0cb2c723e6aee3d416abd0d8eb20 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : Support logging of commands parameters
by oourfali＠redhat.com 02 Jun '14

02 Jun '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : Support logging of commands parameters ...................................................................... engine : Support logging of commands parameters When debug mode is enabled the command parameters excluding the ones in the VdcParametersBase are logged when the command is executed. Fields that need to excluded from the debug log like passwords can be marked with the new Annotation ShouldNotBeLogged and they will be skipped from the log Change-Id: Idfd9423e92f9f9c9a51eca24b20157cc32681018 Bug-Url: https://bugzilla.redhat.com/1095240 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ChangeUserPasswordParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LoginUserParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmOnceParams.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ShouldNotBeLogged.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SysPrepParams.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReflectionUtils.java 8 files changed, 93 insertions(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfd9423e92f9f9c9a51eca24b20157cc32681018 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fixed truncation of 'until' column in tasks
by awels＠redhat.com 02 Jun '14

02 Jun '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fixed truncation of 'until' column in tasks ...................................................................... webadmin: fixed truncation of 'until' column in tasks 'until' column in the task tree was too small for certain locales. Doubled the size. Change-Id: I0c6189fd65494c163a1569460aa12baf10367ce1 Bug-Url: https://bugzilla.redhat.com/1000934 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/TasksTree.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/28246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c6189fd65494c163a1569460aa12baf10367ce1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: reports: updated localization files
by ydary＠redhat.com 02 Jun '14

02 Jun '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: updated localization files ...................................................................... reports: updated localization files Change-Id: Ic47bda35b3e7601e9a9617946045490f22d0b5ad Bug-Url: https://bugzilla.redhat.com/1083636 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_de.properties.data M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_es.properties.data M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_fr.properties.data M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_ja.properties.data M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_pt_BR.properties.data M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_zh_CN.properties.data 6 files changed, 93 insertions(+), 101 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic47bda35b3e7601e9a9617946045490f22d0b5ad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fixed 'new network' dialog spacing issues
by lvernia＠redhat.com 02 Jun '14

02 Jun '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: fixed 'new network' dialog spacing issues ...................................................................... webadmin: fixed 'new network' dialog spacing issues PatternFly patch caused the 'network label' label and field in the 'new network' dialog to be badly positioned. Fixed. Change-Id: I3acbba3cbd4b087714831347a986ea71cde7cc85 Bug-Url: https://bugzilla.redhat.com/1096845 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelWidgetWithInfo.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml M packaging/branding/ovirt.brand/patternfly-custom-hacks.css 3 files changed, 28 insertions(+), 8 deletions(-) Approvals: Greg Sheremeta: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3acbba3cbd4b087714831347a986ea71cde7cc85 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: added default instance types
by tjelinek＠redhat.com 02 Jun '14

02 Jun '14

Tomas Jelinek has submitted this change and it was merged. Change subject: core: added default instance types ...................................................................... core: added default instance types Added the default instance types according to the feature page: http://www.ovirt.org/Features/Instance_Types Change-Id: I8f1ad7e010dfdd181a5baacc76837ae304d64fb6 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- A packaging/dbscripts/upgrade/03_05_0580_add_default_instance_types.sql 1 file changed, 134 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f1ad7e010dfdd181a5baacc76837ae304d64fb6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: SnapshotStatus - remove BROKEN status
by derez＠redhat.com 02 Jun '14

02 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: core: SnapshotStatus - remove BROKEN status ...................................................................... core: SnapshotStatus - remove BROKEN status Remove BROKEN SnapshotStatus as it is not used anymore: * Remove from SnapshotStatus enum. * Remove SnapshotsValidator -> snapshotNotBroken validation. * Remove ACTION_TYPE_FAILED_VM_SNAPSHOT_IS_BROKEN VdcBllMessage. Change-Id: I509e278d2d37fb32a7737bf21111f1bfc7b5019b Bug-Url: https://bugzilla.redhat.com/1056935 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 10 files changed, 3 insertions(+), 41 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I509e278d2d37fb32a7737bf21111f1bfc7b5019b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Deprecate broken snapshots upgrade script
by derez＠redhat.com 02 Jun '14

02 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: core: Deprecate broken snapshots upgrade script ...................................................................... core: Deprecate broken snapshots upgrade script In order to deprecate broken status of snapshots: * Added an upgrade script for setting disks of broken snapshots as illegal. * SnapshotVmConfigurationHelper: Update image status from DB on returned disks (for proper indication for disks status). * TryBackToAllSnapshotsOfVmCommand: Added validation for images that are upon to be previewed. Change-Id: Ia91153b1c3c363bca2d947974e6a67c459dba008 Bug-Url: https://bugzilla.redhat.com/1056935 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotVmConfigurationHelper.java A packaging/dbscripts/upgrade/03_05_0570_deprecate_broken_snapshots.sql 4 files changed, 30 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia91153b1c3c363bca2d947974e6a67c459dba008 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0