June 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: avoid broken status on snapshot removal
by derez＠redhat.com 02 Jun '14

02 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: core: avoid broken status on snapshot removal ...................................................................... core: avoid broken status on snapshot removal RemoveSnapshotCommand: on failure, instead of declaring the entire snapshot as broken, removing the successfully deleted disks from the snapshot while keeping the others. Change-Id: I2a15034185ef30f53fbeaa46440cd92954d39eee Bug-Url: https://bugzilla.redhat.com/1056935 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 41 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a15034185ef30f53fbeaa46440cd92954d39eee Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: import glance image - image locked on failure
by derez＠redhat.com 02 Jun '14

02 Jun '14

Daniel Erez has submitted this change and it was merged. Change subject: core: import glance image - image locked on failure ...................................................................... core: import glance image - image locked on failure ImportRepoImageCreateTaskHandler: Ensure 'destinationImageId' member of 'ImagesActionsParametersBase' is saved in task parameters as part of AddImageFromScratch execution. This change is needed from retrieving 'destinationImageId' value in case of engine crash between tasks. Change-Id: I37eba72dabb17c5ff4c9edaca899f206440791d0 Bug-Url: https://bugzilla.redhat.com/1101541 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCreateTaskHandler.java 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37eba72dabb17c5ff4c9edaca899f206440791d0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: add namespace for directory entities
by yzaslavs＠redhat.com 02 Jun '14

02 Jun '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: add namespace for directory entities ...................................................................... aaa: add namespace for directory entities Topic: AAA Change-Id: I99b5611d4a05a18b271bde61a9d5be14007fd9a4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AdGroupsHandlingCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAvailableAuthzNamespacesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDirectoryGroupByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDirectoryUserByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserCommandBase.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthz.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/DirectoryEntry.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/DirectoryGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/DirectoryUser.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DirectoryIdParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LdapUser.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAvailableAuthzNamespacesQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbGroupDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbUserDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDomainGroupResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDomainUserResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUsersResourceTest.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/aaa/DirectoryGroup_CustomFieldSerializer.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/aaa/DirectoryUser_CustomFieldSerializer.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/SystemPermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java M packaging/dbscripts/ad_groups_sp.sql M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_05_0560_aaa_add_namespace.sql M packaging/dbscripts/user_sp.sql 47 files changed, 379 insertions(+), 148 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28217 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99b5611d4a05a18b271bde61a9d5be14007fd9a4 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix broken test in CommandBaseTest
by yzaslavs＠redhat.com 02 Jun '14

02 Jun '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Fix broken test in CommandBaseTest ...................................................................... engine: Fix broken test in CommandBaseTest Commit c54eba57ddc56c7bd7c6ff1d10360ac6dd145803 introduced the a change which cause the CommandBaseTest to fail. Change-Id: Idf63bf15ba6f7f1737213d8799ba8fe198190e1a Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf63bf15ba6f7f1737213d8799ba8fe198190e1a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: cleanup whitespace
by lvernia＠redhat.com 01 Jun '14

01 Jun '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: cleanup whitespace ...................................................................... webadmin: cleanup whitespace cleanup whitespace Change-Id: Idea899b4fe4643b4c1b5ebc4e80b0523478db000 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelWidgetWithInfo.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml 2 files changed, 126 insertions(+), 126 deletions(-) Approvals: Greg Sheremeta: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idea899b4fe4643b4c1b5ebc4e80b0523478db000 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Persist empty QoS for VM
by masayag＠redhat.com 01 Jun '14

01 Jun '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Persist empty QoS for VM ...................................................................... engine: Persist empty QoS for VM This has been fixed previously for host QoS but not for VMs; in case no QoS is assigned to a profile, an empty entry is sent (rather than no entry). Change-Id: Iffe16ac863d338aa82cab1248b8fb1769ac7fcd3 Bug-Url: https://bugzilla.redhat.com/1077684 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 12 insertions(+), 14 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffe16ac863d338aa82cab1248b8fb1769ac7fcd3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Aggregate errors by default in runMultipleActions()
by lvernia＠redhat.com 01 Jun '14

01 Jun '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Aggregate errors by default in runMultipleActions() ...................................................................... webadmin: Aggregate errors by default in runMultipleActions() Changed the default calls to aggregate errors. Although this potentially affects several existing invocations, most of them provide a failure callback of their own and so render this argument irrelevant. The ones that are affected are SanStorageModelBase.connectTargets() and NewDiskModel.onAttachDisks(), where it seemed to me that the desireable behavior would indeed be to aggregate multiple errors if they are returned. Also corrected the Javadoc for some overloads in Frontend. Change-Id: I423a737888a3b3ec6bb492d8eaf825d9cce9872c Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java 2 files changed, 12 insertions(+), 11 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/28216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I423a737888a3b3ec6bb492d8eaf825d9cce9872c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix usage to Java 7's diamond generics
by mlipchuk＠redhat.com 01 Jun '14

01 Jun '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix usage to Java 7's diamond generics ...................................................................... core: Fix usage to Java 7's diamond generics Used Java 7's diamond generics to improve readability of GetTemplatesFromExportDomainQuery.buildFromOVFs. Change-Id: Ia878db1cc56579ba701e77d5c359faf137200292 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetTemplatesFromExportDomainQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Looks good to me, approved Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/28224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia878db1cc56579ba701e77d5c359faf137200292 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Replaced unmodifiable due to GWT-RPC bug
by lvernia＠redhat.com 01 Jun '14

01 Jun '14

Lior Vernia has submitted this change and it was merged. Change subject: core: Replaced unmodifiable due to GWT-RPC bug ...................................................................... core: Replaced unmodifiable due to GWT-RPC bug Apparently GWT-RPC serialization doesn't handle unmodifiable collections well, see https://code.google.com/p/google-web-toolkit/issues/detail?id=3328. Change-Id: Ia9f13df5f9d2b742b2752ef8a0180f19252b602a Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/DevicePropertiesUtils.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9f13df5f9d2b742b2752ef8a0180f19252b602a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: When adding a new VM disk, allow activation in cer...
by tnisan＠redhat.com 01 Jun '14

01 Jun '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: When adding a new VM disk, allow activation in certain VM statuses ...................................................................... webadmin: When adding a new VM disk, allow activation in certain VM statuses When adding a disk to a VM, allow disk activation only for a VM in status Up/Down/Paused otherwise the CDA in the plug disk command will fail, this does not apply to disks with IDE interfaces which can only be activated in a VM with a Down status Change-Id: Idd625adb50ceaee3754f317d5751b78e29f7ea25 Bug-Url: https://bugzilla.redhat.com/1055224 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 18 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd625adb50ceaee3754f317d5751b78e29f7ea25 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0