September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[sdk_3.4]: sdk: Regenerate against the latest API
by juan.hernandez＠redhat.com 09 Sep '14

09 Sep '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Regenerate against the latest API ...................................................................... sdk: Regenerate against the latest API This patch regenerates the SDK using the latest API obtained from the engine built from commit 3d257b0, tag ovirt-engine-3.4.4_rc. Change-Id: I0982c8705db9415885aca480b9cd94e11e1e8a53 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 2 files changed, 1,480 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0982c8705db9415885aca480b9cd94e11e1e8a53 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: ui: combobox label wrong alignment
by tnisan＠redhat.com 09 Sep '14

09 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: ui: combobox label wrong alignment ...................................................................... ui: combobox label wrong alignment The combobox label is too short which make the text overlay over the selection in editable mode. Change-Id: Iefafe0240d15fe9e2a0e741e4804b2b6c1a40e87 Bug-Url: https://bugzilla.redhat.com/1139201 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ComboBox.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/32670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefafe0240d15fe9e2a0e741e4804b2b6c1a40e87 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Don't apply SuggestBox selection on tab
by tnisan＠redhat.com 09 Sep '14

09 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Don't apply SuggestBox selection on tab ...................................................................... webadmin: Don't apply SuggestBox selection on tab The default behavior where pressing tab applies the selected suggestion isn't desireable for us, so the event propagation is stopped in that case. Change-Id: I13e67506f8b2b93fb97189392582175df7582917 Bug-Url: https://bugzilla.redhat.com/1134208 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> (cherry picked from commit dc3939100134ce17731347911834588f80e53e11) --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBox.java 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13e67506f8b2b93fb97189392582175df7582917 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix layout of 'MTU' field in Network dialog
by tnisan＠redhat.com 09 Sep '14

09 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix layout of 'MTU' field in Network dialog ...................................................................... webadmin: Fix layout of 'MTU' field in Network dialog Change-Id: Ife6ac4de47b9bf2c604e9c1024e64fe32a0fb003 Bug-Url: https://bugzilla.redhat.com/1127587 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml 2 files changed, 18 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife6ac4de47b9bf2c604e9c1024e64fe32a0fb003 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: SetupNetwork- long network names shouldn't break t...
by tnisan＠redhat.com 09 Sep '14

09 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: SetupNetwork- long network names shouldn't break the layout ...................................................................... webadmin: SetupNetwork- long network names shouldn't break the layout Adding '...' to long network names that break the layout. Change-Id: Ife6ef384a5eac71398b397d8475ec312ed97eeb5 Bug-Url: https://bugzilla.redhat.com/1133598 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> (cherry picked from commit b970ff0d12579e6894abb18db77b899625fe64c5) --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java 4 files changed, 62 insertions(+), 10 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife6ef384a5eac71398b397d8475ec312ed97eeb5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Removal of labelled network from DC inconsistent with ...
by tnisan＠redhat.com 09 Sep '14

09 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Removal of labelled network from DC inconsistent with removal from cluster ...................................................................... core: Removal of labelled network from DC inconsistent with removal from cluster - when removing labeled network from dc, "remove [that] network from host". I.e. call PersistentSetupNetworks so that given network is removed from host. Change-Id: I9ebc162324ff2ed98374d6a9a3bd9d87bb69db3f Bug-Url: https://bugzilla.redhat.com/1091692 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java 5 files changed, 78 insertions(+), 25 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ebc162324ff2ed98374d6a9a3bd9d87bb69db3f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine, webadmin: Plugging of an unlinked vnic with an ext ne...
by tnisan＠redhat.com 09 Sep '14

09 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: engine,webadmin: Plugging of an unlinked vnic with an ext net is blocked ...................................................................... engine,webadmin: Plugging of an unlinked vnic with an ext net is blocked Plugged and unlinked VM network interface is not supported for an external network, thus the action is blocked. Change-Id: Ia944ca7e0430adc54a6cae6cb65b8a1df4e88d24 Bug-Url: https://bugzilla.redhat.com/1077796 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> (cherry picked from commit 04531c26302628d07b5f15e88113c2ead8e852ab) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 21 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/32629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia944ca7e0430adc54a6cae6cb65b8a1df4e88d24 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: Fix watchdog configuration for localized webadmin
by tnisan＠redhat.com 09 Sep '14

09 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: Fix watchdog configuration for localized webadmin ...................................................................... Fix watchdog configuration for localized webadmin Watchdog settings for type and action were directly translating the possible values. That caused issues during saving as the selected enum value could not be detected due to localization. This updates the code to use the proper way of rendering localized enums. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1135467 Change-Id: Id1ff4c839c112d4a8956cc40f5ee30294c67cc08 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/instancetypes/InstanceTypeListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingInstanceTypeModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java 8 files changed, 99 insertions(+), 95 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Sivák: Verified -- To view, visit http://gerrit.ovirt.org/32215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1ff4c839c112d4a8956cc40f5ee30294c67cc08 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: style fixes in manage events popup.
by oourfali＠redhat.com 09 Sep '14

09 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: style fixes in manage events popup. ...................................................................... webadmin: style fixes in manage events popup. Change-Id: Ie7b8063d60666bdbcaaeaa7347ff36b7a3ddc369 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133572 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/user/ManageEventsPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/css/NotificationsTree.css 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7b8063d60666bdbcaaeaa7347ff36b7a3ddc369 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add distinct keyword to search
by ofrenkel＠redhat.com 09 Sep '14

09 Sep '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: add distinct keyword to search ...................................................................... core: add distinct keyword to search currently, the search can return duplicate results, for example when template has more than one disk, or disks are on different storage domains. this patch adds a 'distinct' to the sql the search mechanism creates, in order to remove any duplicates that return from the query. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1130915 Change-Id: I070900dc9e1064c98f8b342f26dbc3c23ba8c4a4 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 2 files changed, 67 insertions(+), 65 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I070900dc9e1064c98f8b342f26dbc3c23ba8c4a4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0