September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: aaa: engine-manads-domains always tries to look for KDC in DNS
by oourfali＠redhat.com 09 Sep '14

09 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: engine-manads-domains always tries to look for KDC in DNS ...................................................................... aaa: engine-manads-domains always tries to look for KDC in DNS The bug was caused due to the fact that the kdcs are always being validated, regardless of their "source" Change-Id: Ib3bb7cc049ad5b23127a505ff891b2d489a2caca Topic: AAA Bug-Url: https://bugzilla.redhat.com/1136087 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java 1 file changed, 23 insertions(+), 17 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3bb7cc049ad5b23127a505ff891b2d489a2caca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: api: Fix german translation
by juan.hernandez＠redhat.com 09 Sep '14

09 Sep '14

Juan Hernandez has submitted this change and it was merged. Change subject: api: Fix german translation ...................................................................... api: Fix german translation Placing a more proper translation to one of the tests Change-Id: I268063d0e068ce88746d94d2f7995e4f3961c13f Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/resources/org/ovirt/engine/api/restapi/logging/Messages_de.properties 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32660 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I268063d0e068ce88746d94d2f7995e4f3961c13f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: clone vm - if the vm has only sharable disks they are ...
by tjelinek＠redhat.com 09 Sep '14

09 Sep '14

Tomas Jelinek has submitted this change and it was merged. Change subject: core: clone vm - if the vm has only sharable disks they are not attached ...................................................................... core: clone vm - if the vm has only sharable disks they are not attached The problem was that the attachDisks() was called only from endSuccessfully() which was called only after the async tasks ended. But when there were no disks to copy, there were no async tasks so this method was not called. Fixed by moving the logic into the overridden addVmImages() method and detaching the disks in case of an error during copying the disks. Change-Id: Ie2a8f4c35c68721e59c0b7e35c9148f148589794 Bug-Url: https://bugzilla.redhat.com/1124340 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java 1 file changed, 23 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31796 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2a8f4c35c68721e59c0b7e35c9148f148589794 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Focus on label widget by default
by lvernia＠redhat.com 09 Sep '14

09 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Focus on label widget by default ...................................................................... webadmin: Focus on label widget by default Added default focus on the label widget in HostNicPopupView. This required implementing focusInput() in AddRemoveRowWidget, as well as a slight modification in ListModelSuggestBox to make sure suggestion menu positioning happens shortly after the dialog is displayed (without it, the suggestion menu was ill-positioned). Change-Id: I36c9ae0b7ac9d61112ace1829434c9c685b85a22 Bug-Url: https://bugzilla.redhat.com/1134200 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBox.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostNicPopupView.java 3 files changed, 27 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36c9ae0b7ac9d61112ace1829434c9c685b85a22 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: combobox label wrong alignment
by shavivi＠redhat.com 09 Sep '14

09 Sep '14

Shahar Havivi has submitted this change and it was merged. Change subject: ui: combobox label wrong alignment ...................................................................... ui: combobox label wrong alignment The combobox label is too short which make the text overlay over the selection in editable mode. Change-Id: Iefafe0240d15fe9e2a0e741e4804b2b6c1a40e87 Bug-Url: https://bugzilla.redhat.com/1139201 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ComboBox.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/32644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefafe0240d15fe9e2a0e741e4804b2b6c1a40e87 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Reduce # of calls to getVdsGroupByVdsGroupId
by oourfali＠redhat.com 09 Sep '14

09 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Reduce # of calls to getVdsGroupByVdsGroupId ...................................................................... core: Reduce # of calls to getVdsGroupByVdsGroupId Since vds view is built on top of the vds_groups table (in addition to other tables), this patch adds to vds the enable_ballon property so that we don't need to load the full VdsGroup to get this value. This saves ~90% of calls to getVdsGroupByVdsGroupId in an idle scenario, each of these calls takes ~300us (depending on the number of clusters a customer has). Change-Id: I9d838a19e0496951b9821936bd3af215e3a31c0d Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M packaging/dbscripts/create_views.sql 4 files changed, 16 insertions(+), 8 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d838a19e0496951b9821936bd3af215e3a31c0d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Unassigned log type should not be logged
by masayag＠redhat.com 09 Sep '14

09 Sep '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Unassigned log type should not be logged ...................................................................... engine: Unassigned log type should not be logged The Unassigned log type is used to ignore a logging of an event. Hence, it should not appear in the resource bundle. Change-Id: I4dad0139cc65fe3c90f7c59cda5416db1a83c569 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4dad0139cc65fe3c90f7c59cda5416db1a83c569 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Finalizing step typo
by oourfali＠redhat.com 09 Sep '14

09 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Finalizing step typo ...................................................................... core: Finalizing step typo Removed the full stop from "Finalizing." in order to match "Validating" and "Executing" steps. Change-Id: Icf9d4372f99e65d5b113aabcc87777beae85bed2 Bug-Url: https://bugzilla.redhat.com/1139311 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf9d4372f99e65d5b113aabcc87777beae85bed2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: setupNetworks not able to configure bridge
by oourfali＠redhat.com 09 Sep '14

09 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: setupNetworks not able to configure bridge ...................................................................... core: setupNetworks not able to configure bridge For 2 calls we use ThreadPoolUtil. It was used to provide async network call for xmlrpc. Jsonrpc is async so from its prespective it makes no sense to use it. In order to keep the communication interface unchanged we need to returned Future. The future checked whether the call was executed not whether the response arrived. This patch makes sure that we wait for response and expose this information correctly. Bug-Url: https://bugzilla.redhat.com/1136876 Change-Id: I70bfa5d7f154a13f7d52f7710eb109de1da0b82c Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/FutureMap.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M ovirt-engine.spec.in M pom.xml 4 files changed, 106 insertions(+), 25 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70bfa5d7f154a13f7d52f7710eb109de1da0b82c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: setupNetworks not able to configure bridge
by oourfali＠redhat.com 09 Sep '14

09 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: setupNetworks not able to configure bridge ...................................................................... core: setupNetworks not able to configure bridge For 2 calls we use ThreadPoolUtil. It was used to provide async network call for xmlrpc. Jsonrpc is async so from its prespective it makes no sense to use it. In order to keep the communication interface unchanged we need to returned Future. The future checked whether the call was executed not whether the response arrived. This patch makes sure that we wait for response and expose this information correctly. Bug-Url: https://bugzilla.redhat.com/1136876 Change-Id: I70bfa5d7f154a13f7d52f7710eb109de1da0b82c Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/FutureMap.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M ovirt-engine.spec.in M pom.xml 4 files changed, 106 insertions(+), 25 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70bfa5d7f154a13f7d52f7710eb109de1da0b82c Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0