September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: reduced logging in Even distribution policy
by rgolan＠redhat.com 29 Sep '14

29 Sep '14

Roy Golan has submitted this change and it was merged. Change subject: engine: reduced logging in Even distribution policy ...................................................................... engine: reduced logging in Even distribution policy Change-Id: I99d7492bba98670027dbb5b13e2290bf84510ec1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1126839 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnit.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jiří Moskovčák: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31176 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99d7492bba98670027dbb5b13e2290bf84510ec1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: packaging: spec: add jpackage-utils build requires
by Alon Bar-Lev 28 Sep '14

28 Sep '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: spec: add jpackage-utils build requires ...................................................................... packaging: spec: add jpackage-utils build requires Change-Id: I9c9d97cd7a7021bd76077fb8400715a0b98fa034 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M otopi.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c9d97cd7a7021bd76077fb8400715a0b98fa034 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Calculate total committed size of a storage domain cor...
by tnisan＠redhat.com 28 Sep '14

28 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Calculate total committed size of a storage domain correctly ...................................................................... core: Calculate total committed size of a storage domain correctly Bug-Url: https://bugzilla.redhat.com/1147246 Change-Id: I60a63917e4e0bc060109346759fe7412d3365970 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M packaging/dbscripts/create_functions.sql 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60a63917e4e0bc060109346759fe7412d3365970 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fix typo in error message
by tnisan＠redhat.com 28 Sep '14

28 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: fix typo in error message ...................................................................... core: fix typo in error message Capital letter for profile error message. Change-Id: I4f60451e00c27470ce343c485761c7f2561d1b58 Bug-Url: https://bugzilla.redhat.com/1142887 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/33422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f60451e00c27470ce343c485761c7f2561d1b58 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Calculate total committed size of a storage domain cor...
by tnisan＠redhat.com 28 Sep '14

28 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Calculate total committed size of a storage domain correctly ...................................................................... core: Calculate total committed size of a storage domain correctly Bug-Url: https://bugzilla.redhat.com/1147246 Change-Id: I60a63917e4e0bc060109346759fe7412d3365970 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M packaging/dbscripts/create_functions.sql 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60a63917e4e0bc060109346759fe7412d3365970 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove Memory and OVF Volumes on VM Remove
by amureini＠redhat.com 28 Sep '14

28 Sep '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove Memory and OVF Volumes on VM Remove ...................................................................... core: Remove Memory and OVF Volumes on VM Remove When removing a VM that has a snapshot with memory, its memory and OVF volumes are not removed. The reason for this is the value of the property removeOnlyIfNotUsedAtAll in RemoveMemoryVolumesParameters. If we don't set its value to true, by default it's false and then we can remove the memory and OVF volumes before the VM's disks. Change-Id: I5303c571e3d8843c03b195ec91763279053bc5de Bug-Url: https://bugzilla.redhat.com/1145073 Bug-Url: https://bugzilla.redhat.com/1145188 Bug-Url: https://bugzilla.redhat.com/1147085 Bug-Url: https://bugzilla.redhat.com/1145254 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java 1 file changed, 1 insertion(+), 9 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Idan Shaby: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5303c571e3d8843c03b195ec91763279053bc5de Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Unassigned log type should not be logged
by tnisan＠redhat.com 28 Sep '14

28 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Unassigned log type should not be logged ...................................................................... engine: Unassigned log type should not be logged The Unassigned log type is used to ignore a logging of an event. Hence, it should not appear in the resource bundle. This patch, back-ported from master branch resolves the reported issue. Change-Id: I4dad0139cc65fe3c90f7c59cda5416db1a83c569 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1142859 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Downstream-Only --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33430 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4dad0139cc65fe3c90f7c59cda5416db1a83c569 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Extract code common for cluster network attach/update
by lvernia＠redhat.com 28 Sep '14

28 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: engine: Extract code common for cluster network attach/update ...................................................................... engine: Extract code common for cluster network attach/update Validation is very similar in those two commands, so extracted the common code to a superclass both extend. Change-Id: I3869fad7c00313626587ba28f867801795061f69 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java 3 files changed, 62 insertions(+), 71 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3869fad7c00313626587ba28f867801795061f69 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: core: filetransaction: restore default selinux default attri...
by Alon Bar-Lev 28 Sep '14

28 Sep '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: filetransaction: restore default selinux default attributes ...................................................................... core: filetransaction: restore default selinux default attributes restore default selinux attributes for modified files or created directories. this will override sysadmin local changes (if exists), but will enable predictable outcome. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1146689 Change-Id: I40621911c4a3cced2b2c552ee1de2696d3a8c6c7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/otopi/filetransaction.py M src/plugins/otopi/network/ssh.py 3 files changed, 57 insertions(+), 39 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40621911c4a3cced2b2c552ee1de2696d3a8c6c7 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: don't use hotplug when updating instance type
by ofrenkel＠redhat.com 28 Sep '14

28 Sep '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: don't use hotplug when updating instance type ...................................................................... core: don't use hotplug when updating instance type when updating vms connected to an instance type, if using hotplug (for cpu) and it fails, the change is lost. so always use "apply later" so the changes would anyway apply when the vm is down. Change-Id: I8f5b494a91ef3328fb2631da922c8a3cd582f67b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1136372 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f5b494a91ef3328fb2631da922c8a3cd582f67b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0