September 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: import vm dialog - fix subtabs refresh
by tnisan＠redhat.com 28 Sep '14

28 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: import vm dialog - fix subtabs refresh ...................................................................... webadmin: import vm dialog - fix subtabs refresh As done in 'ImportVmModel -> initDetailModels', VmImportDiskListModel/VmImportInterfaceListModel should also override 'setEntity' to get the VM object rather than the wrapping ImportVmData EntityModel (same applies for TemplateImport models) Change-Id: Iab5f6f522d007dd88e8d6a14f9ab66f37a1adae4 Bug-Url: https://bugzilla.redhat.com/1141693 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateImportDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateImportInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmImportDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmImportInterfaceListModel.java 4 files changed, 24 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/33295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab5f6f522d007dd88e8d6a14f9ab66f37a1adae4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix typo in error message
by gchaplik＠redhat.com 28 Sep '14

28 Sep '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: fix typo in error message ...................................................................... core: fix typo in error message Capital letter for profile error message. Change-Id: I4f60451e00c27470ce343c485761c7f2561d1b58 Bug-Url: https://bugzilla.redhat.com/1142887 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33420 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f60451e00c27470ce343c485761c7f2561d1b58 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: add missing profiles audit log translations
by gchaplik＠redhat.com 28 Sep '14

28 Sep '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: add missing profiles audit log translations ...................................................................... core: add missing profiles audit log translations Change-Id: Ib52db560164f9aa7773bcf96ca7d3f185a58da6b Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/ProfileCommandBase.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 2 files changed, 19 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib52db560164f9aa7773bcf96ca7d3f185a58da6b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Use enum name to search providers
by tnisan＠redhat.com 28 Sep '14

28 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Use enum name to search providers ...................................................................... core: Use enum name to search providers Currently we build search queries for providers using the numeric value of the type, and comparing it to the "providers.provider_type" database column. But this column stores the name of the enum, not the numeric value. This patch changes the autocompleter so that it uses the name. Change-Id: I4822be2cfd57c093d4fdf11f0410c055faea8be2 Bug-Url: https://bugzilla.redhat.com/1145247 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit e9d780841b6a6c984338739d010ff8cc90b2f5ea) --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ProviderConditionFieldAutoCompleter.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified Lior Vernia: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4822be2cfd57c093d4fdf11f0410c055faea8be2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Formatting onImport method on StorageListModel
by tnisan＠redhat.com 28 Sep '14

28 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Formatting onImport method on StorageListModel ...................................................................... webadmin: Formatting onImport method on StorageListModel 1. Using formatter on onImport method 2. put bracket on EOL instead in a new line. Change-Id: I6713974c94808b414282d21fb71df67b514faa8c Bug-Url: https://bugzilla.redhat.com/1136750 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 13 insertions(+), 22 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33253 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6713974c94808b414282d21fb71df67b514faa8c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Adding support to import GlusterFS
by tnisan＠redhat.com 28 Sep '14

28 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Adding support to import GlusterFS ...................................................................... webadmin: Adding support to import GlusterFS Adding support to import GlusterFS Change-Id: Ic66b535004d40f28c4b703f5d5899253cd2616ac Bug-Url: https://bugzilla.redhat.com/1136750 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic66b535004d40f28c4b703f5d5899253cd2616ac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: extmgr: add nested exception message into new exception
by tnisan＠redhat.com 28 Sep '14

28 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: extmgr: add nested exception message into new exception ...................................................................... extmgr: add nested exception message into new exception this enables to see helpful errors while not in debug mode. Topic: AAA Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: If321921682d4de599db202956babb1af8a7b315b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If321921682d4de599db202956babb1af8a7b315b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use Collections instead of Lists
by amureini＠redhat.com 26 Sep '14

26 Sep '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Use Collections instead of Lists ...................................................................... core: Use Collections instead of Lists In storage allocation-related methods, use Collections instead if lists when possible. Further validations will be on top of this, specifically storage allocation validation in ImportVmTemplateCommand, hence the bz url bellow. Change-Id: Ic89752086a68ca2f87bc58cefc33d5373c7f8eef Related-To: https://bugzilla.redhat.com/1136721 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidator.java 2 files changed, 17 insertions(+), 17 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/33043 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic89752086a68ca2f87bc58cefc33d5373c7f8eef Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanups in MoveOrCopyTemplateCommand
by amureini＠redhat.com 26 Sep '14

26 Sep '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: cleanups in MoveOrCopyTemplateCommand ...................................................................... core: cleanups in MoveOrCopyTemplateCommand Fix typo, removed unused method and redundant empty line. Change-Id: Icb15c84d10d301bb593ad9930e4b1b56b6ab7af5 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java 1 file changed, 1 insertion(+), 18 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/32972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb15c84d10d301bb593ad9930e4b1b56b6ab7af5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: Error dialogs don't close on enter
by awels＠redhat.com 26 Sep '14

26 Sep '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: Error dialogs don't close on enter ...................................................................... userportal,webadmin: Error dialogs don't close on enter - When an error dialog popped up the enter key would not close the dialog. This patch fixes the enter key to close the dialog as expected. Change-Id: Iefd72a9de81a64fd7f194252abd46a646bdcc6c5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1143973 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ErrorPopupPresenterWidget.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefd72a9de81a64fd7f194252abd46a646bdcc6c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0