November 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: change 'SSH Port' to 'Port' in PM dialog
by masayag＠redhat.com 29 Nov '15

29 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: core: change 'SSH Port' to 'Port' in PM dialog ...................................................................... core: change 'SSH Port' to 'Port' in PM dialog Changing 'SSH Port' to 'Port' in PM dialog since not all ports are SSH ports and the term 'Port' is more general and matches all PM agents. Change-Id: I8220adb1da68edddd18a801e2deaf6dafbc2bb87 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1280309 Signed-off-by: emesika <emesika(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8220adb1da68edddd18a801e2deaf6dafbc2bb87 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: resolve Coverity issue 1229033
by masayag＠redhat.com 29 Nov '15

29 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: core: resolve Coverity issue 1229033 ...................................................................... core: resolve Coverity issue 1229033 Prevent race conditions and replace active flag with standard lock mechanism Change-Id: I9ffc58a133dc575d247e781fe9ad4ad2e59b262b Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java 1 file changed, 12 insertions(+), 15 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49153 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ffc58a133dc575d247e781fe9ad4ad2e59b262b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: resolve Coverityy issue 1294817
by masayag＠redhat.com 29 Nov '15

29 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: core: resolve Coverityy issue 1294817 ...................................................................... core: resolve Coverityy issue 1294817 Prevent race conditions and replace active flag with standard lock mechanism Change-Id: I938affa7863f903001679fbc634371df00190306 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EngineBackupAwarenessManager.java 1 file changed, 8 insertions(+), 9 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I938affa7863f903001679fbc634371df00190306 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: explicit cast from Object to boolean
by ahadas＠redhat.com 29 Nov '15

29 Nov '15

Arik Hadas has submitted this change and it was merged. Change subject: core: explicit cast from Object to boolean ...................................................................... core: explicit cast from Object to boolean Some compailers complain on implicit cast from Object to boolean, thus replacing it with explicit cast. Change-Id: Ib2f3ec27b276b04bba2adcf9be49091edf00dcba Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/49362 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2f3ec27b276b04bba2adcf9be49091edf00dcba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in ImportVmCommand
by ahadas＠redhat.com 29 Nov '15

29 Nov '15

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in ImportVmCommand ...................................................................... core: cleanup in ImportVmCommand ImportVmCommand does not need to implement TaskHandlerCommand, therefore changing it. Change-Id: I16916d2dd4673c3ecb583d3f3e1c5d0a7ed3579f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 1 insertion(+), 65 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/49369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16916d2dd4673c3ecb583d3f3e1c5d0a7ed3579f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Audit log importing of hosted engine domain
by rgolan＠redhat.com 29 Nov '15

29 Nov '15

Roy Golan has submitted this change and it was merged. Change subject: core: Audit log importing of hosted engine domain ...................................................................... core: Audit log importing of hosted engine domain Change-Id: Idf3ec89b73824c6078979d94bae46cd204c93f6d Bug-Url: https://bugzilla.redhat.com1269768 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportHostedEngineStorageDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 12 insertions(+), 0 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf3ec89b73824c6078979d94bae46cd204c93f6d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-reports[master]: reports: fix problem with chinese translations
by sradco＠redhat.com 29 Nov '15

29 Nov '15

Shirly Radco has submitted this change and it was merged. Change subject: reports: fix problem with chinese translations ...................................................................... reports: fix problem with chinese translations Fix broken chinese translations in ad hoc reports by adding full width parantheses to the validatore Change-Id: I863dceb83cd2e5a0c7dc4743dfbfcccdf7c5a778 Bug-Url: https://bugzilla.redhat.com/1211052 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- A packaging/jasper-war-patches/pro/200_010_web-inf-allow-full-width-parentheses.patch 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I863dceb83cd2e5a0c7dc4743dfbfcccdf7c5a778 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Auto import HE VM if config option is set
by rgolan＠redhat.com 29 Nov '15

29 Nov '15

Roy Golan has submitted this change and it was merged. Change subject: core: Auto import HE VM if config option is set ...................................................................... core: Auto import HE VM if config option is set Consult ConfigValues.AutoImportHostedEngine before doing the import. Version 3.5 and below is not supported and is False by default. engine-config property is introduced as well Change-Id: Iab2f4c8d41afdd7ae5037f99c19b25e70eb9b443 Bug-Url: https://bugzilla.redhat.com/1269768 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostedEngineImporter.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 4 files changed, 26 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48242 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab2f4c8d41afdd7ae5037f99c19b25e70eb9b443 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix db upgrade issue
by masayag＠redhat.com 29 Nov '15

29 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Fix db upgrade issue ...................................................................... core: Fix db upgrade issue Fixes 3.6 -> master db upgrade issues cause by incorrectly name db upgrade scripts merged into master. Change-Id: Ifa32a5344309fce7e6ba7555ad74be50690d4765 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- R packaging/dbscripts/upgrade/04_00_0040_convert_hibernation_volumes_to_disks.sql R packaging/dbscripts/upgrade/04_00_0050_remove_deprecated_config_value.sql R packaging/dbscripts/upgrade/04_00_0060_rename_cpu_type_ibm_power_8.sql 3 files changed, 0 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49319 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa32a5344309fce7e6ba7555ad74be50690d4765 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: doc: Add ovirt-setup-lib package to requirements
by sbonazzo＠redhat.com 27 Nov '15

27 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: doc: Add ovirt-setup-lib package to requirements ...................................................................... doc: Add ovirt-setup-lib package to requirements Patch I884089c5674ab8042cc02fe46ab5a3ca3a599b97 introduced dependency on ovirt-setup-lib package, but this depenency have to be manually installed in development environment. This patch adds ovirt-setup-lib into required packages in README.developer Change-Id: Ia137940adc2d27c261ca9cf3fb959ca24eb1052f Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M README.developer 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49323 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia137940adc2d27c261ca9cf3fb959ca24eb1052f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0