November 2015 - Engine-commits - oVirt List Archives

Change in ovirt-guest-agent[master]: PEP8 fix introduced regression
by vfeenstr＠redhat.com 27 Nov '15

27 Nov '15

Vinzenz Feenstra has submitted this change and it was merged. Change subject: PEP8 fix introduced regression ...................................................................... PEP8 fix introduced regression Bug-Url: https://bugzilla.redhat.com/1285834 Change-Id: I9af99bce9b5c2558a1e87859edc08cce37704cd2 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified; Looks good to me, approved Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/49284 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9af99bce9b5c2558a1e87859edc08cce37704cd2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: Generate WildFly overlay config in Makefile
by piotr.kliczewski＠gmail.com 27 Nov '15

27 Nov '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: Generate WildFly overlay config in Makefile ...................................................................... packaging: Generate WildFly overlay config in Makefile Moves configuration of WildFly overlay from spec to Makefile to automatic configuration of overlay in development environment with possibility to override overlay directory. Change-Id: I6f8a7f730dbcd9e421d9f5b6100857706a40fb8d Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M Makefile M README.developer M ovirt-engine.spec.in 3 files changed, 19 insertions(+), 15 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f8a7f730dbcd9e421d9f5b6100857706a40fb8d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unnecessary null check for VdcReturnValueBase i...
by masayag＠redhat.com 27 Nov '15

27 Nov '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Remove unnecessary null check for VdcReturnValueBase instance ...................................................................... core: Remove unnecessary null check for VdcReturnValueBase instance VdcReturnValueBase is created as a result of command execution and it should never be null (otherwise there is a bug in command infrastructure). This problematic null check was reported by Coverity CIDs 1340335-1340338. Change-Id: I9d77115081e5d9ec7e6714f60c22f717d2da2b3b Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/RegisterVdsQuery.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49292 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d77115081e5d9ec7e6714f60c22f717d2da2b3b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Base templates also contains <version> tag
by juan.hernandez＠redhat.com 27 Nov '15

27 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Base templates also contains <version> tag ...................................................................... restapi: Base templates also contains <version> tag Till now base templates did not contain <version> tag, it was only present in template sub-versions. This patch adds <version> tag to all templates to improve automation and consistency. Change-Id: I27d0a9988f97e55ea64fa1d40cdcc4c1c4a3fdbd Bug-Url: https://bugzilla.redhat.com/1284587 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java 2 files changed, 10 insertions(+), 13 deletions(-) Approvals: Jakub Niedermertl: Verified Juan Hernandez: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49226 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27d0a9988f97e55ea64fa1d40cdcc4c1c4a3fdbd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove unused getNetwork()
by juan.hernandez＠redhat.com 27 Nov '15

27 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: remove unused getNetwork() ...................................................................... core: remove unused getNetwork() Removed the unused private method BackendVirtualFunctionAllowedNetworkResource#getNetwork(). Change-Id: Ib45be65e161b8bb2c698e6dd4cf31df450e93ae3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVirtualFunctionAllowedNetworkResource.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/49270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib45be65e161b8bb2c698e6dd4cf31df450e93ae3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: BackendVirtualFunctionAllowedNetworkResource LinqUtils
by juan.hernandez＠redhat.com 27 Nov '15

27 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: BackendVirtualFunctionAllowedNetworkResource LinqUtils ...................................................................... core: BackendVirtualFunctionAllowedNetworkResource LinqUtils Replace the old-fashioned LinqUtils usage with the modern, built-in streaming API introduced in Java 8. Change-Id: I6eea559f0bbee78f39192b793de8161124a232cd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVirtualFunctionAllowedNetworkResource.java 1 file changed, 1 insertion(+), 8 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/49269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6eea559f0bbee78f39192b793de8161124a232cd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: BackendVirtualFunctionAllowedLabelsResource LinqUtils
by juan.hernandez＠redhat.com 27 Nov '15

27 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: BackendVirtualFunctionAllowedLabelsResource LinqUtils ...................................................................... core: BackendVirtualFunctionAllowedLabelsResource LinqUtils Replace the old-fashioned LinqUtils usage with the modern, built-in streaming API introduced in Java 8. Change-Id: I1fe604627a9fa78e68787b256a777d379e1cc2c1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVirtualFunctionAllowedLabelsResource.java 1 file changed, 3 insertions(+), 10 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/49268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fe604627a9fa78e68787b256a777d379e1cc2c1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: BackendHostNicsResource LinqUtils
by juan.hernandez＠redhat.com 27 Nov '15

27 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: BackendHostNicsResource LinqUtils ...................................................................... core: BackendHostNicsResource LinqUtils Replace the old-fashioned LinqUtils usage with the modern, built-in streaming API introduced in Java 8. Change-Id: I6541b0653cf917c338db0441f511baee1e272e1d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java 1 file changed, 2 insertions(+), 13 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/49267 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6541b0653cf917c338db0441f511baee1e272e1d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix issue in GlusterGeoRepSession.equals()
by amureini＠redhat.com 27 Nov '15

27 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix issue in GlusterGeoRepSession.equals() ...................................................................... core: Fix issue in GlusterGeoRepSession.equals() Fixes issue in GlusterGeoRepSession.equals() when comparing sessionId, which was cause by patch Ic5f7909fde498969d2c5b96d5ceb058253fa28f1 and discovered in Coverity CID 1340341. Change-Id: I276564edf533630ce778be3e2557d53325a1c1e2 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSession.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I276564edf533630ce778be3e2557d53325a1c1e2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[cli_3.6]: cli: Prepare for next release
by juan.hernandez＠redhat.com 27 Nov '15

27 Nov '15

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Prepare for next release ...................................................................... cli: Prepare for next release In preparation for the next release this patch increases the version number and sets the RPM release number to 0.1. Change-Id: If75a8ed363ad4d71be6b893ea7ce8e74d6824982 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M setup.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49304 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If75a8ed363ad4d71be6b893ea7ce8e74d6824982 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0