November 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.1]: automation:Not using port 8081 but port 80
by piotr.kliczewski＠gmail.com 27 Nov '15

27 Nov '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: automation:Not using port 8081 but port 80 ...................................................................... automation:Not using port 8081 but port 80 This will allow to seamlessly migrate to any artifactory and to route any requests through an http server if needed. Is required to migrate to the new artifactory in the phx infra Change-Id: I9a284ba24a81942cf4e470ebf4bc63816978e7a5 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M automation/build-artifacts.sh M automation/check-merged.sh M automation/check-patch.sh 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests David Caro: Verified -- To view, visit https://gerrit.ovirt.org/49277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a284ba24a81942cf4e470ebf4bc63816978e7a5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: automation:Not using port 8081 but port 80
by piotr.kliczewski＠gmail.com 27 Nov '15

27 Nov '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: automation:Not using port 8081 but port 80 ...................................................................... automation:Not using port 8081 but port 80 This will allow to seamlessly migrate to any artifactory and to route any requests through an http server if needed. Is required to migrate to the new artifactory in the phx infra Change-Id: I9a284ba24a81942cf4e470ebf4bc63816978e7a5 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M automation/build-artifacts.sh M automation/check-merged.sh M automation/check-patch.sh 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests David Caro: Verified -- To view, visit https://gerrit.ovirt.org/49276 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a284ba24a81942cf4e470ebf4bc63816978e7a5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: queryEnvKey db creds, rely on hostname fixes
by sbonazzo＠redhat.com 27 Nov '15

27 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: queryEnvKey db creds, rely on hostname fixes ...................................................................... packaging: setup: queryEnvKey db creds, rely on hostname fixes Changed the code querying for database credentials to use queryEnvKey. Rely on hostname fixes in ovirt-setup-lib to test for dns resolution only for the engine in all-in-one instead of always in all-in-one (including e.g. remote db). Also made that caller-configurable instead of env. Depends-On: https://gerrit.ovirt.org/#/c/43856/ Change-Id: I8ad3d19d73b41c608ee8ca806591a29b7a8216d6 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/database.py M packaging/setup/ovirt_engine_setup/util.py 2 files changed, 87 insertions(+), 96 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/42565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ad3d19d73b41c608ee8ca806591a29b7a8216d6 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: Generate WildFly overlay config in Makefile
by sbonazzo＠redhat.com 27 Nov '15

27 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: Generate WildFly overlay config in Makefile ...................................................................... packaging: Generate WildFly overlay config in Makefile Moves configuration of WildFly overlay from spec to Makefile to automatic configuration of overlay in development environment with possibility to override overlay directory. Change-Id: I6f8a7f730dbcd9e421d9f5b6100857706a40fb8d Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M Makefile M README.developer M ovirt-engine.spec.in 3 files changed, 19 insertions(+), 15 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48189 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f8a7f730dbcd9e421d9f5b6100857706a40fb8d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: automation:Not using port 8081 but port 80
by sbonazzo＠redhat.com 26 Nov '15

26 Nov '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: automation:Not using port 8081 but port 80 ...................................................................... automation:Not using port 8081 but port 80 This will allow to seamlessly migrate to any artifactory and to route any requests through an http server if needed. Is required to migrate to the new artifactory in the phx infra Change-Id: I9a284ba24a81942cf4e470ebf4bc63816978e7a5 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M automation/build-artifacts.sh M automation/check-merged.sh M automation/check-patch.sh 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests David Caro: Verified -- To view, visit https://gerrit.ovirt.org/49275 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a284ba24a81942cf4e470ebf4bc63816978e7a5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: UpdateVmCommand LinqUtils
by amureini＠redhat.com 26 Nov '15

26 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateVmCommand LinqUtils ...................................................................... core: UpdateVmCommand LinqUtils Replace usages of LinqUtils with Java 8's standard streaming API in order to standardize the code and make it easier to read. Change-Id: I06110610749d37d86493dcaa33d2374366ad39a7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 1 file changed, 2 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48959 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06110610749d37d86493dcaa33d2374366ad39a7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ChangeVMClusterCommand ObjectUtils
by amureini＠redhat.com 26 Nov '15

26 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: ChangeVMClusterCommand ObjectUtils ...................................................................... core: ChangeVMClusterCommand ObjectUtils Replace the usage of Apache Commons Lang's ObjectUtils.equals with Java 7's Objects.equals, as part of the effort to reuse as much of the JDK as possible and bring the usage of unneeded third parties down to a minimum. Change-Id: I590ec675f7292946c308f009f3d5492afca9e314 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49254 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I590ec675f7292946c308f009f3d5492afca9e314 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ChangeVMClusterCommand LinqUtils
by amureini＠redhat.com 26 Nov '15

26 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: ChangeVMClusterCommand LinqUtils ...................................................................... core: ChangeVMClusterCommand LinqUtils Replace usages of LinqUtils with Java 8's standard streaming API in order to standardize the code and make it easier to read. Change-Id: I3a513e9322f35e12deeaed4527a94e4d3f11b3fd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java 1 file changed, 3 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a513e9322f35e12deeaed4527a94e4d3f11b3fd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddVmFromScratchCommand streaming API
by amureini＠redhat.com 26 Nov '15

26 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmFromScratchCommand streaming API ...................................................................... core: AddVmFromScratchCommand streaming API Replace outdate LinqUtils calls with Java 8's streaming API. Besides improving the code, this patch offers a slight performance benefit by using the short-circuit terminator findFirst which returns the first domain to satisfy the condition instead of having to iterate all of them just to retrieve the ID of the first one. Change-Id: I3bae8b6f5b6626a76971082c0a8b4e678532c26e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java 1 file changed, 5 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48957 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bae8b6f5b6626a76971082c0a8b4e678532c26e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddVmFromScratchCommand DbFacade
by amureini＠redhat.com 26 Nov '15

26 Nov '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmFromScratchCommand DbFacade ...................................................................... core: AddVmFromScratchCommand DbFacade Remove explicit calls to DbFacade and replace them with calls to the specific DAOs in order to reduce robustness and make the code more readable. Change-Id: Id5a6acd37f6077bee768df5f343e2415cc9347d1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48956 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5a6acd37f6077bee768df5f343e2415cc9347d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0