August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: use 'Run Once' instead of Run-Once in message
by tnisan＠redhat.com 27 Aug '15

27 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: use 'Run Once' instead of Run-Once in message ...................................................................... core: use 'Run Once' instead of Run-Once in message Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1141771 Change-Id: I7c5aee9c30d824ac9902ab1a5ede4c62bc123493 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c5aee9c30d824ac9902ab1a5ede4c62bc123493 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Check if pvsize is not empty-GetDeviceList
by amureini＠redhat.com 27 Aug '15

27 Aug '15

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Check if pvsize is not empty-GetDeviceList ...................................................................... engine: Check if pvsize is not empty-GetDeviceList In the GetDeviceListVDSCommand, check if the pvsize entry is not an empty String before trying to parse it into Long. Change-Id: I6d946eddc5f36cdf48fe82adc461b58880d5bdd9 Bug-Url: https://bugzilla.redhat.com/1256027 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/45348 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d946eddc5f36cdf48fe82adc461b58880d5bdd9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Extend size converter
by sabose＠redhat.com 27 Aug '15

27 Aug '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: Extend size converter ...................................................................... engine: Extend size converter This patch extends size converter to support units upto Yobibyte. Change-Id: I19311ff7a0590b85d2466cb5e4b76b67080f66ed Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1250024 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/SizeConverterTest.java 2 files changed, 26 insertions(+), 1 deletion(-) Approvals: anmolbabu: Verified Sahina Bose: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19311ff7a0590b85d2466cb5e4b76b67080f66ed Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Added vdsm 3.6 check-patch
by dcaroest＠redhat.com 27 Aug '15

27 Aug '15

David Caro has submitted this change and it was merged. Change subject: Added vdsm 3.6 check-patch ...................................................................... Added vdsm 3.6 check-patch Change-Id: I92bd507d2f3a954f71d2a3003af780d96e2062ab Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/projects/vdsm/vdsm_standard.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Jenkins CI: Passed CI tests David Caro: Verified; Ready for review Dima Kuznetsov: Looks good to me -- To view, visit https://gerrit.ovirt.org/45281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92bd507d2f3a954f71d2a3003af780d96e2062ab Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: sercon: enable on hosts clusterLevel >= 3.6
by tnisan＠redhat.com 27 Aug '15

27 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: sercon: enable on hosts clusterLevel >= 3.6 ...................................................................... core: sercon: enable on hosts clusterLevel >= 3.6 Since commit ae32a1745935e6a8845f23714dede82889cac041 we inconditionally enable serial console on all the (re)deployed hosts. We need to make sure to leave old clusters alone and unchanged, and enable serial console support only on hosts which become part of clusters with clusterLevel >= 3.6. Change-Id: I5fdb0e20f1fbfd115b710fb1f3b9439c08e33c9b Bug-Url: https://bugzilla.redhat.com/1254253 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 4 files changed, 25 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fdb0e20f1fbfd115b710fb1f3b9439c08e33c9b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Add infrastructure for Cluster Edit Checks
by tnisan＠redhat.com 27 Aug '15

27 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Add infrastructure for Cluster Edit Checks ...................................................................... core: Add infrastructure for Cluster Edit Checks Added infrastructure to encapsulate various checks and user-facing warnings when edit of cluster may have harmful consequences. With this new infrastructure new checks were added: * when enabling /dev/random on cluster whether hosts support it * when enabling /dev/hwrng on cluster whether hosts support it * when increasing cluster level, whether host support new machine types And existing check refactored into new infrastructure: * when decreasing cluster CPU level and VM have higher CPU level override than the new value Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1202349 Change-Id: I3ead66a953380210986b26a54c239fa591335bac Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractRngDeviceClusterEditChecker.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClusterEditChecker.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EmulatedMachineClusterEditChecker.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetClusterEditWarningsQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetClusterUnsupportedVmsCpusQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HwrngDeviceClusterEditChecker.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RandomDeviceClusterEditChecker.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UnsupportedVmCpuClusterEditChecker.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ClusterEditWarnings.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ClusterEditParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetClusterUnsupportedVmsCpusParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterWarningsModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/cluster/ClusterWarningsPopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterWarningsPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterWarningsPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 28 files changed, 712 insertions(+), 150 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45291 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ead66a953380210986b26a54c239fa591335bac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Changed publishers to use resources.ovirt.org ssh connection
by dcaroest＠redhat.com 27 Aug '15

27 Aug '15

David Caro has submitted this change and it was merged. Change subject: Changed publishers to use resources.ovirt.org ssh connection ...................................................................... Changed publishers to use resources.ovirt.org ssh connection We are going to migrate resources.ovirt.org to another host while ovirt.org will leave at the old place. Publishers were configured to use ovirt.org SSH connection. Now we have separate connection for resources and thuse need to change this so it will not brake when resources will point to another host. Change-Id: Ibac0fe5af7bda4590f08d2099a244d03919c5097 Signed-off-by: Anton Marchukov <amarchuk(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-3.5.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Barak Korren: Looks good to me Anton Marchukov: Verified; Ready for review David Caro: Looks good to me; Passed CI tests; Ready for merge Max Kovgan: Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/45349 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibac0fe5af7bda4590f08d2099a244d03919c5097 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: sercon: enable on hosts clusterLevel >= 3.6
by ofrenkel＠redhat.com 27 Aug '15

27 Aug '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: sercon: enable on hosts clusterLevel >= 3.6 ...................................................................... core: sercon: enable on hosts clusterLevel >= 3.6 Since commit ae32a1745935e6a8845f23714dede82889cac041 we inconditionally enable serial console on all the (re)deployed hosts. We need to make sure to leave old clusters alone and unchanged, and enable serial console support only on hosts which become part of clusters with clusterLevel >= 3.6. Change-Id: I5fdb0e20f1fbfd115b710fb1f3b9439c08e33c9b Bug-Url: https://bugzilla.redhat.com/1254253 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 4 files changed, 26 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fdb0e20f1fbfd115b710fb1f3b9439c08e33c9b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: use 'Run Once' instead of Run-Once in message
by ofrenkel＠redhat.com 27 Aug '15

27 Aug '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: use 'Run Once' instead of Run-Once in message ...................................................................... core: use 'Run Once' instead of Run-Once in message Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1141771 Change-Id: I7c5aee9c30d824ac9902ab1a5ede4c62bc123493 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Omer Frenkel: Verified -- To view, visit https://gerrit.ovirt.org/45365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c5aee9c30d824ac9902ab1a5ede4c62bc123493 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Custon Vm Icons preserved over next-run configuration
by tnisan＠redhat.com 27 Aug '15

27 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Custon Vm Icons preserved over next-run configuration ...................................................................... core: Custon Vm Icons preserved over next-run configuration Custom icons were lost if vm required next-run configuration, because icons are not stored in ovf files. SnapshotManager#updateVmFromConfiguration() altered in order to copy custom icons from old vm record. Bug-Url: https://bugzilla.redhat.com/1251152 Change-Id: I2cfd87c38ac04e5f9d39e7443fa791814f682fef Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/IconUtils.java 2 files changed, 7 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cfd87c38ac04e5f9d39e7443fa791814f682fef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0