August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: add action info when failing with 'not enough MAC'
by ofrenkel＠redhat.com 26 Aug '15

26 Aug '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: add action info when failing with 'not enough MAC' ...................................................................... core: add action info when failing with 'not enough MAC' Change-Id: Ifcd27561a8342cfe7a10b191d04c91fa7356bcb6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1195039 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcd27561a8342cfe7a10b191d04c91fa7356bcb6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Custon Vm Icons preserved over next-run configuration
by ofrenkel＠redhat.com 26 Aug '15

26 Aug '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Custon Vm Icons preserved over next-run configuration ...................................................................... core: Custon Vm Icons preserved over next-run configuration Custom icons were lost if vm required next-run configuration, because icons are not stored in ovf files. SnapshotManager#updateVmFromConfiguration() altered in order to copy custom icons from old vm record. Bug-Url: https://bugzilla.redhat.com/1251152 Change-Id: I2cfd87c38ac04e5f9d39e7443fa791814f682fef Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/IconUtils.java 2 files changed, 7 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45295 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cfd87c38ac04e5f9d39e7443fa791814f682fef Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: fix error code mappings for brick provisioning
by sabose＠redhat.com 26 Aug '15

26 Aug '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: fix error code mappings for brick provisioning ...................................................................... gluster: fix error code mappings for brick provisioning Fix the error code mappings for brick provisioning. Error mapping in oVirt engine for brick provisioning is corrupted. There are few error codes which are not mapped and there are few error codes which doesn't exists. Correcting all error codes as part of this patch. Change-Id: I14c8e83d4b76f5d67b6288a73e88d130a7f998d8 Bug-Url: https://bugzilla.redhat.com/1231722 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java 4 files changed, 28 insertions(+), 10 deletions(-) Approvals: Sahina Bose: Looks good to me, approved; Passed CI tests Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/45347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14c8e83d4b76f5d67b6288a73e88d130a7f998d8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Added missing java timezone mapping and added test
by tnisan＠redhat.com 26 Aug '15

26 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Added missing java timezone mapping and added test ...................................................................... core: Added missing java timezone mapping and added test The mapping for the 'Central Standard Time (Mexico)' to the corresponding java timezone name was missing and results in VMs being created with that VM assigned, to end up having a UTC timezone. The test verifies, that all Windows timezones, do have a mapping target. Change-Id: I6ecf3b69e18e42808303861f39363f93d5b72269 Bug-Url: https://bugzilla.redhat.com/1255062 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/TimeZoneTypeTest.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/WindowsJavaTimezoneMapping.java 2 files changed, 18 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Vinzenz Feenstra: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ecf3b69e18e42808303861f39363f93d5b72269 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Update ovirtmgmt network description
by tnisan＠redhat.com 26 Aug '15

26 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Update ovirtmgmt network description ...................................................................... engine: Update ovirtmgmt network description Add "Default" to ovirtmgmt network description. Change-Id: Iadf25b0c29db3816342725f0cac43c00438786b0 Bug-Url: https://bugzilla.redhat.com/1202322 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/44406 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadf25b0c29db3816342725f0cac43c00438786b0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Allow to supply additional info on SetupNetworks vio...
by tnisan＠redhat.com 26 Aug '15

26 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Allow to supply additional info on SetupNetworks violations ...................................................................... engine: Allow to supply additional info on SetupNetworks violations Add ability to supply addtional info on SetupNetworks violations Add networks parameter for NETWORK_CANNOT_DETACH_NETWORK_USED_BY_VMS message. Change-Id: I51b18ec02f16c1315b446cfaaccc8701693eafca Bug-Url: https://bugzilla.redhat.com/1115098 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/DetachNetworkFromVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/collections/MultiValueMapUtils.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/violation/DetailedViolation.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/violation/ViolatingEntityDetails.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/violation/Violation.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/violation/ViolationRenderer.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 14 files changed, 225 insertions(+), 53 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/45127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51b18ec02f16c1315b446cfaaccc8701693eafca Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: gluster: fix error code mappings for brick provisioning
by sabose＠redhat.com 26 Aug '15

26 Aug '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: fix error code mappings for brick provisioning ...................................................................... gluster: fix error code mappings for brick provisioning Fix the error code mappings for brick provisioning. Error mapping in oVirt engine for brick provisioning is corrupted. There are few error codes which are not mapped and there are few error codes which doesn't exists. Correcting all error codes as part of this patch. Change-Id: I14c8e83d4b76f5d67b6288a73e88d130a7f998d8 Bug-Url: https://bugzilla.redhat.com/1231722 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java 4 files changed, 29 insertions(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/44302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14c8e83d4b76f5d67b6288a73e88d130a7f998d8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Added user restoration to mock cleanup
by dcaroest＠redhat.com 26 Aug '15

26 Aug '15

David Caro has submitted this change and it was merged. Change subject: Added user restoration to mock cleanup ...................................................................... Added user restoration to mock cleanup This solves the issue that happens after aborting a mock job Change-Id: Icf6c13f482f041b056879361a09d1676921073dc Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/mock_cleanup.sh 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for review Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/45337 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf6c13f482f041b056879361a09d1676921073dc Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: List upgrade host failure statuses in message
by oourfali＠redhat.com 25 Aug '15

25 Aug '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: List upgrade host failure statuses in message ...................................................................... core: List upgrade host failure statuses in message Cherry-picked from If6802e6975e337b9268d6722d320f0f3c7e42ed7 Change-Id: If6802e6975e337b9268d6722d320f0f3c7e42ed7 Bug-Url: https://bugzilla.redhat.com/1253362 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/UpgradeHostValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/UpgradeHostValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 10 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45275 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6802e6975e337b9268d6722d320f0f3c7e42ed7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: slf4j: use ovirt snapshot as source for slf4j rpm
by dcaroest＠redhat.com 25 Aug '15

25 Aug '15

David Caro has submitted this change and it was merged. Change subject: slf4j: use ovirt snapshot as source for slf4j rpm ...................................................................... slf4j: use ovirt snapshot as source for slf4j rpm Change-Id: I3970bae430ec667381b81c18bc1b1377505ec274 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M jobs/confs/projects/vdsm-jsonrpc-java/vdsm-jsonrpc-java_create-rpms.yaml 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/45324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3970bae430ec667381b81c18bc1b1377505ec274 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0