August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: restapi: allow new VM with no dedicated host in migration po...
by tnisan＠redhat.com 25 Aug '15

25 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: allow new VM with no dedicated host in migration policy ...................................................................... restapi: allow new VM with no dedicated host in migration policy Fix regression error. When new VM is created with migration policy. Allow empty host element. Validate host element only if there is host element with id or with name. Change-Id: I5fbc644cfeade93846c4c0ef6190f65f77ab8951 Bug-Url: http://bugzilla.redhat.com/1249521 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Ori Liel: Looks good to me, approved Dudi Maroshi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fbc644cfeade93846c4c0ef6190f65f77ab8951 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: resize columns on import Glance image dialog
by tnisan＠redhat.com 25 Aug '15

25 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: resize columns on import Glance image dialog ...................................................................... webadmin: resize columns on import Glance image dialog Import Glance images dialog: * added support for resizable columns. * specified width for each column (which is needed for proper resizing). Change-Id: I549755b01310afaa662bf4fce2a5ecbc67905241 Bug-Url: https://bugzilla.redhat.com/1196749 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45296 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I549755b01310afaa662bf4fce2a5ecbc67905241 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Locate VM data using pool id, not name
by tnisan＠redhat.com 25 Aug '15

25 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Locate VM data using pool id, not name ...................................................................... restapi: Locate VM data using pool id, not name Currently when a VM pool is updated the VM data is located using the name of the pool. But the name of the pool may be also updated during the same operation, which may result in not finding the VM data because there is no such pool yet. To avoid this potential (and real) conflict this patch changes the RESTAPI so that it uses the identifier of the pool instead of the name, as the identifier will never change. Change-Id: I387d122d1019f25f026806ed0042aa32b5db8698 Bug-Url: https://bugzilla.redhat.com/1256411 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 955c08a8ef661305da86a658d3597f7e2940b599) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45292 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I387d122d1019f25f026806ed0042aa32b5db8698 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Disable "Manage Networks" on a detached cluster
by tnisan＠redhat.com 25 Aug '15

25 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Disable "Manage Networks" on a detached cluster ...................................................................... webadmin: Disable "Manage Networks" on a detached cluster Disable "Manage Networks" on a detached cluster Change-Id: If85991f22709793128a867a9c9c3952cbd68b3e9 Bug-Url: https://bugzilla.redhat.com/1206891 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/45137 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If85991f22709793128a867a9c9c3952cbd68b3e9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-cli[master]: cli: Don't check for old version of the SDK
by juan.hernandez＠redhat.com 25 Aug '15

25 Aug '15

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Don't check for old version of the SDK ...................................................................... cli: Don't check for old version of the SDK This patch removes a check of the SDK version that the CLI used to do in order to perform verification of credentials. This is no longer necessary because the CLI explicitly requires (in both setup.py and in the .spec file) a version of the SDK where this isn't needed. In addition the way the version comparison is done triggers a warning message in some versions of the Python setuptools package. Change-Id: Ia83622fc122d30d9f0b2492755a0caff262c89ba Related: https://bugzilla.redhat.com/1255409 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtcli/command/connect.py 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45189 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia83622fc122d30d9f0b2492755a0caff262c89ba Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-cli[master]: cli: Initial support for Mac OS
by juan.hernandez＠redhat.com 25 Aug '15

25 Aug '15

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Initial support for Mac OS ...................................................................... cli: Initial support for Mac OS This patch adds initial support for Mac OS, just doing exactly the same for "darwin" than for "linux2". Change-Id: I7a9f92951adb8ecdeb456a67814410df558821e2 Bug-Url: https://bugzilla.redhat.com/1255409 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/cli/platform/__init__.py M src/ovirtcli/platform/__init__.py M src/ovirtcli/platform/windows/__init__.py 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Ori Liel: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45160 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a9f92951adb8ecdeb456a67814410df558821e2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-cli[master]: cli: Generate parse tables during build
by juan.hernandez＠redhat.com 25 Aug '15

25 Aug '15

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Generate parse tables during build ...................................................................... cli: Generate parse tables during build Currently the parse tables used by ply are generated during the RPM installation, or, for non RPM platforms, during runtime. This causes warnings because the user running the CLI may not have permissions to write those parse tables. To avoid those warnings this patch changes the CLI build process so that the parse tables are generated from the "setup.py" script and included in the binary distribution. Change-Id: I933a56b3ccbf5bc0e39feed9a2c61be89970dd84 Bug-Url: https://bugzilla.redhat.com/1255409 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-cli.spec.in M setup.py M src/cli/plyparse.py 3 files changed, 36 insertions(+), 15 deletions(-) Approvals: Ori Liel: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45159 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I933a56b3ccbf5bc0e39feed9a2c61be89970dd84 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Fabrice Bacchella <fabrice.bacchella(a)orange.fr> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Support update of OVF_DATA for all DC versions.
by tnisan＠redhat.com 25 Aug '15

25 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Support update of OVF_DATA for all DC versions. ...................................................................... core: Support update of OVF_DATA for all DC versions. Support update of VMs' and Tempaltes' OVF_DATA that contain disks which reside on Storage Domains maintained in a 3.4 DC and below. Change-Id: Ia603224b03126eed722280cb7225ce14aef1bf91 Bug-Url: https://bugzilla.redhat.com/1172609 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStoragePoolCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ProcessOvfUpdateForStoragePoolParameters.java 5 files changed, 47 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/45287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia603224b03126eed722280cb7225ce14aef1bf91 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[master]: removing wrong _self attribute access on gluster code
by msivak＠redhat.com 25 Aug '15

25 Aug '15

Martin Sivák has submitted this change and it was merged. Change subject: removing wrong _self attribute access on gluster code ...................................................................... removing wrong _self attribute access on gluster code removing a wrong access to a not existing _self attribute on gluster specific code. Change-Id: Idb900ba2901e66666ccf3bd48bc46144641ca734 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1254745 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/storage_server.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb900ba2901e66666ccf3bd48bc46144641ca734 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[master]: Revert "ha: removing wrong _self attribute access on gluster...
by msivak＠redhat.com 25 Aug '15

25 Aug '15

Martin Sivák has submitted this change and it was merged. Change subject: Revert "ha: removing wrong _self attribute access on gluster code" ...................................................................... Revert "ha: removing wrong _self attribute access on gluster code" This reverts commit 183a4ffa74df1e6c3d91bfad29767b2ce1b03e61. Change-Id: Ie8f9dbd733fe57adff3d0b1f4a7e89a4ec55c914 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/storage_server.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8f9dbd733fe57adff3d0b1f4a7e89a4ec55c914 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0